From patchwork Mon Jan 28 08:31:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "lan,Tianyu" X-Patchwork-Id: 2053651 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 53CB6E00C6 for ; Mon, 28 Jan 2013 08:34:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754545Ab3A1IeJ (ORCPT ); Mon, 28 Jan 2013 03:34:09 -0500 Received: from mga01.intel.com ([192.55.52.88]:19265 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754176Ab3A1IeI (ORCPT ); Mon, 28 Jan 2013 03:34:08 -0500 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 28 Jan 2013 00:34:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,550,1355126400"; d="scan'208";a="279149692" Received: from lantianyu-ws.sh.intel.com (HELO localhost) ([10.239.36.117]) by fmsmga001.fm.intel.com with ESMTP; 28 Jan 2013 00:34:07 -0800 From: Lan Tianyu To: rjw@sisk.pl Cc: Lan Tianyu , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH] PM/CORE: Fix using sizeof without parenthesis in the sysfs.c Date: Mon, 28 Jan 2013 16:31:49 +0800 Message-Id: <1359361909-28793-1-git-send-email-tianyu.lan@intel.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Kernel style uses parenthesis around sizeof. Commit 66c80b60 has already added such check in the scripts/checkpatch.pl. Signed-off-by: Lan Tianyu --- drivers/base/power/sysfs.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/base/power/sysfs.c b/drivers/base/power/sysfs.c index 50d16e3..f089b80 100644 --- a/drivers/base/power/sysfs.c +++ b/drivers/base/power/sysfs.c @@ -119,9 +119,9 @@ static ssize_t control_store(struct device * dev, struct device_attribute *attr, if (cp) len = cp - buf; device_lock(dev); - if (len == sizeof ctrl_auto - 1 && strncmp(buf, ctrl_auto, len) == 0) + if (len == sizeof(ctrl_auto - 1) && strncmp(buf, ctrl_auto, len) == 0) pm_runtime_allow(dev); - else if (len == sizeof ctrl_on - 1 && strncmp(buf, ctrl_on, len) == 0) + else if (len == sizeof(ctrl_on - 1) && strncmp(buf, ctrl_on, len) == 0) pm_runtime_forbid(dev); else n = -EINVAL; @@ -321,11 +321,11 @@ wake_store(struct device * dev, struct device_attribute *attr, cp = memchr(buf, '\n', n); if (cp) len = cp - buf; - if (len == sizeof enabled - 1 - && strncmp(buf, enabled, sizeof enabled - 1) == 0) + if (len == sizeof(enabled - 1) + && strncmp(buf, enabled, sizeof(enabled - 1)) == 0) device_set_wakeup_enable(dev, 1); - else if (len == sizeof disabled - 1 - && strncmp(buf, disabled, sizeof disabled - 1) == 0) + else if (len == sizeof(disabled - 1) + && strncmp(buf, disabled, sizeof(disabled - 1)) == 0) device_set_wakeup_enable(dev, 0); else return -EINVAL; @@ -546,9 +546,9 @@ static ssize_t async_store(struct device *dev, struct device_attribute *attr, cp = memchr(buf, '\n', n); if (cp) len = cp - buf; - if (len == sizeof enabled - 1 && strncmp(buf, enabled, len) == 0) + if (len == sizeof(enabled - 1) && strncmp(buf, enabled, len) == 0) device_enable_async_suspend(dev); - else if (len == sizeof disabled - 1 && strncmp(buf, disabled, len) == 0) + else if (len == sizeof(disabled - 1) && strncmp(buf, disabled, len) == 0) device_disable_async_suspend(dev); else return -EINVAL;