diff mbox

[2/2] ACPI: Overriding ACPI tables via initrd only works with an initrd and on X86

Message ID 1361538742-67599-3-git-send-email-trenn@suse.de (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Thomas Renninger Feb. 22, 2013, 1:12 p.m. UTC
Reflect this dependency in Kconfig.

Shorten the config description as suggested by Borislav Petkov.

Finding a suitable memory area to store the modified table(s) has been
taken over from arch/x86/kernel/setup.c and makes use of max_low_pfn_mapped:
memblock_find_in_range(0, max_low_pfn_mapped,...)
This one is X86 specific. It may not be hard to extend this functionality
for other ACPI aware architectures if there is need for.

For now make this feature only available for X86 to avoid build failures on
IA64, compare with:
https://bugzilla.kernel.org/show_bug.cgi?id=54091


Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Thomas Renninger <Thomas Renninger" trenn@suse.de>
---
 drivers/acpi/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Yinghai Lu Feb. 25, 2013, 8 p.m. UTC | #1
On Fri, Feb 22, 2013 at 5:12 AM, Thomas Renninger <trenn@suse.de> wrote:
> Reflect this dependency in Kconfig.
>
> Shorten the config description as suggested by Borislav Petkov.
>
> Finding a suitable memory area to store the modified table(s) has been
> taken over from arch/x86/kernel/setup.c and makes use of max_low_pfn_mapped:
> memblock_find_in_range(0, max_low_pfn_mapped,...)
> This one is X86 specific. It may not be hard to extend this functionality
> for other ACPI aware architectures if there is need for.
>
> For now make this feature only available for X86 to avoid build failures on
> IA64, compare with:
> https://bugzilla.kernel.org/show_bug.cgi?id=54091
>
>
> Signed-off-by: Thomas Renninger <trenn@suse.de>
> Signed-off-by: Thomas Renninger <Thomas Renninger" trenn@suse.de>

what is that?

you need to fix your scripts.

> ---
>  drivers/acpi/Kconfig |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 1a4ed64..c692404 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -266,7 +266,8 @@ config ACPI_CUSTOM_DSDT
>         default ACPI_CUSTOM_DSDT_FILE != ""
>
>  config ACPI_INITRD_TABLE_OVERRIDE
> -       bool "ACPI tables can be passed via uncompressed cpio in initrd"
> +       bool "ACPI tables override via initrd"
> +       depends on BLK_DEV_INITRD && X86
>         default n
>         help
>           This option provides functionality to override arbitrary ACPI tables

Can replace max_low_pfn_mapped with max_low_pfn instead ?
like to see if you can put acpi tables above 4G for x86_64.

if it does not work, you can use min(max_low_pfn<<PAGE_SHIFT,  0xffffffffUL)
instead.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
H. Peter Anvin Feb. 25, 2013, 8:02 p.m. UTC | #2
On 02/25/2013 12:00 PM, Yinghai Lu wrote:
> 
> Can replace max_low_pfn_mapped with max_low_pfn instead ?
> like to see if you can put acpi tables above 4G for x86_64.
> 
> if it does not work, you can use min(max_low_pfn<<PAGE_SHIFT,  0xffffffffUL)
> instead.
> 

This is part of why we really need to get rid of these stupid variables
one and for all.  The only exception should perhaps be to mark the
HIGHMEM crossover point on HIGHMEM systems.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yinghai Lu Feb. 25, 2013, 8:07 p.m. UTC | #3
On Mon, Feb 25, 2013 at 12:02 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> On 02/25/2013 12:00 PM, Yinghai Lu wrote:
>>
>> Can replace max_low_pfn_mapped with max_low_pfn instead ?
>> like to see if you can put acpi tables above 4G for x86_64.
>>
>> if it does not work, you can use min(max_low_pfn<<PAGE_SHIFT,  0xffffffffUL)
>> instead.
>>
>
> This is part of why we really need to get rid of these stupid variables
> one and for all.  The only exception should perhaps be to mark the
> HIGHMEM crossover point on HIGHMEM systems.

yes, we can drop max_low_pfn_mapped at least.

I should drop that in for-x86-mm2 time point, but saw ThomasR is using that,
so i dropped that patch to make the merge easy.

Now after Thomas change to max_low_pfn, we can drop max_low_pfn_mapped.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 1a4ed64..c692404 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -266,7 +266,8 @@  config ACPI_CUSTOM_DSDT
 	default ACPI_CUSTOM_DSDT_FILE != ""
 
 config ACPI_INITRD_TABLE_OVERRIDE
-	bool "ACPI tables can be passed via uncompressed cpio in initrd"
+	bool "ACPI tables override via initrd"
+	depends on BLK_DEV_INITRD && X86
 	default n
 	help
 	  This option provides functionality to override arbitrary ACPI tables