| Message ID | 1362558611-32255-2-git-send-email-tangchen@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wednesday, March 06, 2013 04:30:06 PM Tang Chen wrote: > There is a leading space in front of "unlock" label in acpi_memory_device_notify(). Remove it. > > Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> > --- > drivers/acpi/acpi_memhotplug.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c > index da1f82b..8a10c23 100644 > --- a/drivers/acpi/acpi_memhotplug.c > +++ b/drivers/acpi/acpi_memhotplug.c > @@ -369,7 +369,7 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data) > kfree(ej_event); > } > > - unlock: > +unlock: > acpi_scan_lock_release(); > if (ACPI_SUCCESS(status)) > return; The leading space is actually in agreement with the kernel coding style (and there's a reason why it's there). Thanks, Rafael
2013/3/26 Rafael J. Wysocki <rjw@sisk.pl>: > On Wednesday, March 06, 2013 04:30:06 PM Tang Chen wrote: >> There is a leading space in front of "unlock" label in acpi_memory_device_notify(). Remove it. >> >> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> >> --- >> drivers/acpi/acpi_memhotplug.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c >> index da1f82b..8a10c23 100644 >> --- a/drivers/acpi/acpi_memhotplug.c >> +++ b/drivers/acpi/acpi_memhotplug.c >> @@ -369,7 +369,7 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data) >> kfree(ej_event); >> } >> >> - unlock: >> +unlock: >> acpi_scan_lock_release(); >> if (ACPI_SUCCESS(status)) >> return; > > The leading space is actually in agreement with the kernel coding style > (and there's a reason why it's there). Well, I'm curious. What's the reason ? I didn't see anything in Documentation/CodingStyle about that. Regards, Richard. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, March 26, 2013 02:23:49 PM Richard Genoud wrote: > 2013/3/26 Rafael J. Wysocki <rjw@sisk.pl>: > > On Wednesday, March 06, 2013 04:30:06 PM Tang Chen wrote: > >> There is a leading space in front of "unlock" label in acpi_memory_device_notify(). Remove it. > >> > >> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> > >> --- > >> drivers/acpi/acpi_memhotplug.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c > >> index da1f82b..8a10c23 100644 > >> --- a/drivers/acpi/acpi_memhotplug.c > >> +++ b/drivers/acpi/acpi_memhotplug.c > >> @@ -369,7 +369,7 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data) > >> kfree(ej_event); > >> } > >> > >> - unlock: > >> +unlock: > >> acpi_scan_lock_release(); > >> if (ACPI_SUCCESS(status)) > >> return; > > > > The leading space is actually in agreement with the kernel coding style > > (and there's a reason why it's there). > > Well, I'm curious. What's the reason ? > I didn't see anything in Documentation/CodingStyle about that. Some tools had problems with labels starting right at the start of the line. patch or diff or something similar IIRC. That's not the case any more, but there's a leading space before many labels in the kernel and that is part of the coding style, actually, even if it is not documented. Certainly, it's not something to fix. Thanks, Rafael
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c index da1f82b..8a10c23 100644 --- a/drivers/acpi/acpi_memhotplug.c +++ b/drivers/acpi/acpi_memhotplug.c @@ -369,7 +369,7 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data) kfree(ej_event); } - unlock: +unlock: acpi_scan_lock_release(); if (ACPI_SUCCESS(status)) return;
There is a leading space in front of "unlock" label in acpi_memory_device_notify(). Remove it. Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> --- drivers/acpi/acpi_memhotplug.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)