From patchwork Thu Mar 7 19:39:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 2233561 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id E5012DFE75 for ; Thu, 7 Mar 2013 19:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933292Ab3CGTjz (ORCPT ); Thu, 7 Mar 2013 14:39:55 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:49304 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932336Ab3CGTjz (ORCPT ); Thu, 7 Mar 2013 14:39:55 -0500 Received: from 64-126-113-177.dyn.everestkc.net ([64.126.113.177] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UDgfR-000522-RL; Thu, 07 Mar 2013 19:39:54 +0000 From: Seth Forshee To: linux-acpi@vger.kernel.org Cc: Matthew Garrett , Len Brown , "Rafael J. Wysocki" , Ben Jencks , joeyli , Seth Forshee Subject: [PATCH 5/5] acpi_video: Don't handle ACPI brightness notifications by default Date: Thu, 7 Mar 2013 13:39:40 -0600 Message-Id: <1362685180-7768-5-git-send-email-seth.forshee@canonical.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1362685180-7768-1-git-send-email-seth.forshee@canonical.com> References: <20130307193812.GD24233@thinkpad-t410> <1362685180-7768-1-git-send-email-seth.forshee@canonical.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Windows 8 requires all backlight interfaces to report 101 brightness values, and as a result we're starting to see machines with that many brightness levels in _BCL. For machines which send these notifications when the brightness up/down keys are pressed this means a lot of key presses to get any kind of noticeable change in brightness. For a while now we've had the ability to disable in-kernel handling of notifications via the video.brightness_switch_enabled parameter. Change this to default to off, and let userspace choose more reasonable increments for changing the brightness. Signed-off-by: Seth Forshee --- drivers/acpi/video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index 6a19bf7..431b22e 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -69,7 +69,7 @@ MODULE_AUTHOR("Bruno Ducrot"); MODULE_DESCRIPTION("ACPI Video Driver"); MODULE_LICENSE("GPL"); -static bool brightness_switch_enabled = 1; +static bool brightness_switch_enabled = 0; module_param(brightness_switch_enabled, bool, 0644); /*