diff mbox

[2/2] ACPI/APEI: Update einj documentation for param1/param2

Message ID 1368671347-22415-3-git-send-email-gong.chen@linux.intel.com (mailing list archive)
State Changes Requested, archived
Headers show

Commit Message

Chen Gong May 16, 2013, 2:29 a.m. UTC
To ensure EINJ working well when injecting errors via EINJ
table, add some attentions for param1/param2.

Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
---
 Documentation/acpi/apei/einj.txt |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Borislav Petkov May 16, 2013, 11:07 a.m. UTC | #1
On Wed, May 15, 2013 at 10:29:07PM -0400, Chen Gong wrote:
> To ensure EINJ working well when injecting errors via EINJ
> table, add some attentions for param1/param2.
> 
> Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
> ---
>  Documentation/acpi/apei/einj.txt |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/acpi/apei/einj.txt b/Documentation/acpi/apei/einj.txt
> index e20b6da..80c4ab2 100644
> --- a/Documentation/acpi/apei/einj.txt
> +++ b/Documentation/acpi/apei/einj.txt
> @@ -47,11 +47,15 @@ directory apei/einj. The following files are provided.
>  
>  - param1
>    This file is used to set the first error parameter value. Effect of
> -  parameter depends on error_type specified.
> +  parameter depends on error_type specified. For exmaple, if error
> +  type is memory relatd type, the param1 should be a valid physical
> +  memory address.
>  
>  - param2
>    This file is used to set the second error parameter value. Effect of
> -  parameter depends on error_type specified.
> +  parameter depends on error_type specified. For example, if error
> +  type is memory relatd type, the param2 should be a valid physical
> +  memory address mask, say, 0xfffffffffffff000.
>  
>  - notrigger
>    The EINJ mechanism is a two step process. First inject the error, then

Please run those through the spell checker.

Thanks.
Chen Gong May 17, 2013, 5:10 a.m. UTC | #2
On Thu, May 16, 2013 at 01:07:05PM +0200, Borislav Petkov wrote:
> Date: Thu, 16 May 2013 13:07:05 +0200
> From: Borislav Petkov <bp@alien8.de>
> To: Chen Gong <gong.chen@linux.intel.com>
> Cc: tony.luck@intel.com, linux-acpi@vger.kernel.org
> Subject: Re: [PATCH 2/2] ACPI/APEI: Update einj documentation for
>  param1/param2
> User-Agent: Mutt/1.5.21 (2010-09-15)
> 
> On Wed, May 15, 2013 at 10:29:07PM -0400, Chen Gong wrote:
> > To ensure EINJ working well when injecting errors via EINJ
> > table, add some attentions for param1/param2.
> > 
> > Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
> > ---
> >  Documentation/acpi/apei/einj.txt |    8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/acpi/apei/einj.txt b/Documentation/acpi/apei/einj.txt
> > index e20b6da..80c4ab2 100644
> > --- a/Documentation/acpi/apei/einj.txt
> > +++ b/Documentation/acpi/apei/einj.txt
> > @@ -47,11 +47,15 @@ directory apei/einj. The following files are provided.
> >  
> >  - param1
> >    This file is used to set the first error parameter value. Effect of
> > -  parameter depends on error_type specified.
> > +  parameter depends on error_type specified. For exmaple, if error
> > +  type is memory relatd type, the param1 should be a valid physical
> > +  memory address.
> >  
> >  - param2
> >    This file is used to set the second error parameter value. Effect of
> > -  parameter depends on error_type specified.
> > +  parameter depends on error_type specified. For example, if error
> > +  type is memory relatd type, the param2 should be a valid physical
> > +  memory address mask, say, 0xfffffffffffff000.
> >  
> >  - notrigger
> >    The EINJ mechanism is a two step process. First inject the error, then
> 
> Please run those through the spell checker.
> 
OK, I will(exmaple & relatd).

> Thanks.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> Sent from a fat crate under my desk. Formatting is fine.
> --
diff mbox

Patch

diff --git a/Documentation/acpi/apei/einj.txt b/Documentation/acpi/apei/einj.txt
index e20b6da..80c4ab2 100644
--- a/Documentation/acpi/apei/einj.txt
+++ b/Documentation/acpi/apei/einj.txt
@@ -47,11 +47,15 @@  directory apei/einj. The following files are provided.
 
 - param1
   This file is used to set the first error parameter value. Effect of
-  parameter depends on error_type specified.
+  parameter depends on error_type specified. For exmaple, if error
+  type is memory relatd type, the param1 should be a valid physical
+  memory address.
 
 - param2
   This file is used to set the second error parameter value. Effect of
-  parameter depends on error_type specified.
+  parameter depends on error_type specified. For example, if error
+  type is memory relatd type, the param2 should be a valid physical
+  memory address mask, say, 0xfffffffffffff000.
 
 - notrigger
   The EINJ mechanism is a two step process. First inject the error, then