diff mbox

ACPI video: ignore BIOS initial backlight value for HP m4

Message ID 1369706709-9189-1-git-send-email-alex.hung@canonical.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Alex Hung May 28, 2013, 2:05 a.m. UTC
On HP m4 lapops, BIOS reports minimum backlight on boot and
causes backlight to dim completely. This ignores the initial backlight
values and set to max brightness.

Buglink: https://bugs.launchpad.net/bugs/1184501

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 drivers/acpi/video.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Aaron Lu Nov. 12, 2013, 2:05 a.m. UTC | #1
On 05/28/2013 10:05 AM, Alex Hung wrote:
> On HP m4 lapops, BIOS reports minimum backlight on boot and
> causes backlight to dim completely. This ignores the initial backlight
> values and set to max brightness.
> 
> Buglink: https://bugs.launchpad.net/bugs/1184501

Same here, but since there is no acpidump attached, I'm not that sure.

Thanks,
Aaron

> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  drivers/acpi/video.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 5b32e15..d0937ab 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -464,6 +464,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "HP 1000 Notebook PC"),
>  		},
>  	},
> +	{
> +	 .callback = video_ignore_initial_backlight,
> +	 .ident = "HP Pavilion m4",
> +	 .matches = {
> +		DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion m4 Notebook PC"),
> +		},
> +	},
>  	{}
>  };
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Aaron Lu Nov. 12, 2013, 2:21 a.m. UTC | #2
On 11/12/2013 10:05 AM, Aaron Lu wrote:
> On 05/28/2013 10:05 AM, Alex Hung wrote:
>> On HP m4 lapops, BIOS reports minimum backlight on boot and
>> causes backlight to dim completely. This ignores the initial backlight
>> values and set to max brightness.
>>
>> Buglink: https://bugs.launchpad.net/bugs/1184501
> 
> Same here, but since there is no acpidump attached, I'm not that sure.

Oh, I missed the attached acpi.log which is the dump.
So yes, it is the same problem. I think it should be safe to revert
these two patches, but for certain, I'll ask in launchpad the original
reporter to give it a test.

Thanks,
Aaron
 
>>
>> Signed-off-by: Alex Hung <alex.hung@canonical.com>
>> ---
>>  drivers/acpi/video.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
>> index 5b32e15..d0937ab 100644
>> --- a/drivers/acpi/video.c
>> +++ b/drivers/acpi/video.c
>> @@ -464,6 +464,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
>>  		DMI_MATCH(DMI_PRODUCT_NAME, "HP 1000 Notebook PC"),
>>  		},
>>  	},
>> +	{
>> +	 .callback = video_ignore_initial_backlight,
>> +	 .ident = "HP Pavilion m4",
>> +	 .matches = {
>> +		DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
>> +		DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion m4 Notebook PC"),
>> +		},
>> +	},
>>  	{}
>>  };
>>  
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 5b32e15..d0937ab 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -464,6 +464,14 @@  static struct dmi_system_id video_dmi_table[] __initdata = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "HP 1000 Notebook PC"),
 		},
 	},
+	{
+	 .callback = video_ignore_initial_backlight,
+	 .ident = "HP Pavilion m4",
+	 .matches = {
+		DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion m4 Notebook PC"),
+		},
+	},
 	{}
 };