From patchwork Thu Jul 18 05:40:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Gnatenko X-Patchwork-Id: 2829397 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 774B49F9EB for ; Thu, 18 Jul 2013 05:40:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5D2A82012D for ; Thu, 18 Jul 2013 05:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC4DC201E4 for ; Thu, 18 Jul 2013 05:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756735Ab3GRFkV (ORCPT ); Thu, 18 Jul 2013 01:40:21 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:52519 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629Ab3GRFkU (ORCPT ); Thu, 18 Jul 2013 01:40:20 -0400 Received: by mail-la0-f47.google.com with SMTP id fe20so2098975lab.6 for ; Wed, 17 Jul 2013 22:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:x-mailer:mime-version:content-transfer-encoding; bh=WI9piB6vt93OWBdAPMap39WEnhXa7BB3aAYbmg22DGw=; b=X0B0au2iMk7wv1dv0SxafdHeC//7mKEuMqVCLAbKiEqeeYEv59YkezdEWSNgh0aPEe sIdJI45XRetRzlBaRbRAA39+fHSxxieWSAtoi1nMJ8wntRLcE7EV/khFP+aIeTsYFd9b 3xK75OsULW1YXBCfNglq7nDGqyM4HHxpQ7xgExMoavr/1zUW9V53/mJdXttO6o0iiUdG v/GExzmQiCUSeERLDn3tJ/1l46OBRtbKApjLeUnp4mUqC86cFemAEiMD5gVIM6m8vF80 +OxInwp3Tpw2syEzcp0fZ7TyonKyFgpAdhtmSjQwKO9sC9hRRFK3og9dsMQXnEzceGjW Of6g== X-Received: by 10.112.20.66 with SMTP id l2mr4621316lbe.48.1374126019103; Wed, 17 Jul 2013 22:40:19 -0700 (PDT) Received: from [192.168.254.26] ([176.192.161.180]) by mx.google.com with ESMTPSA id m1sm3494817lag.3.2013.07.17.22.40.15 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 17 Jul 2013 22:40:18 -0700 (PDT) Message-ID: <1374126011.6123.2.camel@ThinkPad-X230.localdomain> Subject: Re: [PATCH 2/3] ACPI / video: Always call acpi_video_init_brightness() on init From: Igor Gnatenko To: "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, Matthew Garrett , seth.forshee@canonical.com, joeyli.kernel@gmail.com, daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, lenb@kernel.org, Aaron Lu , Yves-Alexis Perez , Felipe Contreras , "Lee, Chun-Yi" , Henrique de Moraes Holschuh Date: Thu, 18 Jul 2013 09:40:11 +0400 In-Reply-To: <2754766.4uAbGBBbb8@vostro.rjw.lan> References: <1370818899-8595-1-git-send-email-matthew.garrett@nebula.com> <1448863.3slS729B6b@vostro.rjw.lan> <2754766.4uAbGBBbb8@vostro.rjw.lan> X-Mailer: Evolution 3.8.3 (3.8.3-2.fc19) Mime-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Matthew Garrett We have to call acpi_video_init_brightness() even if we're not going to initialise the backlight - Thinkpads seem to use this as the trigger for enabling ACPI notifications rather than handling it in firmware. [rjw: Drop the brightness object created by acpi_video_init_brightness() if we are not going to use it.] Signed-off-by: Matthew Garrett Signed-off-by: Rafael J. Wysocki Tested-by: Igor Gnatenko --- drivers/acpi/video.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) Index: linux-pm/drivers/acpi/video.c =================================================================== --- linux-pm.orig/drivers/acpi/video.c +++ linux-pm/drivers/acpi/video.c @@ -884,6 +884,9 @@ static void acpi_video_device_find_cap(s if (acpi_has_method(device->dev->handle, "_DDC")) device->cap._DDC = 1; + if (acpi_video_init_brightness(device)) + return; + if (acpi_video_backlight_support()) { struct backlight_properties props; struct pci_dev *pdev; @@ -893,9 +896,6 @@ static void acpi_video_device_find_cap(s static int count = 0; char *name; - result = acpi_video_init_brightness(device); - if (result) - return; name = kasprintf(GFP_KERNEL, "acpi_video%d", count); if (!name) return; @@ -955,6 +955,11 @@ static void acpi_video_device_find_cap(s if (result) printk(KERN_ERR PREFIX "Create sysfs link\n"); + } else { + /* Remove the brightness object. */ + kfree(device->brightness->levels); + kfree(device->brightness); + device->brightness = NULL; } }