From patchwork Sat Aug 31 10:16:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 2852346 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BCCCA9F313 for ; Sat, 31 Aug 2013 10:20:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DDA43202CC for ; Sat, 31 Aug 2013 10:20:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A818202C8 for ; Sat, 31 Aug 2013 10:20:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756990Ab3HaKUs (ORCPT ); Sat, 31 Aug 2013 06:20:48 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:35480 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756960Ab3HaKUr (ORCPT ); Sat, 31 Aug 2013 06:20:47 -0400 Received: by mail-pd0-f173.google.com with SMTP id p10so2837196pdj.4 for ; Sat, 31 Aug 2013 03:20:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Ie5L2iSHgZ8EYyJ6wAPipOGfAvNn8GWHLSOGGa8NY4A=; b=eufpRBUX0Umv5axrSZSITlC4VZe7v+yTXpcdAl70743FR9sidYI7isHkM34WLVJ6m5 srLQrPgIwWgvA5RAKrpVuK/gbNkKW8v39ox2eZC7SBgZKy+zANtVy5GTvYzMxNn0gDMf 0IsHQlGfjE0tQsEmfRd3pUlKAz6UWM3th7j/o1RnVULorEaICNjGEx+VDnTkAoF+j/0B 2pNJitKHxkmNnPzWrL77Crda25KCIgqGQB6x3HYEVwcROU15uMkn6qA11tR8ZJbMq6tW FIyY7nfYZztHbA3zt2XI0IJtweEqWKNeQonzTcffCVr36z+67VyKms9LPRxQsDyE0HWH Wj5g== X-Gm-Message-State: ALoCoQm8lEvkv0FcuIKcuSJjK1OGOi5Pew7BG0vmgWZixzvyU2lFj85lCsX5zQZ2YNEzwWVnjLlq X-Received: by 10.66.121.234 with SMTP id ln10mr15349871pab.20.1377944446722; Sat, 31 Aug 2013 03:20:46 -0700 (PDT) Received: from localhost ([218.17.215.175]) by mx.google.com with ESMTPSA id 7sm3693960paf.22.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 31 Aug 2013 03:20:46 -0700 (PDT) From: Hanjun Guo To: "Rafael J. Wysocki" Cc: Thomas Gleixner , Tony Luck , Ingo Molnar , linux-acpi@vger.kernel.org, x86@kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, linaro-acpi@lists.linaro.org, Hanjun Guo Subject: [PATCH 5/6] ACPI / processor: remove unnecessary if (!pr) check Date: Sat, 31 Aug 2013 18:16:00 +0800 Message-Id: <1377944162-18574-5-git-send-email-hanjun.guo@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1377944162-18574-1-git-send-email-hanjun.guo@linaro.org> References: <1377944162-18574-1-git-send-email-hanjun.guo@linaro.org> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP acpi_processor_errata() is only called in acpi_processor_get_info(), and the argument 'pr' passed to acpi_processor_errata() will be never NULL, so the if (!pr) check is unnecessary. Since the 'pr' argument is not used by acpi_processor_errata() any more, so change the argument into void. Signed-off-by: Hanjun Guo --- drivers/acpi/acpi_processor.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index a2a71d0..d1cabe5 100644 --- a/drivers/acpi/acpi_processor.c +++ b/drivers/acpi/acpi_processor.c @@ -140,15 +140,11 @@ static int acpi_processor_errata_piix4(struct pci_dev *dev) return 0; } -static int acpi_processor_errata(struct acpi_processor *pr) +static int acpi_processor_errata(void) { int result = 0; struct pci_dev *dev = NULL; - - if (!pr) - return -EINVAL; - /* * PIIX4 */ @@ -220,7 +216,7 @@ static int acpi_processor_get_info(struct acpi_device *device) acpi_status status = AE_OK; static int cpu0_initialized; - acpi_processor_errata(pr); + acpi_processor_errata(); /* * Check to see if we have bus mastering arbitration control. This