| Message ID | 1384870535-20532-1-git-send-email-mika.westerberg@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Tue, Nov 19, 2013 at 7:15 AM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > Commit bd950799d951 (PCI: acpiphp: Convert to dynamic debug) removed users > of acpiphp_debug variable and the variable itself but the declaration was > left in the header file. Drop this unused declaration. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Rafael, if it makes sense for you to apply this, you can add my: Acked-by: Bjorn Helgaas <bhelgaas@google.com> Otherwise I can pick it up. > --- > drivers/pci/hotplug/acpiphp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h > index 26100f510b10..1592dbe4f904 100644 > --- a/drivers/pci/hotplug/acpiphp.h > +++ b/drivers/pci/hotplug/acpiphp.h > @@ -176,7 +176,6 @@ u8 acpiphp_get_latch_status(struct acpiphp_slot *slot); > u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot); > > /* variables */ > -extern bool acpiphp_debug; > extern bool acpiphp_disabled; > > #endif /* _ACPIPHP_H */ > -- > 1.8.4.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, November 19, 2013 10:23:57 AM Bjorn Helgaas wrote: > On Tue, Nov 19, 2013 at 7:15 AM, Mika Westerberg > <mika.westerberg@linux.intel.com> wrote: > > Commit bd950799d951 (PCI: acpiphp: Convert to dynamic debug) removed users > > of acpiphp_debug variable and the variable itself but the declaration was > > left in the header file. Drop this unused declaration. > > > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > Rafael, if it makes sense for you to apply this, you can add my: > > Acked-by: Bjorn Helgaas <bhelgaas@google.com> > > Otherwise I can pick it up. Applied, thanks! I'm going to send my next pull request tomorrow. > > --- > > drivers/pci/hotplug/acpiphp.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h > > index 26100f510b10..1592dbe4f904 100644 > > --- a/drivers/pci/hotplug/acpiphp.h > > +++ b/drivers/pci/hotplug/acpiphp.h > > @@ -176,7 +176,6 @@ u8 acpiphp_get_latch_status(struct acpiphp_slot *slot); > > u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot); > > > > /* variables */ > > -extern bool acpiphp_debug; > > extern bool acpiphp_disabled; > > > > #endif /* _ACPIPHP_H */ > > -- > > 1.8.4.3 > >
diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h index 26100f510b10..1592dbe4f904 100644 --- a/drivers/pci/hotplug/acpiphp.h +++ b/drivers/pci/hotplug/acpiphp.h @@ -176,7 +176,6 @@ u8 acpiphp_get_latch_status(struct acpiphp_slot *slot); u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot); /* variables */ -extern bool acpiphp_debug; extern bool acpiphp_disabled; #endif /* _ACPIPHP_H */
Commit bd950799d951 (PCI: acpiphp: Convert to dynamic debug) removed users of acpiphp_debug variable and the variable itself but the declaration was left in the header file. Drop this unused declaration. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/pci/hotplug/acpiphp.h | 1 - 1 file changed, 1 deletion(-)