| Message ID | 1386669627-31365-1-git-send-email-mika.westerberg@linux.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 12/10/2013 07:00 PM, Mika Westerberg wrote: > Doing this allows drivers to distinguish between a real error case (if > there was an error when we tried to resolve the GPIO) and when the optional > GPIO line was not available. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Thanks! Acked-by: Alexandre Courbot <acourbot@nvidia.com> -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, December 10, 2013 12:00:27 PM Mika Westerberg wrote: > Doing this allows drivers to distinguish between a real error case (if > there was an error when we tried to resolve the GPIO) and when the optional > GPIO line was not available. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > drivers/gpio/gpiolib-acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > index 8506e4ce41f7..716ee9843110 100644 > --- a/drivers/gpio/gpiolib-acpi.c > +++ b/drivers/gpio/gpiolib-acpi.c > @@ -307,7 +307,7 @@ struct gpio_desc *acpi_get_gpiod_by_index(struct device *dev, int index, > if (lookup.desc && info) > *info = lookup.info; > > - return lookup.desc ? lookup.desc : ERR_PTR(-ENODEV); > + return lookup.desc ? lookup.desc : ERR_PTR(-ENOENT); > } > > void acpi_gpiochip_add(struct gpio_chip *chip) >
On Tue, Dec 10, 2013 at 11:00 AM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > Doing this allows drivers to distinguish between a real error case (if > there was an error when we tried to resolve the GPIO) and when the optional > GPIO line was not available. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Patch applied with Alex's and Rafael's ACKs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index 8506e4ce41f7..716ee9843110 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -307,7 +307,7 @@ struct gpio_desc *acpi_get_gpiod_by_index(struct device *dev, int index, if (lookup.desc && info) *info = lookup.info; - return lookup.desc ? lookup.desc : ERR_PTR(-ENODEV); + return lookup.desc ? lookup.desc : ERR_PTR(-ENOENT); } void acpi_gpiochip_add(struct gpio_chip *chip)
Doing this allows drivers to distinguish between a real error case (if there was an error when we tried to resolve the GPIO) and when the optional GPIO line was not available. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/gpio/gpiolib-acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)