From patchwork Fri Feb 14 12:34:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mika Westerberg X-Patchwork-Id: 3652391 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 14B3F9F382 for ; Fri, 14 Feb 2014 12:34:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DC54320221 for ; Fri, 14 Feb 2014 12:34:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A77B72021E for ; Fri, 14 Feb 2014 12:34:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbaBNMeY (ORCPT ); Fri, 14 Feb 2014 07:34:24 -0500 Received: from mga09.intel.com ([134.134.136.24]:20854 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751926AbaBNMeX (ORCPT ); Fri, 14 Feb 2014 07:34:23 -0500 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 14 Feb 2014 04:29:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,844,1384329600"; d="scan'208";a="455473323" Received: from blue.fi.intel.com ([10.237.72.156]) by orsmga001.jf.intel.com with ESMTP; 14 Feb 2014 04:34:08 -0800 Received: by blue.fi.intel.com (Postfix, from userid 1004) id 4DE71E0090; Fri, 14 Feb 2014 14:34:07 +0200 (EET) From: Mika Westerberg To: linux-acpi@vger.kernel.org Cc: "Rafael J. Wysocki" , Len Brown , Aaron Lu , linux-kernel@vger.kernel.org, Mika Westerberg Subject: [PATCH] Revert "ACPI / video: Add HP EliteBook Revolve 810 to the blacklist" Date: Fri, 14 Feb 2014 14:34:07 +0200 Message-Id: <1392381247-28109-1-git-send-email-mika.westerberg@linux.intel.com> X-Mailer: git-send-email 1.8.5.2 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit e18ac62fa4b3f16234bab0d5a6627c57dbae9e7e. The referenced commit added HP EliteBook Revolve 810 to the ACPI video detected blacklist so that only the native Intel backlight interface was exported. However, this turned to be wrong solution after all. The ACPI video interface works and as long as we only use that there are no problems. So we can revert this commit and stick to use the backlight interface provided by the ACPI video driver. (Using Intel native interface will not work after resume since the ACPI video driver will restore it's state which takes control over the native one. That's a separate thing and should be addressed in the ACPI video driver, I suppose.) References: https://bugzilla.kernel.org/show_bug.cgi?id=70231 Cc: Aaron Lu Signed-off-by: Mika Westerberg --- Rafael, This turned out to be misunderstanding from my side. I should have investigated this further before submitting the original patch. Sorry about that. Aaron, Thanks for the investigation and pointing me to the right direction (e.g to use acpi_video0 over the native one). drivers/acpi/video_detect.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index a697b77b8865..f0447d3daf2c 100644 --- a/drivers/acpi/video_detect.c +++ b/drivers/acpi/video_detect.c @@ -170,14 +170,6 @@ static struct dmi_system_id video_detect_dmi_table[] = { }, { .callback = video_detect_force_vendor, - .ident = "HP EliteBook Revolve 810", - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), - DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook Revolve 810 G1"), - }, - }, - { - .callback = video_detect_force_vendor, .ident = "Lenovo Yoga 13", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),