| Message ID | 1392570485.28866.10.camel@x220 (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Sun, 2014-02-16 at 21:45 +0100, Rafael J. Wysocki wrote:
> Some defconfigs set it. Care to remove it from them too?
As in: send a v2 which also strips it from those defconfigs? Fine with
me.
(Side note: I've learned to ignore the defconfigs. They have accumulated
a lot of cruft. I once sent a pull request to clean all defconfigs. It
was ignored and I was rather fed up with doing trying to clean up
defconfigs, so I never sent out an updated pull request.)
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sunday, February 16, 2014 06:08:05 PM Paul Bolle wrote: > Nothing cares about ACPI_PROCFS. Some defconfigs set it. Care to remove it from them too? > This has been the case since v2.6.38. > This Kconfig symbol serves no purpose and its help text is now > misleading. It can safely be removed. If this symbol would be needed > again in the future it can be readded in a commit that adds code that > actually uses it. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Tested with "git grep" only. > > Michael Opdenacker did a previous attempt in > https://lkml.org/lkml/2013/10/27/15 . That patch that needed some > context changes, so I redid it. I also wrote a new commit explanation. > It also addresses the reasons not to accept Michael's patch. > > drivers/acpi/Kconfig | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 4770de5..436111b 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -43,19 +43,6 @@ config ACPI_SLEEP > depends on SUSPEND || HIBERNATION > default y > > -config ACPI_PROCFS > - bool "Deprecated /proc/acpi files" > - depends on PROC_FS > - help > - For backwards compatibility, this option allows > - deprecated /proc/acpi/ files to exist, even when > - they have been replaced by functions in /sys. > - > - This option has no effect on /proc/acpi/ files > - and functions which do not yet exist in /sys. > - > - Say N to delete /proc/acpi/ files that have moved to /sys/ > - > config ACPI_EC_DEBUGFS > tristate "EC read/write access through /sys/kernel/debug/ec" > default n >
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 4770de5..436111b 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -43,19 +43,6 @@ config ACPI_SLEEP depends on SUSPEND || HIBERNATION default y -config ACPI_PROCFS - bool "Deprecated /proc/acpi files" - depends on PROC_FS - help - For backwards compatibility, this option allows - deprecated /proc/acpi/ files to exist, even when - they have been replaced by functions in /sys. - - This option has no effect on /proc/acpi/ files - and functions which do not yet exist in /sys. - - Say N to delete /proc/acpi/ files that have moved to /sys/ - config ACPI_EC_DEBUGFS tristate "EC read/write access through /sys/kernel/debug/ec" default n
Nothing cares about ACPI_PROCFS. This has been the case since v2.6.38. This Kconfig symbol serves no purpose and its help text is now misleading. It can safely be removed. If this symbol would be needed again in the future it can be readded in a commit that adds code that actually uses it. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Tested with "git grep" only. Michael Opdenacker did a previous attempt in https://lkml.org/lkml/2013/10/27/15 . That patch that needed some context changes, so I redid it. I also wrote a new commit explanation. It also addresses the reasons not to accept Michael's patch. drivers/acpi/Kconfig | 13 ------------- 1 file changed, 13 deletions(-)