From patchwork Mon Feb 24 02:23:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 3705601 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 984CD9F35F for ; Mon, 24 Feb 2014 02:24:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 11BE3201DD for ; Mon, 24 Feb 2014 02:24:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2633E20176 for ; Mon, 24 Feb 2014 02:24:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbaBXCYI (ORCPT ); Sun, 23 Feb 2014 21:24:08 -0500 Received: from mail-ob0-f173.google.com ([209.85.214.173]:53911 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbaBXCYH (ORCPT ); Sun, 23 Feb 2014 21:24:07 -0500 Received: by mail-ob0-f173.google.com with SMTP id uz6so6715623obc.18 for ; Sun, 23 Feb 2014 18:24:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=wdEMVeaDaXr5mprtmRikkhrDEW29Kq5NMrJenSvBdkY=; b=YFUuOdL/B82ceQ4eWb5we4GFMQwGe+HT9H6FK/zl7JSxfqDL6td2C4w6ExIl/JukHK OGESKxROSy33PKA8Ya2ueJteptOyxIsGoPI56kSf6mAMA1gwJOBgG+hYvVIq5zsNzR+e s6aYbJ0aQegyGbcg58jYyawDJneUdzh3N79t4xHkt1mVFgqO/MIDl0z/MQ0WOu6Slwue JEsJQ7O0x5aJgWkt5KWnpWoV+phybwMvN0X84J1MNYH8IA3WFSqDI1qibBMh5n3KWflh oXOzsjut0alMCNp9Sa2CLGK/iu5gpA8axkE2j9xE7AlBnpCnT9s1uOdgULaO7qaV+bTZ D61A== X-Received: by 10.60.132.42 with SMTP id or10mr4286301oeb.83.1393208646860; Sun, 23 Feb 2014 18:24:06 -0800 (PST) Received: from t430.minyard.home (pool-173-57-152-84.dllstx.fios.verizon.net. [173.57.152.84]) by mx.google.com with ESMTPSA id qe2sm30768789obc.1.2014.02.23.18.24.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Feb 2014 18:24:06 -0800 (PST) Received: from t430.minyard.home (t430.minyard.home [127.0.0.1]) by t430.minyard.home (8.14.7/8.14.7) with ESMTP id s1O2Ns0J017037; Sun, 23 Feb 2014 20:24:04 -0600 Received: (from cminyard@localhost) by t430.minyard.home (8.14.7/8.14.7/Submit) id s1O2Ni8J017026; Sun, 23 Feb 2014 20:23:44 -0600 From: minyard@acm.org To: OpenIPMI Developers Cc: Linux Kernel , Russ Anderson , Matthew Garrett , lenb@kernel.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org, Corey Minyard Subject: [PATCH 1/3] ipmi: Turn off default probing of interfaces Date: Sun, 23 Feb 2014 20:23:34 -0600 Message-Id: <1393208616-16500-2-git-send-email-minyard@acm.org> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1393208616-16500-1-git-send-email-minyard@acm.org> References: <1393208616-16500-1-git-send-email-minyard@acm.org> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Corey Minyard The default probing can cause problems with some system, slow booting, extra CPU usages, etc. Turn it off by default and give a config option to enable it. From: Matthew Garrett Signed-off-by: Corey Minyard --- drivers/char/ipmi/Kconfig | 10 ++++++++++ drivers/char/ipmi/ipmi_si_intf.c | 4 ++++ 2 files changed, 14 insertions(+) diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig index 0baa8fa..8e14360 100644 --- a/drivers/char/ipmi/Kconfig +++ b/drivers/char/ipmi/Kconfig @@ -50,6 +50,16 @@ config IPMI_SI Currently, only KCS and SMIC are supported. If you are using IPMI, you should probably say "y" here. +config IPMI_SI_PROBE_DEFAULTS + bool 'Probe for all possible IPMI system interfaces by default' + help + Modern systems will usually expose IPMI interfaces via a discoverable + firmware mechanism such as ACPI or DMI. Older systems do not, and so + the driver is forced to probe hardware manually. This may cause boot + delays. Say "n" here to disable this manual probing. IPMI will then + only be available on older systems if the "ipmi_si_intf.trydefaults=1" + boot argument is passed. + config IPMI_WATCHDOG tristate 'IPMI Watchdog Timer' help diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 03f4189..7b420e1 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -1230,7 +1230,11 @@ static bool si_tryplatform = 1; #ifdef CONFIG_PCI static bool si_trypci = 1; #endif +#ifdef CONFIG_IPMI_SI_PROBE_DEFAULTS static bool si_trydefaults = 1; +#else +static bool si_trydefaults; +#endif static char *si_type[SI_MAX_PARMS]; #define MAX_SI_TYPE_STR 30 static char si_type_str[MAX_SI_TYPE_STR];