From patchwork Sun Mar 16 17:03:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Rui X-Patchwork-Id: 3839561 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 00955BF540 for ; Sun, 16 Mar 2014 17:04:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1ECE020200 for ; Sun, 16 Mar 2014 17:04:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C53220145 for ; Sun, 16 Mar 2014 17:04:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932135AbaCPREg (ORCPT ); Sun, 16 Mar 2014 13:04:36 -0400 Received: from mga09.intel.com ([134.134.136.24]:54181 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755275AbaCPREP (ORCPT ); Sun, 16 Mar 2014 13:04:15 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 16 Mar 2014 09:59:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,665,1389772800"; d="scan'208";a="501094272" Received: from unknown (HELO rzhang1-mobl4.ccr.corp.intel.com) ([10.255.21.226]) by orsmga002.jf.intel.com with ESMTP; 16 Mar 2014 10:03:54 -0700 From: Zhang Rui To: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bhelgaas@google.com, matthew.garrett@nebula.com, rafael.j.wysocki@intel.com, dmitry.torokhov@gmail.com, Zhang Rui Subject: [PATCH V3 11/11] ACPI: introduce dummy memory hotplug scan handler Date: Mon, 17 Mar 2014 01:03:17 +0800 Message-Id: <1394989397-2733-12-git-send-email-rui.zhang@intel.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1394989397-2733-1-git-send-email-rui.zhang@intel.com> References: <1394989397-2733-1-git-send-email-rui.zhang@intel.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If CONFIG_ACPI_HOTPLUG_MEMORY is cleared, platform devices would be created for ACPI hotplug memory device objects. Introduce a dummy memory hotplug scan handler in this patch, to prevent those platform devices from being created. Signed-off-by: Zhang Rui --- drivers/acpi/Makefile | 2 +- drivers/acpi/acpi_memhotplug.c | 45 ++++++++++++++++++++++++++++------------ drivers/acpi/internal.h | 6 +----- 3 files changed, 34 insertions(+), 19 deletions(-) diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile index 871d70d..605eff7 100644 --- a/drivers/acpi/Makefile +++ b/drivers/acpi/Makefile @@ -65,7 +65,7 @@ obj-$(CONFIG_ACPI_PCI_SLOT) += pci_slot.o obj-$(CONFIG_ACPI_PROCESSOR) += processor.o obj-y += container.o obj-$(CONFIG_ACPI_THERMAL) += thermal.o -obj-$(CONFIG_ACPI_HOTPLUG_MEMORY) += acpi_memhotplug.o +obj-y += acpi_memhotplug.o obj-$(CONFIG_ACPI_BATTERY) += battery.o obj-$(CONFIG_ACPI_SBS) += sbshc.o obj-$(CONFIG_ACPI_SBS) += sbs.o diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c index b67be85..427e32b 100644 --- a/drivers/acpi/acpi_memhotplug.c +++ b/drivers/acpi/acpi_memhotplug.c @@ -44,6 +44,13 @@ ACPI_MODULE_NAME("acpi_memhotplug"); +static const struct acpi_device_id memory_device_ids[] = { + {ACPI_MEMORY_DEVICE_HID, 0}, + {"", 0}, +}; + +#ifdef CONFIG_ACPI_HOTPLUG_MEMORY + /* Memory Device States */ #define MEMORY_INVALID_STATE 0 #define MEMORY_POWER_ON_STATE 1 @@ -53,11 +60,6 @@ static int acpi_memory_device_add(struct acpi_device *device, const struct acpi_device_id *not_used); static void acpi_memory_device_remove(struct acpi_device *device); -static const struct acpi_device_id memory_device_ids[] = { - {ACPI_MEMORY_DEVICE_HID, 0}, - {"", 0}, -}; - static struct acpi_scan_handler memory_device_handler = { .ids = memory_device_ids, .attach = acpi_memory_device_add, @@ -362,17 +364,34 @@ static void acpi_memory_device_remove(struct acpi_device *device) static bool __initdata acpi_no_memhotplug; -void __init acpi_memory_hotplug_init(void) -{ - if (acpi_no_memhotplug) - return; - - acpi_scan_add_handler_with_hotplug(&memory_device_handler, "memory"); -} - static int __init disable_acpi_memory_hotplug(char *str) { acpi_no_memhotplug = true; return 1; } __setup("acpi_no_memhotplug", disable_acpi_memory_hotplug); + +#endif + +static int acpi_memory_dummy_add(struct acpi_device *device, + const struct acpi_device_id *not_used) +{ + return 1; +} + +static struct acpi_scan_handler memory_dummy_handler = { + .ids = memory_device_ids, + .attach = acpi_memory_dummy_add, +}; + +void __init acpi_memory_hotplug_init(void) +{ +#ifdef CONFIG_ACPI_HOTPLUG_MEMORY + if (!acpi_no_memhotplug) { + acpi_scan_add_handler_with_hotplug(&memory_device_handler, + "memory"); + return ; + } +#endif + acpi_scan_add_handler(&memory_dummy_handler); +} diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h index 253758a..4e96e84 100644 --- a/drivers/acpi/internal.h +++ b/drivers/acpi/internal.h @@ -33,16 +33,12 @@ void acpi_platform_init(void); void acpi_pnp_init(void); int acpi_sysfs_init(void); void acpi_container_init(void); +void acpi_memory_hotplug_init(void); #ifdef CONFIG_ACPI_DOCK void acpi_dock_init(void); #else static inline void acpi_dock_init(void) {} #endif -#ifdef CONFIG_ACPI_HOTPLUG_MEMORY -void acpi_memory_hotplug_init(void); -#else -static inline void acpi_memory_hotplug_init(void) {} -#endif #ifdef CONFIG_X86 void acpi_cmos_rtc_init(void); #else