From patchwork Thu Sep 4 07:13:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chun-Yi Lee X-Patchwork-Id: 4843021 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 466829F390 for ; Thu, 4 Sep 2014 07:14:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6233520265 for ; Thu, 4 Sep 2014 07:14:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D38D20254 for ; Thu, 4 Sep 2014 07:13:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754710AbaIDHN6 (ORCPT ); Thu, 4 Sep 2014 03:13:58 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:63381 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbaIDHN5 (ORCPT ); Thu, 4 Sep 2014 03:13:57 -0400 Received: by mail-pd0-f173.google.com with SMTP id p10so12813450pdj.4 for ; Thu, 04 Sep 2014 00:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=ErWYJYVZVoQQDbrp4jsBDjI5tO2YozAjPVll/hvFz1U=; b=Oule12vw5q686CHvei8mvqHKsLUOoLjWS9laEw0C4QpVTahP9Kyl2Ejjxv/Z6HgWJl eXsqO72lSLoelmuMJFcLRRKnEnSdWntfO0arOGp9uf1XDe3DdZsMZZCW6RGVIJyxlH0/ XlB9MOxUdK875bk0GQz7kn1NIjqMBgVAEIwrYX0PMnu1rO/6Skkh6qRPGyzCnILiRfkj tWpsTkDC+uTnF1E06PGDNzzcWQtC15aD7SDbH19TfxqNwEtJml2+vZIIq0GzG5uLl/RM 92ShYWqbr817Ee7+MWtrTlAVzQz//69999VtVEgV53vcpe0JhyWRDt59La41tQghHgWe 7JMQ== X-Received: by 10.70.90.198 with SMTP id by6mr5442122pdb.164.1409814833716; Thu, 04 Sep 2014 00:13:53 -0700 (PDT) Received: from linux-rxt1.site ([130.57.30.250]) by mx.google.com with ESMTPSA id gk11sm808149pbd.41.2014.09.04.00.13.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Sep 2014 00:13:52 -0700 (PDT) From: "Lee, Chun-Yi" X-Google-Original-From: "Lee, Chun-Yi" To: "Rafael J. Wysocki" , Len Brown Cc: linux-acpi@vger.kernel.org, Lan Tianyu , "Lee, Chun-Yi" , "Rafael J. Wysocki" Subject: [PATCH] ACPI: Fix CMOS RTC Operation Region handler accesses to wrong address of value Date: Thu, 4 Sep 2014 15:13:39 +0800 Message-Id: <1409814819-30594-1-git-send-email-jlee@suse.com> X-Mailer: git-send-email 1.8.4.5 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The value64 parameter is an u64 point that used to transfer the value for write to CMOS, or used to return the value that's read from CMOS. The value64 is an u64 point, so don't need get address again. It causes acpi_cmos_rtc_space_handler always return 0 to reader and didn't write expected value to CMOS. Cc: Lan Tianyu Cc: Len Brown Cc: Rafael J. Wysocki Signed-off-by: Lee, Chun-Yi --- drivers/acpi/acpi_cmos_rtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_cmos_rtc.c b/drivers/acpi/acpi_cmos_rtc.c index 2da8660..81dc750 100644 --- a/drivers/acpi/acpi_cmos_rtc.c +++ b/drivers/acpi/acpi_cmos_rtc.c @@ -33,7 +33,7 @@ acpi_cmos_rtc_space_handler(u32 function, acpi_physical_address address, void *handler_context, void *region_context) { int i; - u8 *value = (u8 *)&value64; + u8 *value = (u8 *)value64; if (address > 0xff || !value64) return AE_BAD_PARAMETER;