From patchwork Mon May 11 04:17:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 6372891 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B27E5BEEE1 for ; Mon, 11 May 2015 04:18:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E5D97201EF for ; Mon, 11 May 2015 04:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02B5420340 for ; Mon, 11 May 2015 04:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbbEKESL (ORCPT ); Mon, 11 May 2015 00:18:11 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:33333 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbbEKESK (ORCPT ); Mon, 11 May 2015 00:18:10 -0400 Received: by pdbnk13 with SMTP id nk13so136513698pdb.0 for ; Sun, 10 May 2015 21:18:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fw2CfkuPAdxd0hcmPuG9XkMqTg4H820Zwni25UDML+g=; b=OtqDoOXd+V8JfOPOPkoQSRb6bkhSShi74GiSoRkIslw6hTqo8rLZldp3xvj4F6vE45 UN0IWgsJGqRVOef/QK8y0U6591hjxg9YOZ2z6kAz/96+E7WtB92ksBlO1F1tZEB2b+5j bzUREGWmAp1d2HIAsEJ9xMUKy6UoMs/hPc1Dpl1QrIqL1IK10JnP+bYd9x9fmxG7aMJP gVW6Tw0mPAlbkF23WJ2EnWuZFv0kRw+ECphK6e6ROFWl/k+7dVZuhIJOmL4Hf9czP/Ck W/d7N0mkqC9vcYUQo2HE5mJ1WHMRNKhTynQv29lwqnHtZL9pPHggiPBPboG2fJbehrCQ xzEQ== X-Gm-Message-State: ALoCoQn/PtP182Rg3m6SO00/FNwPLULPfYXVj/GP53eEDYG6Iw9nni8KgjnjJykAL0elKfYh5Ube X-Received: by 10.68.115.42 with SMTP id jl10mr16279865pbb.39.1431317889542; Sun, 10 May 2015 21:18:09 -0700 (PDT) Received: from localhost ([180.150.153.56]) by mx.google.com with ESMTPSA id je2sm3033122pbd.14.2015.05.10.21.18.07 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 10 May 2015 21:18:08 -0700 (PDT) From: Hanjun Guo To: "Rafael J. Wysocki" , linux-acpi@vger.kernel.org Cc: Will Deacon , Catalin Marinas , Boris Ostrovsky , Stefano Stabellini , Lorenzo Pieralisi , Sudeep Holla , Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, Hanjun Guo Subject: [PATCH v3 2/7] Xen / ACPI / processor: use invalid_logical_cpuid() Date: Mon, 11 May 2015 12:17:14 +0800 Message-Id: <1431317839-4584-3-git-send-email-hanjun.guo@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1431317839-4584-1-git-send-email-hanjun.guo@linaro.org> References: <1431317839-4584-1-git-send-email-hanjun.guo@linaro.org> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use invalid_logical_cpuid(pr->id) instead of direct comparison. Signed-off-by: Hanjun Guo CC: Boris Ostrovsky CC: Stefano Stabellini Reviewed-by: Konrad Rzeszutek Wilk --- drivers/xen/xen-acpi-cpuhotplug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/xen-acpi-cpuhotplug.c b/drivers/xen/xen-acpi-cpuhotplug.c index 3e62ee4..5a62aa0 100644 --- a/drivers/xen/xen-acpi-cpuhotplug.c +++ b/drivers/xen/xen-acpi-cpuhotplug.c @@ -77,7 +77,7 @@ static int xen_acpi_processor_enable(struct acpi_device *device) pr->id = xen_pcpu_id(pr->acpi_id); - if ((int)pr->id < 0) + if (invalid_logical_cpuid(pr->id)) /* This cpu is not presented at hypervisor, try to hotadd it */ if (ACPI_FAILURE(xen_acpi_cpu_hotadd(pr))) { pr_err(PREFIX "Hotadd CPU (acpi_id = %d) failed.\n", @@ -226,7 +226,7 @@ static acpi_status xen_acpi_cpu_hotadd(struct acpi_processor *pr) return AE_ERROR; pr->id = xen_hotadd_cpu(pr); - if ((int)pr->id < 0) + if (invalid_logical_cpuid(pr->id)) return AE_ERROR; /*