From patchwork Mon May 11 04:17:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 6372911 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 74E78BEEE1 for ; Mon, 11 May 2015 04:18:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9A8BE203E3 for ; Mon, 11 May 2015 04:18:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7D58202F0 for ; Mon, 11 May 2015 04:18:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752261AbbEKESU (ORCPT ); Mon, 11 May 2015 00:18:20 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:35003 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752290AbbEKESP (ORCPT ); Mon, 11 May 2015 00:18:15 -0400 Received: by pdbqd1 with SMTP id qd1so136358050pdb.2 for ; Sun, 10 May 2015 21:18:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LEhhh5IFWiSf3ofiYqW6IktMlZ+W2mWy3NswDx557b8=; b=DLoOky55t0bQHDMucy3LxfS+ORwSGyngMCEZxGoJwwuO7YXYKlXkhteNv7GFT63qje cBwlnK1Tjr3yg7F6ckx1zn/lSIi58j0mijA2tdkQ9ZZgGtpeGX++pkoyLSWtlJhbtTGY EDRuGkyL7eA366twt/HzTdrh6U+UPGFwo2qE3txytFFKpSbKhLRyjLNkWqKQjGPaYfg1 AasRZV3FIQ+fmlA0u9OEZGI9VnWR/I3S/cMxMuFQ2n7UCg7Ux9Em37ztIFcSzewUv2hh 8Vgm4/sQNH0i9pWFO4ytDFdUPQE1aF1FFMQ0vo1eij8NuwrKUAaX4zWrODv4R6knqTWX Rd3A== X-Gm-Message-State: ALoCoQnjsyIDCnsBZU2ClDhTyjEweyRrXTi9LIUm/ToAy1hXWCf7fVdTv5hKSaYvbCf5emBtRM8N X-Received: by 10.68.161.99 with SMTP id xr3mr15872233pbb.47.1431317894438; Sun, 10 May 2015 21:18:14 -0700 (PDT) Received: from localhost ([180.150.153.56]) by mx.google.com with ESMTPSA id da2sm11499174pbb.57.2015.05.10.21.18.13 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 10 May 2015 21:18:13 -0700 (PDT) From: Hanjun Guo To: "Rafael J. Wysocki" , linux-acpi@vger.kernel.org Cc: Will Deacon , Catalin Marinas , Boris Ostrovsky , Stefano Stabellini , Lorenzo Pieralisi , Sudeep Holla , Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, Hanjun Guo Subject: [PATCH v3 3/7] Xen / ACPI / processor: Remove unneeded NULL check Date: Mon, 11 May 2015 12:17:15 +0800 Message-Id: <1431317839-4584-4-git-send-email-hanjun.guo@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1431317839-4584-1-git-send-email-hanjun.guo@linaro.org> References: <1431317839-4584-1-git-send-email-hanjun.guo@linaro.org> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Before xen_acpi_processor_enable() is called, struct acpi_processor *pr is allocated in xen_acpi_processor_add() and checked if it's NULL, so no need to check again when passed to xen_acpi_processor_enable(), just remove it. Signed-off-by: Hanjun Guo CC: Boris Ostrovsky CC: Stefano Stabellini Reviewed-by: Konrad Rzeszutek Wilk --- drivers/xen/xen-acpi-cpuhotplug.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/xen/xen-acpi-cpuhotplug.c b/drivers/xen/xen-acpi-cpuhotplug.c index 5a62aa0..f4a3694 100644 --- a/drivers/xen/xen-acpi-cpuhotplug.c +++ b/drivers/xen/xen-acpi-cpuhotplug.c @@ -46,13 +46,7 @@ static int xen_acpi_processor_enable(struct acpi_device *device) unsigned long long value; union acpi_object object = { 0 }; struct acpi_buffer buffer = { sizeof(union acpi_object), &object }; - struct acpi_processor *pr; - - pr = acpi_driver_data(device); - if (!pr) { - pr_err(PREFIX "Cannot find driver data\n"); - return -EINVAL; - } + struct acpi_processor *pr = acpi_driver_data(device); if (!strcmp(acpi_device_hid(device), ACPI_PROCESSOR_OBJECT_HID)) { /* Declared with "Processor" statement; match ProcessorID */