| Message ID | 1431953961-22706-4-git-send-email-hanjun.guo@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Mon, 18 May 2015, Hanjun Guo wrote: > diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c > index 65d6b93..855ead9 100644 > --- a/drivers/acpi/irq.c > +++ b/drivers/acpi/irq.c > @@ -32,6 +32,9 @@ void __init acpi_irqchip_init(void) > if (acpi_disabled) > return; > > + if (acpi_gic_version_init()) > + return; This looks just wrong. acpi_irqchip_init() is a generic ACPI function and now you stick a GIC specific callback into it? What calls acpi_irqchip_init? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015?05?21? 04:02, Thomas Gleixner wrote: > On Mon, 18 May 2015, Hanjun Guo wrote: >> diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c >> index 65d6b93..855ead9 100644 >> --- a/drivers/acpi/irq.c >> +++ b/drivers/acpi/irq.c >> @@ -32,6 +32,9 @@ void __init acpi_irqchip_init(void) >> if (acpi_disabled) >> return; >> >> + if (acpi_gic_version_init()) >> + return; > > This looks just wrong. acpi_irqchip_init() is a generic ACPI function > and now you stick a GIC specific callback into it? For now, acpi_irqchip_init() just introduced for GIC init, not for APIC init for x86, and I don't see the usage in the near future. > > What calls acpi_irqchip_init? I renamed it as acpi_irq_init() in the later patch, which is called in irqchip_init() in drivers/irqchip/irqchip.c to init irqchip when DT is not available. This is not a nice way, but the kernel should stay functional for each patch goes in, so I separate the patch to smaller one for easy review under that rule, does it make sense? Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 21 May 2015, Hanjun Guo wrote: > On 2015?05?21? 04:02, Thomas Gleixner wrote: > > On Mon, 18 May 2015, Hanjun Guo wrote: > > > diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c > > > index 65d6b93..855ead9 100644 > > > --- a/drivers/acpi/irq.c > > > +++ b/drivers/acpi/irq.c > > > @@ -32,6 +32,9 @@ void __init acpi_irqchip_init(void) > > > if (acpi_disabled) > > > return; > > > > > > + if (acpi_gic_version_init()) > > > + return; > > > > This looks just wrong. acpi_irqchip_init() is a generic ACPI function > > and now you stick a GIC specific callback into it? > > For now, acpi_irqchip_init() just introduced for GIC init, not for > APIC init for x86, and I don't see the usage in the near future. > > > > > What calls acpi_irqchip_init? > > I renamed it as acpi_irq_init() in the later patch, which > is called in irqchip_init() in drivers/irqchip/irqchip.c > to init irqchip when DT is not available. Neither of those names is a good choice as they suggest that this is a generic acpi mechanism while in fact it is a GIC specific ACPI extension. And its therefor wrong to put that code into drivers/acpi. It belongs into drivers/irqchip/gic-acpi.c or some other descriptive name. Thanks, tglx
On 2015?05?21? 22:39, Thomas Gleixner wrote: > On Thu, 21 May 2015, Hanjun Guo wrote: >> On 2015?05?21? 04:02, Thomas Gleixner wrote: >>> On Mon, 18 May 2015, Hanjun Guo wrote: >>>> diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c >>>> index 65d6b93..855ead9 100644 >>>> --- a/drivers/acpi/irq.c >>>> +++ b/drivers/acpi/irq.c >>>> @@ -32,6 +32,9 @@ void __init acpi_irqchip_init(void) >>>> if (acpi_disabled) >>>> return; >>>> >>>> + if (acpi_gic_version_init()) >>>> + return; >>> >>> This looks just wrong. acpi_irqchip_init() is a generic ACPI function >>> and now you stick a GIC specific callback into it? >> >> For now, acpi_irqchip_init() just introduced for GIC init, not for >> APIC init for x86, and I don't see the usage in the near future. >> >>> >>> What calls acpi_irqchip_init? >> >> I renamed it as acpi_irq_init() in the later patch, which >> is called in irqchip_init() in drivers/irqchip/irqchip.c >> to init irqchip when DT is not available. > > Neither of those names is a good choice as they suggest that this is a > generic acpi mechanism while in fact it is a GIC specific ACPI > extension. And its therefor wrong to put that code into drivers/acpi. OK, thanks for the suggestion. > > It belongs into drivers/irqchip/gic-acpi.c or some other descriptive > name. I already introduced a similar file named irq-gic-acpi.c under drivers/irqchip/, will move the code to there in next version. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 7796af4..9b80428 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -15,6 +15,7 @@ config ARM64 select ARM_AMBA select ARM_ARCH_TIMER select ARM_GIC + select ARM_GIC_ACPI if ACPI select AUDIT_ARCH_COMPAT_GENERIC select ARM_GIC_V2M if PCI_MSI select ARM_GIC_V3 diff --git a/drivers/acpi/irq.c b/drivers/acpi/irq.c index 65d6b93..855ead9 100644 --- a/drivers/acpi/irq.c +++ b/drivers/acpi/irq.c @@ -32,6 +32,9 @@ void __init acpi_irqchip_init(void) if (acpi_disabled) return; + if (acpi_gic_version_init()) + return; + for (id = __irqchip_acpi_table; id->id[0]; id++) acpi_table_parse(id->id, (acpi_tbl_table_handler)id->data); } diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 6de62a9..0dd64c5 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -46,6 +46,9 @@ config ARM_VIC_NR The maximum number of VICs available in the system, for power management. +config ARM_GIC_ACPI + bool + config ATMEL_AIC_IRQ bool select GENERIC_IRQ_CHIP diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile index dda4927..0bd8e49 100644 --- a/drivers/irqchip/Makefile +++ b/drivers/irqchip/Makefile @@ -23,6 +23,7 @@ obj-$(CONFIG_ARM_GIC) += irq-gic.o irq-gic-common.o obj-$(CONFIG_ARM_GIC_V2M) += irq-gic-v2m.o obj-$(CONFIG_ARM_GIC_V3) += irq-gic-v3.o irq-gic-common.o obj-$(CONFIG_ARM_GIC_V3_ITS) += irq-gic-v3-its.o +obj-$(CONFIG_ARM_GIC_ACPI) += irq-gic-acpi.o obj-$(CONFIG_ARM_NVIC) += irq-nvic.o obj-$(CONFIG_ARM_VIC) += irq-vic.o obj-$(CONFIG_ATMEL_AIC_IRQ) += irq-atmel-aic-common.o irq-atmel-aic.o diff --git a/drivers/irqchip/irq-gic-acpi.c b/drivers/irqchip/irq-gic-acpi.c new file mode 100644 index 0000000..53a86ef --- /dev/null +++ b/drivers/irqchip/irq-gic-acpi.c @@ -0,0 +1,111 @@ +/* + * ACPI based support for ARM GIC init + * + * Copyright (C) 2015, Linaro Ltd. + * Author: Hanjun Guo <hanjun.guo@linaro.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#define pr_fmt(fmt) "ACPI: GIC: " fmt + +#include <linux/acpi.h> +#include <linux/init.h> +#include <linux/irqchip/arm-gic-acpi.h> +#include <linux/irqchip/arm-gic-v3.h> + +/* GIC version presented in MADT GIC distributor structure */ +static u8 gic_version __initdata = ACPI_MADT_GIC_VER_UNKNOWN; + +static phys_addr_t dist_phy_base __initdata; + +static int __init +acpi_gic_parse_distributor(struct acpi_subtable_header *header, + const unsigned long end) +{ + struct acpi_madt_generic_distributor *dist; + + dist = (struct acpi_madt_generic_distributor *)header; + + if (BAD_MADT_ENTRY(dist, end)) + return -EINVAL; + + gic_version = dist->gic_version; + dist_phy_base = dist->base_address; + return 0; +} + +static int __init +match_gic_redist(struct acpi_subtable_header *header, const unsigned long end) +{ + return 0; +} + +static bool __init acpi_gic_redist_is_present(void) +{ + int count; + + /* scan MADT table to find if we have redistributor entries */ + count = acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_REDISTRIBUTOR, + match_gic_redist, 0); + + /* has at least one GIC redistributor entry */ + if (count > 0) + return true; + else + return false; +} + +int __init acpi_gic_version_init(void) +{ + int count; + void __iomem *dist_base; + u32 reg; + + count = acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR, + acpi_gic_parse_distributor, 0); + + if (count <= 0) { + pr_err("No valid GIC distributor entry exists\n"); + return -ENODEV; + } + + if (gic_version >= ACPI_MADT_GIC_VER_RESERVED) { + pr_err("Invalid GIC version %d in MADT\n", gic_version); + return -EINVAL; + } + + /* + * when the GIC version is 0, we fallback to hardware discovery. + * this is also needed to keep compatiable with ACPI 5.1, + * which has no gic_version field in distributor structure and + * reserved as 0. + * + * For hardware discovery, the offset for GICv1/2 and GICv3/4 to + * get the GIC version is different (0xFE8 for GICv1/2 and 0xFFE8 + * for GICv3/4), so we need to handle it separately. + */ + if (gic_version == ACPI_MADT_GIC_VER_UNKNOWN) { + /* it's GICv3/v4 if redistributor is present */ + if (acpi_gic_redist_is_present()) { + dist_base = ioremap(dist_phy_base, + ACPI_GICV3_DIST_MEM_SIZE); + if (!dist_base) + return -ENOMEM; + + reg = readl_relaxed(dist_base + GICD_PIDR2) & GIC_PIDR2_ARCH_MASK; + if (reg == GIC_PIDR2_ARCH_GICv3) + gic_version = ACPI_MADT_GIC_VER_V3; + else + gic_version = ACPI_MADT_GIC_VER_V4; + + iounmap(dist_base); + } else { + gic_version = ACPI_MADT_GIC_VER_V2; + } + } + + return 0; +} diff --git a/include/linux/irqchip/arm-gic-acpi.h b/include/linux/irqchip/arm-gic-acpi.h index de3419e..0d5f204 100644 --- a/include/linux/irqchip/arm-gic-acpi.h +++ b/include/linux/irqchip/arm-gic-acpi.h @@ -19,11 +19,13 @@ */ #define ACPI_GICV2_DIST_MEM_SIZE (SZ_4K) #define ACPI_GIC_CPU_IF_MEM_SIZE (SZ_8K) +#define ACPI_GICV3_DIST_MEM_SIZE (SZ_64K) struct acpi_table_header; int gic_v2_acpi_init(struct acpi_table_header *table); void acpi_gic_init(void); +int acpi_gic_version_init(void); #else static inline void acpi_gic_init(void) { } #endif
There is a field added in ACPI MADT table to indicate the GIC version, so parse the table to get its value for later use. If GIC version presented in MADT is 0, we need to fallback to hardware discovery to get the GIC version. Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org> --- arch/arm64/Kconfig | 1 + drivers/acpi/irq.c | 3 + drivers/irqchip/Kconfig | 3 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-gic-acpi.c | 111 +++++++++++++++++++++++++++++++++++ include/linux/irqchip/arm-gic-acpi.h | 2 + 6 files changed, 121 insertions(+) create mode 100644 drivers/irqchip/irq-gic-acpi.c