diff mbox

ACPICA: Add MADT generic distributor version values for ACPI 6.0

Message ID 1432885567-5924-1-git-send-email-hanjun.guo@linaro.org (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Hanjun Guo May 29, 2015, 7:46 a.m. UTC
ACPI 6.0 specified MADT generic distributor version values, but
the detail definition is missing in ACPICA version 20150515, add
its support in this patch.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---

This is the linux version of GIC version patch, please
help to handle it, thanks!

 include/acpi/actbl1.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Moore, Robert May 29, 2015, 12:54 p.m. UTC | #1
Usually, we ACPICA just #defines the individual values so that it is very easy to see the values at a glance. We only enum internal things.



> -----Original Message-----
> From: Hanjun Guo [mailto:hanjun.guo@linaro.org]
> Sent: Friday, May 29, 2015 12:46 AM
> To: Zheng, Lv
> Cc: Moore, Robert; Rafael J. Wysocki; Al Stone; devel@acpica.org; linux-
> acpi@vger.kernel.org; Hanjun Guo
> Subject: [PATCH] ACPICA: Add MADT generic distributor version values for
> ACPI 6.0
> 
> ACPI 6.0 specified MADT generic distributor version values, but the detail
> definition is missing in ACPICA version 20150515, add its support in this
> patch.
> 
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
> 
> This is the linux version of GIC version patch, please help to handle it,
> thanks!
> 
>  include/acpi/actbl1.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> 06b61f0..a53530d1 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -835,6 +835,17 @@ struct acpi_madt_generic_distributor {
>  	u8 reserved2[3];	/* reserved - must be zero */
>  };
> 
> +/* Values for version in Generic Distributor  (ACPI 6.0) */
> +
> +enum acpi_madt_gic_version_type {
> +	ACPI_MADT_GIC_VER_UNKNOWN	= 0,
> +	ACPI_MADT_GIC_VER_V1		= 1,
> +	ACPI_MADT_GIC_VER_V2		= 2,
> +	ACPI_MADT_GIC_VER_V3		= 3,
> +	ACPI_MADT_GIC_VER_V4		= 4,
> +	ACPI_MADT_GIC_VER_RESERVED	= 5	/* 5 and greater are reserved */
> +};
> +
>  /* 13: Generic MSI Frame (ACPI 5.1) */
> 
>  struct acpi_madt_generic_msi_frame {
> --
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Moore, Robert May 29, 2015, 3:45 p.m. UTC | #2
Actually, that is fine the way it is. I'll integrate it today.


> -----Original Message-----
> From: Devel [mailto:devel-bounces@acpica.org] On Behalf Of Moore, Robert
> Sent: Friday, May 29, 2015 5:55 AM
> To: Hanjun Guo; Zheng, Lv
> Cc: linux-acpi@vger.kernel.org; Rafael J. Wysocki; Al Stone;
> devel@acpica.org
> Subject: Re: [Devel] [PATCH] ACPICA: Add MADT generic distributor version
> values for ACPI 6.0
> 
> Usually, we ACPICA just #defines the individual values so that it is very
> easy to see the values at a glance. We only enum internal things.
> 
> 
> 
> > -----Original Message-----
> > From: Hanjun Guo [mailto:hanjun.guo@linaro.org]
> > Sent: Friday, May 29, 2015 12:46 AM
> > To: Zheng, Lv
> > Cc: Moore, Robert; Rafael J. Wysocki; Al Stone; devel@acpica.org;
> > linux- acpi@vger.kernel.org; Hanjun Guo
> > Subject: [PATCH] ACPICA: Add MADT generic distributor version values
> > for ACPI 6.0
> >
> > ACPI 6.0 specified MADT generic distributor version values, but the
> > detail definition is missing in ACPICA version 20150515, add its
> > support in this patch.
> >
> > Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> > ---
> >
> > This is the linux version of GIC version patch, please help to handle
> > it, thanks!
> >
> >  include/acpi/actbl1.h | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> > 06b61f0..a53530d1 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -835,6 +835,17 @@ struct acpi_madt_generic_distributor {
> >  	u8 reserved2[3];	/* reserved - must be zero */
> >  };
> >
> > +/* Values for version in Generic Distributor  (ACPI 6.0) */
> > +
> > +enum acpi_madt_gic_version_type {
> > +	ACPI_MADT_GIC_VER_UNKNOWN	= 0,
> > +	ACPI_MADT_GIC_VER_V1		= 1,
> > +	ACPI_MADT_GIC_VER_V2		= 2,
> > +	ACPI_MADT_GIC_VER_V3		= 3,
> > +	ACPI_MADT_GIC_VER_V4		= 4,
> > +	ACPI_MADT_GIC_VER_RESERVED	= 5	/* 5 and greater are reserved */
> > +};
> > +
> >  /* 13: Generic MSI Frame (ACPI 5.1) */
> >
> >  struct acpi_madt_generic_msi_frame {
> > --
> > 1.9.1
> 
> _______________________________________________
> Devel mailing list
> Devel@acpica.org
> https://lists.acpica.org/mailman/listinfo/devel
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
index 06b61f0..a53530d1 100644
--- a/include/acpi/actbl1.h
+++ b/include/acpi/actbl1.h
@@ -835,6 +835,17 @@  struct acpi_madt_generic_distributor {
 	u8 reserved2[3];	/* reserved - must be zero */
 };
 
+/* Values for version in Generic Distributor  (ACPI 6.0) */
+
+enum acpi_madt_gic_version_type {
+	ACPI_MADT_GIC_VER_UNKNOWN	= 0,
+	ACPI_MADT_GIC_VER_V1		= 1,
+	ACPI_MADT_GIC_VER_V2		= 2,
+	ACPI_MADT_GIC_VER_V3		= 3,
+	ACPI_MADT_GIC_VER_V4		= 4,
+	ACPI_MADT_GIC_VER_RESERVED	= 5	/* 5 and greater are reserved */
+};
+
 /* 13: Generic MSI Frame (ACPI 5.1) */
 
 struct acpi_madt_generic_msi_frame {