From patchwork Tue Nov 24 22:33:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kani, Toshi" X-Patchwork-Id: 7693201 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DC27ABF90C for ; Tue, 24 Nov 2015 21:38:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E4C822082E for ; Tue, 24 Nov 2015 21:38:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB1B120620 for ; Tue, 24 Nov 2015 21:38:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932096AbbKXVie (ORCPT ); Tue, 24 Nov 2015 16:38:34 -0500 Received: from g2t1383g.austin.hp.com ([15.217.136.92]:1102 "EHLO g2t1383g.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755146AbbKXVid (ORCPT ); Tue, 24 Nov 2015 16:38:33 -0500 Received: from g4t3428.houston.hp.com (g4t3428.houston.hp.com [15.201.208.56]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by g2t1383g.austin.hp.com (Postfix) with ESMTPS id 8BBA32F85 for ; Tue, 24 Nov 2015 21:38:32 +0000 (UTC) Received: from g4t3433.houston.hp.com (g4t3433.houston.hp.com [16.210.25.219]) by g4t3428.houston.hp.com (Postfix) with ESMTP id EABDE53; Tue, 24 Nov 2015 21:38:30 +0000 (UTC) Received: from misato.fc.hp.com (misato.fc.hp.com [16.78.168.61]) by g4t3433.houston.hp.com (Postfix) with ESMTP id 04AC04B; Tue, 24 Nov 2015 21:38:29 +0000 (UTC) From: Toshi Kani To: akpm@linux-foundation.org, rjw@rjwysocki.net, dan.j.williams@intel.com Cc: tony.luck@intel.com, bp@alien8.de, vishal.l.verma@intel.com, linux-mm@kvack.org, linux-nvdimm@lists.01.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Toshi Kani Subject: [PATCH v3 1/3] resource: Add @flags to region_intersects() Date: Tue, 24 Nov 2015 15:33:36 -0700 Message-Id: <1448404418-28800-2-git-send-email-toshi.kani@hpe.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1448404418-28800-1-git-send-email-toshi.kani@hpe.com> References: <1448404418-28800-1-git-send-email-toshi.kani@hpe.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP region_intersects() checks if a specified region partially overlaps or fully eclipses a resource identified by @name. It currently sets resource flags statically, which prevents the caller from specifying a non-RAM region, such as persistent memory. Add @flags so that any region can be specified to the function. A helper function, region_intersects_ram(), is added so that the callers that check a RAM region do not have to specify its iomem resource name and flags. This interface is exported for modules, such as the EINJ driver. Signed-off-by: Toshi Kani Reviewed-by: Dan Williams Cc: Andrew Morton Cc: Vishal Verma --- include/linux/mm.h | 4 +++- kernel/memremap.c | 5 ++--- kernel/resource.c | 23 ++++++++++++++++------- 3 files changed, 21 insertions(+), 11 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/mm.h b/include/linux/mm.h index 00bad77..c776af3 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -362,7 +362,9 @@ enum { REGION_MIXED, }; -int region_intersects(resource_size_t offset, size_t size, const char *type); +int region_intersects(resource_size_t offset, size_t size, const char *type, + unsigned long flags); +int region_intersects_ram(resource_size_t offset, size_t size); /* Support for virtually mapped pages */ struct page *vmalloc_to_page(const void *addr); diff --git a/kernel/memremap.c b/kernel/memremap.c index 7658d32..98f52f1 100644 --- a/kernel/memremap.c +++ b/kernel/memremap.c @@ -57,7 +57,7 @@ static void *try_ram_remap(resource_size_t offset, size_t size) */ void *memremap(resource_size_t offset, size_t size, unsigned long flags) { - int is_ram = region_intersects(offset, size, "System RAM"); + int is_ram = region_intersects_ram(offset, size); void *addr = NULL; if (is_ram == REGION_MIXED) { @@ -162,8 +162,7 @@ static void devm_memremap_pages_release(struct device *dev, void *res) void *devm_memremap_pages(struct device *dev, struct resource *res) { - int is_ram = region_intersects(res->start, resource_size(res), - "System RAM"); + int is_ram = region_intersects_ram(res->start, resource_size(res)); struct page_map *page_map; int error, nid; diff --git a/kernel/resource.c b/kernel/resource.c index f150dbb..15c133e 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -497,6 +497,7 @@ EXPORT_SYMBOL_GPL(page_is_ram); * @start: region start address * @size: size of region * @name: name of resource (in iomem_resource) + * @flags: flags of resource (in iomem_resource) * * Check if the specified region partially overlaps or fully eclipses a * resource identified by @name. Return REGION_DISJOINT if the region @@ -504,15 +505,11 @@ EXPORT_SYMBOL_GPL(page_is_ram); * @type and another resource, and return REGION_INTERSECTS if the * region overlaps @type and no other defined resource. Note, that * REGION_INTERSECTS is also returned in the case when the specified - * region overlaps RAM and undefined memory holes. - * - * region_intersect() is used by memory remapping functions to ensure - * the user is not remapping RAM and is a vast speed up over walking - * through the resource table page by page. + * region overlaps with undefined memory holes. */ -int region_intersects(resource_size_t start, size_t size, const char *name) +int region_intersects(resource_size_t start, size_t size, const char *name, + unsigned long flags) { - unsigned long flags = IORESOURCE_MEM | IORESOURCE_BUSY; resource_size_t end = start + size - 1; int type = 0; int other = 0; struct resource *p; @@ -539,6 +536,18 @@ int region_intersects(resource_size_t start, size_t size, const char *name) return REGION_DISJOINT; } +/* + * region_intersect_ram() is used by memory remapping functions to ensure + * the user is not remapping RAM and is a vast speed up over walking + * through the resource table page by page. + */ +int region_intersects_ram(resource_size_t start, size_t size) +{ + return region_intersects(start, size, "System RAM", + IORESOURCE_MEM | IORESOURCE_BUSY); +} +EXPORT_SYMBOL_GPL(region_intersects_ram); + void __weak arch_remove_reservations(struct resource *avail) { }