| Message ID | 1450720245-67575-1-git-send-email-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 12/21/2015 10:50 AM, Andy Shevchenko wrote: > The LPSS DMA device does have neither _PS0 nor _PS3 method. Fix the wording in > the comment line. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/acpi/acpi_lpss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c > index 84d3d90..6c6661d 100644 > --- a/drivers/acpi/acpi_lpss.c > +++ b/drivers/acpi/acpi_lpss.c > @@ -95,7 +95,7 @@ static unsigned int lpss_quirks; > /* > * LPSS_QUIRK_ALWAYS_POWER_ON: override power state for LPSS DMA device. > * > - * The LPSS DMA controller does not have neither _PS0 nor _PS3 method. Moreover > + * The LPSS DMA controller does have neither _PS0 nor _PS3 method. Moreover Neither of the above are very clear. I think proper English would be: The LPSS DMA controller has neither a _PS0 nor a _PS3 method. or, alternatively: The LPSS DMA controller does not have either a _PS0 or a _PS3 method. This assumes that the point of the statement is to say that _PS0 and _PS3 methods do not exist for the LPSS DMA controller. > * it can be powered off automatically whenever the last LPSS device goes down. > * In case of no power any access to the DMA controller will hang the system. > * The behaviour is reproduced on some HP laptops based on Intel BayTrail as >
On Mon, 2015-12-21 at 10:59 -0700, Al Stone wrote: > On 12/21/2015 10:50 AM, Andy Shevchenko wrote: > > The LPSS DMA device does have neither _PS0 nor _PS3 method. Fix the > > wording in > > the comment line. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/acpi/acpi_lpss.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c > > index 84d3d90..6c6661d 100644 > > --- a/drivers/acpi/acpi_lpss.c > > +++ b/drivers/acpi/acpi_lpss.c > > @@ -95,7 +95,7 @@ static unsigned int lpss_quirks; > > /* > > * LPSS_QUIRK_ALWAYS_POWER_ON: override power state for LPSS DMA > > device. > > * > > - * The LPSS DMA controller does not have neither _PS0 nor _PS3 > > method. Moreover > > + * The LPSS DMA controller does have neither _PS0 nor _PS3 method. > > Moreover > > Neither of the above are very clear. I think proper English would > be: > > The LPSS DMA controller has neither a _PS0 nor a _PS3 method. > > or, alternatively: > > The LPSS DMA controller does not have either a _PS0 or a _PS3 > method. > > This assumes that the point of the statement is to say that _PS0 and > _PS3 > methods do not exist for the LPSS DMA controller. Thanks! Will update this. > > > * it can be powered off automatically whenever the last LPSS > > device goes down. > > * In case of no power any access to the DMA controller will hang > > the system. > > * The behaviour is reproduced on some HP laptops based on Intel > > BayTrail as > > > >
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c index 84d3d90..6c6661d 100644 --- a/drivers/acpi/acpi_lpss.c +++ b/drivers/acpi/acpi_lpss.c @@ -95,7 +95,7 @@ static unsigned int lpss_quirks; /* * LPSS_QUIRK_ALWAYS_POWER_ON: override power state for LPSS DMA device. * - * The LPSS DMA controller does not have neither _PS0 nor _PS3 method. Moreover + * The LPSS DMA controller does have neither _PS0 nor _PS3 method. Moreover * it can be powered off automatically whenever the last LPSS device goes down. * In case of no power any access to the DMA controller will hang the system. * The behaviour is reproduced on some HP laptops based on Intel BayTrail as
The LPSS DMA device does have neither _PS0 nor _PS3 method. Fix the wording in the comment line. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/acpi/acpi_lpss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)