diff mbox

[v4,2/2] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ

Message ID 1453335459-3617-3-git-send-email-lho@apm.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Loc Ho Jan. 21, 2016, 12:17 a.m. UTC
This patch allows APEI generic error source table with external
IRQ to share an single IRQ.

Signed-off-by: Tuan Phan <tphan@apm.com>
Signed-off-by: Loc Ho <lho@apm.com>
---
 drivers/acpi/apei/ghes.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Loc Ho Jan. 25, 2016, 9:25 p.m. UTC | #1
Hi Borislav,

On Wed, Jan 20, 2016 at 4:17 PM, Loc Ho <lho@apm.com> wrote:
> This patch allows APEI generic error source table with external
> IRQ to share an single IRQ.
>
> Signed-off-by: Tuan Phan <tphan@apm.com>
> Signed-off-by: Loc Ho <lho@apm.com>
> ---
>  drivers/acpi/apei/ghes.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 3dd9c46..76146c8 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1011,7 +1011,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
>                                generic->header.source_id);
>                         goto err_edac_unreg;
>                 }
> -               rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
> +               rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
> +                                "GHES IRQ", ghes);
>                 if (rc) {
>                         pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
>                                generic->header.source_id);

Can this be pull into 4.5-rcX given that it was already ack'ed week back?

-Loc
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Borislav Petkov Jan. 25, 2016, 9:54 p.m. UTC | #2
On Mon, Jan 25, 2016 at 01:25:00PM -0800, Loc Ho wrote:
> Can this be pull into 4.5-rcX given that it was already ack'ed week back?

It is still Rafael's decision, as I've already stated.

Rafael?
diff mbox

Patch

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index 3dd9c46..76146c8 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -1011,7 +1011,8 @@  static int ghes_probe(struct platform_device *ghes_dev)
 			       generic->header.source_id);
 			goto err_edac_unreg;
 		}
-		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
+		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
+				 "GHES IRQ", ghes);
 		if (rc) {
 			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
 			       generic->header.source_id);