diff mbox

libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string

Message ID 1453379530-21727-1-git-send-email-jlee@suse.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Chun-Yi Lee Jan. 21, 2016, 12:32 p.m. UTC
It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
coded string.

Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
 drivers/acpi/nfit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ross Zwisler Jan. 21, 2016, 4:08 p.m. UTC | #1
On Thu, Jan 21, 2016 at 08:32:10PM +0800, Lee, Chun-Yi wrote:
> It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
> coded string.
> 
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>

Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>

>  drivers/acpi/nfit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
> index aa45d48..9fb1a6a 100644
> --- a/drivers/acpi/nfit.c
> +++ b/drivers/acpi/nfit.c
> @@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
>  	acpi_size sz;
>  	int rc;
>  
> -	status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
> +	status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
>  	if (ACPI_FAILURE(status)) {
>  		/* This is ok, we could have an nvdimm hotplugged later */
>  		dev_dbg(dev, "failed to find NFIT at startup\n");
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
index aa45d48..9fb1a6a 100644
--- a/drivers/acpi/nfit.c
+++ b/drivers/acpi/nfit.c
@@ -1739,7 +1739,7 @@  static int acpi_nfit_add(struct acpi_device *adev)
 	acpi_size sz;
 	int rc;
 
-	status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
+	status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
 	if (ACPI_FAILURE(status)) {
 		/* This is ok, we could have an nvdimm hotplugged later */
 		dev_dbg(dev, "failed to find NFIT at startup\n");