From patchwork Tue May 31 11:19:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 9144365 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D1F6C60757 for ; Tue, 31 May 2016 11:20:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5B2D27D17 for ; Tue, 31 May 2016 11:20:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BA6BF281B4; Tue, 31 May 2016 11:20:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E27127D17 for ; Tue, 31 May 2016 11:20:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753504AbcEaLUP (ORCPT ); Tue, 31 May 2016 07:20:15 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:34546 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753381AbcEaLUL (ORCPT ); Tue, 31 May 2016 07:20:11 -0400 Received: by mail-lf0-f45.google.com with SMTP id k98so88060664lfi.1 for ; Tue, 31 May 2016 04:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+F7qyXTzDYS+coKMXvqlcM+WiYxg7ChfE3OzvarDeZ0=; b=xD1LY4ddgCi27OSJ0f7cNJP9pKCKcNu7D0nwj5tCSZ7kiqRc7+k1u5wTz7yNJydO+y U7oeDrgvKpoNBMUcoMBW/LdCCiKnVRbOlOzxpSgrmWIpU3e56exNj3RoPFHvnfT53W0x I7uAZL+Pq/2sXaWHpFr44wYyXsxkGPlY1W5IZOAZxb9BIuSD8/3DXoCrPxW736LZ+MVs AmSsfllz3B8nQCxkr8yCw8M5PnF9qDWPkQXeobkkAsnHOPEIYphcFGb1OLaJATghE1zw QipJE/xGYjdt76OfSXti3wn3jCv/iOuSi56mC7lGSCtuzYs9WSnZdiBWY0D5Uyk65H18 D/mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+F7qyXTzDYS+coKMXvqlcM+WiYxg7ChfE3OzvarDeZ0=; b=GpMUf4YPSKnLO1sJW7nm0ajgauwXObC1SwybdPpOpbKiKwXaGxojKfI5xfqxig+Q7m C8R5cp+Ibw6dgGOCJsmp5jLf8swRPde0uN3hwD0d3iKfgqanUVPfdoLIifyYo19k0wCf 5L2TB2HnEjUkvsE4SPjXjVExaxjBwOv0o9U6ZzVIYm9BP0i5zzGZiuFzE/hJBsqJHze1 G9oTp2raD1+a5EtyGEGhpQhaB8tUyPoyf0yMqYXsLrLXiKsxL03J/xNpf0uwLyXVfzhO cUDCkkqYXFbNowg4ZV3mq/TzjfyVnqQCOvG7+Z/ew/X7PFGoKvgdgB/iRiP6jq3NvIcF mc/g== X-Gm-Message-State: ALyK8tJe4COTqvDwQDS+V/RFV78LQ+U1vC8HegXJraCV1wNWBRRbFJuKlcDMhrAbKVaMFw== X-Received: by 10.46.33.12 with SMTP id h12mr7922391ljh.35.1464693604226; Tue, 31 May 2016 04:20:04 -0700 (PDT) Received: from tn-HP-4.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id 66sm5280056lfz.14.2016.05.31.04.20.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 31 May 2016 04:20:03 -0700 (PDT) From: Tomasz Nowicki To: marc.zyngier@arm.com, tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net, lorenzo.pieralisi@arm.com, robert.richter@caviumnetworks.com, shijie.huang@arm.com, Suravee.Suthikulpanit@amd.com, hanjun.guo@linaro.org Cc: al.stone@linaro.org, mw@semihalf.com, graeme.gregory@linaro.org, Catalin.Marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ddaney.cavm@gmail.com, okaya@codeaurora.org, andrea.gallo@linaro.org, Tomasz Nowicki Subject: [PATCH V5 3/7] irqchip, GICv3, ITS: Cleanup for ITS domain initialization. Date: Tue, 31 May 2016 13:19:40 +0200 Message-Id: <1464693584-22343-4-git-send-email-tn@semihalf.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464693584-22343-1-git-send-email-tn@semihalf.com> References: <1464693584-22343-1-git-send-email-tn@semihalf.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no point to initialize ITS without having msi-controller property in corresponding DT node. However, its_probe is checking msi-controller presence at the end, so we can save our time and do that check prior to its_probe call. Also, for the code clarity purpose, we put domain initialization to separate function. Signed-off-by: Tomasz Nowicki Acked-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its.c | 57 ++++++++++++++++++++++++---------------- 1 file changed, 34 insertions(+), 23 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 6bd881b..cb33c92 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -1463,13 +1463,37 @@ static void its_enable_quirks(struct its_node *its) gic_enable_quirks(iidr, its_quirks, its); } +static int its_init_domain(struct device_node *node, struct its_node *its, + struct irq_domain *parent) +{ + struct irq_domain *inner_domain; + struct msi_domain_info *info; + + info = kzalloc(sizeof(*info), GFP_KERNEL); + if (!info) + return -ENOMEM; + + inner_domain = irq_domain_add_tree(node, &its_domain_ops, its); + if (!inner_domain) { + kfree(info); + return -ENOMEM; + } + + inner_domain->parent = parent; + inner_domain->bus_token = DOMAIN_BUS_NEXUS; + info->ops = &its_msi_domain_ops; + info->data = its; + inner_domain->host_data = info; + + return 0; +} + static int __init its_probe(struct device_node *node, struct irq_domain *parent) { struct resource res; struct its_node *its; void __iomem *its_base; - struct irq_domain *inner_domain; u32 val; u64 baser, tmp; int err; @@ -1560,28 +1584,9 @@ static int __init its_probe(struct device_node *node, writeq_relaxed(0, its->base + GITS_CWRITER); writel_relaxed(GITS_CTLR_ENABLE, its->base + GITS_CTLR); - if (of_property_read_bool(node, "msi-controller")) { - struct msi_domain_info *info; - - info = kzalloc(sizeof(*info), GFP_KERNEL); - if (!info) { - err = -ENOMEM; - goto out_free_tables; - } - - inner_domain = irq_domain_add_tree(node, &its_domain_ops, its); - if (!inner_domain) { - err = -ENOMEM; - kfree(info); - goto out_free_tables; - } - - inner_domain->parent = parent; - inner_domain->bus_token = DOMAIN_BUS_NEXUS; - info->ops = &its_msi_domain_ops; - info->data = its; - inner_domain->host_data = info; - } + err = its_init_domain(node, its, parent); + if (err) + goto out_free_tables; spin_lock(&its_lock); list_add(&its->entry, &its_nodes); @@ -1632,6 +1637,12 @@ int __init its_init(struct device_node *node, struct rdists *rdists, for (np = of_find_matching_node(node, its_device_id); np; np = of_find_matching_node(np, its_device_id)) { + if (!of_property_read_bool(np, "msi-controller")) { + pr_warn("%s: no msi-controller property, ITS ignored\n", + np->full_name); + continue; + } + its_probe(np, parent_domain); }