| Message ID | 1465945963-22353-1-git-send-email-hotran@apm.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi Hoan, On 6/14/2016 5:12 PM, Hoan Tran wrote: > As PCC will be used by other clients not only CPPC. > This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel() > declarations > > Signed-off-by: Hoan Tran <hotran@apm.com> > --- > include/acpi/cppc_acpi.h | 4 ---- > include/linux/mailbox_client.h | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h > index dad8af3..819b4b9 100644 > --- a/include/acpi/cppc_acpi.h > +++ b/include/acpi/cppc_acpi.h > @@ -130,8 +130,4 @@ extern int cppc_set_perf(int cpu, struct cppc_perf_ctrls *perf_ctrls); > extern int cppc_get_perf_caps(int cpu, struct cppc_perf_caps *caps); > extern int acpi_get_psd_map(struct cpudata **); > > -/* Methods to interact with the PCC mailbox controller. */ > -extern struct mbox_chan * > - pcc_mbox_request_channel(struct mbox_client *, unsigned int); > - > #endif /* _CPPC_ACPI_H*/ > diff --git a/include/linux/mailbox_client.h b/include/linux/mailbox_client.h > index 41e2af8..2758d18 100644 > --- a/include/linux/mailbox_client.h > +++ b/include/linux/mailbox_client.h > @@ -50,4 +50,8 @@ void mbox_client_txdone(struct mbox_chan *chan, int r); /* atomic */ > bool mbox_client_peek_data(struct mbox_chan *chan); /* atomic */ > void mbox_free_channel(struct mbox_chan *chan); /* may sleep */ > > +/* Methods to interact with the PCC mailbox controller. */ > +struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *, int); > +void pcc_mbox_free_channel(struct mbox_chan *chan); > + Since these APIs are specific to PCC, may be we should introduce a new header for pcc clients instead of adding to the common mailbox_client header. > #endif /* __MAILBOX_CLIENT_H */ Thanks, Prashanth -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Prashanth, On Wed, Jun 15, 2016 at 8:55 AM, Prakash, Prashanth <pprakash@codeaurora.org> wrote: > Hi Hoan, > > On 6/14/2016 5:12 PM, Hoan Tran wrote: >> As PCC will be used by other clients not only CPPC. >> This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel() >> declarations >> >> Signed-off-by: Hoan Tran <hotran@apm.com> >> --- >> include/acpi/cppc_acpi.h | 4 ---- >> include/linux/mailbox_client.h | 4 ++++ >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h >> index dad8af3..819b4b9 100644 >> --- a/include/acpi/cppc_acpi.h >> +++ b/include/acpi/cppc_acpi.h >> @@ -130,8 +130,4 @@ extern int cppc_set_perf(int cpu, struct cppc_perf_ctrls *perf_ctrls); >> extern int cppc_get_perf_caps(int cpu, struct cppc_perf_caps *caps); >> extern int acpi_get_psd_map(struct cpudata **); >> >> -/* Methods to interact with the PCC mailbox controller. */ >> -extern struct mbox_chan * >> - pcc_mbox_request_channel(struct mbox_client *, unsigned int); >> - >> #endif /* _CPPC_ACPI_H*/ >> diff --git a/include/linux/mailbox_client.h b/include/linux/mailbox_client.h >> index 41e2af8..2758d18 100644 >> --- a/include/linux/mailbox_client.h >> +++ b/include/linux/mailbox_client.h >> @@ -50,4 +50,8 @@ void mbox_client_txdone(struct mbox_chan *chan, int r); /* atomic */ >> bool mbox_client_peek_data(struct mbox_chan *chan); /* atomic */ >> void mbox_free_channel(struct mbox_chan *chan); /* may sleep */ >> >> +/* Methods to interact with the PCC mailbox controller. */ >> +struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *, int); >> +void pcc_mbox_free_channel(struct mbox_chan *chan); >> + > Since these APIs are specific to PCC, may be we should introduce a new header for pcc clients > instead of adding to the common mailbox_client header. Agreed, maybe I should create a "pcc.h" file inside "/include/acpi" folder. If you have any suggestion about the location of this file, please let me know. Thanks Hoan >> #endif /* __MAILBOX_CLIENT_H */ > > Thanks, > Prashanth -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h index dad8af3..819b4b9 100644 --- a/include/acpi/cppc_acpi.h +++ b/include/acpi/cppc_acpi.h @@ -130,8 +130,4 @@ extern int cppc_set_perf(int cpu, struct cppc_perf_ctrls *perf_ctrls); extern int cppc_get_perf_caps(int cpu, struct cppc_perf_caps *caps); extern int acpi_get_psd_map(struct cpudata **); -/* Methods to interact with the PCC mailbox controller. */ -extern struct mbox_chan * - pcc_mbox_request_channel(struct mbox_client *, unsigned int); - #endif /* _CPPC_ACPI_H*/ diff --git a/include/linux/mailbox_client.h b/include/linux/mailbox_client.h index 41e2af8..2758d18 100644 --- a/include/linux/mailbox_client.h +++ b/include/linux/mailbox_client.h @@ -50,4 +50,8 @@ void mbox_client_txdone(struct mbox_chan *chan, int r); /* atomic */ bool mbox_client_peek_data(struct mbox_chan *chan); /* atomic */ void mbox_free_channel(struct mbox_chan *chan); /* may sleep */ +/* Methods to interact with the PCC mailbox controller. */ +struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *, int); +void pcc_mbox_free_channel(struct mbox_chan *chan); + #endif /* __MAILBOX_CLIENT_H */
As PCC will be used by other clients not only CPPC. This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel() declarations Signed-off-by: Hoan Tran <hotran@apm.com> --- include/acpi/cppc_acpi.h | 4 ---- include/linux/mailbox_client.h | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-)