From patchwork Tue Jun 28 06:39:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chun-Yi Lee X-Patchwork-Id: 9202081 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 14D6160757 for ; Tue, 28 Jun 2016 06:43:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0414C285B7 for ; Tue, 28 Jun 2016 06:43:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EB93A285F2; Tue, 28 Jun 2016 06:43:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71338285B7 for ; Tue, 28 Jun 2016 06:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751060AbcF1Gm7 (ORCPT ); Tue, 28 Jun 2016 02:42:59 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:34872 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbcF1Gm6 (ORCPT ); Tue, 28 Jun 2016 02:42:58 -0400 Received: by mail-pa0-f68.google.com with SMTP id hf6so871257pac.2; Mon, 27 Jun 2016 23:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=H9BJd4/jNZjCJTPGPcCTEBWNi+Fskf3C3iWzdS3GhpU=; b=qhm3+Bpjy/g5tSUvK9YFMWYj33lBdLPpnEGcX8WQs47H7Zo+W2FmKjbTbb1C8pWDPA NVa6Xx8hgz3cS0VxTTeU426lrRzbpL/EJDBjEPYcGXeM3GG1HoN3AXYOCOluEgzOQH+y hM9PZffqPr7kHP5nO+FqDTYPos8ZDFgWodtBIxuOt91iYC8cw4kCDvXuLVy4xa3Nbou5 qGsnqlP5EEgbTDgzho0idbR4rdCbrJAtWXP0LOlx7QFkmYJ5ZAkmg9voYv080Bi4jHph 7b3fBb53+Tc6JcXvlr8C6qfSfTcBLNklWjP50J1kzyBKNdTRb8kGn0nZuSjjiLGVQoBm hOWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=H9BJd4/jNZjCJTPGPcCTEBWNi+Fskf3C3iWzdS3GhpU=; b=DuEQLyJNpqes6axtBOQA94oHOSYb/DwfwNA9E0AdrISXjSGzRJpapT/ppG9rNw3kSS V8SFx5/k+3ViElmiA4lxTN2d7oNMZ6eiji8ZEu/3882nFV3uSg+UqE3XoUGrrBnccH34 paZLoXhC1zqrPbZA1fKkhk6iEz06NJ+ivrqcK/rrVl6pAAYC22/vCTnvUSLFHVyaAPYg QlDOlAheL2nrc4KRGokUU+TyszChnog3eSj9VtirzMw3oXox8n8v/f3lj0WAORNTyt7j y0njQsEBDwDgCOUDmNRHDylOYpgRlHrlMFMBff1QcYJK/V33Xq9UqWb78vfPatVTNk2+ w/Wg== X-Gm-Message-State: ALyK8tK6XJSKrzI2OPWTrUlSXywXRclc8tFC9Nv6atjodmUmKCWZoiat7XSGSVparRowuw== X-Received: by 10.66.149.66 with SMTP id ty2mr2108247pab.153.1467096177173; Mon, 27 Jun 2016 23:42:57 -0700 (PDT) Received: from linux-rxt1.site (59-124-67-67.HINET-IP.hinet.net. [59.124.67.67]) by smtp.gmail.com with ESMTPSA id cq17sm4363263pac.5.2016.06.27.23.42.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jun 2016 23:42:56 -0700 (PDT) From: "Lee, Chun-Yi" X-Google-Original-From: "Lee, Chun-Yi" To: Ross Zwisler , Dan Williams , "Rafael J. Wysocki" , Linda Knippers Cc: linux-nvdimm@lists.01.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee, Chun-Yi" , Gary Lin Subject: [PATCH v4] acpi, nfit: treat virtual ramdisk SPA as pmem region Date: Tue, 28 Jun 2016 14:39:50 +0800 Message-Id: <1467095990-6093-1-git-send-email-jlee@suse.com> X-Mailer: git-send-email 1.8.4.5 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds logic to treat virtual ramdisk SPA as pmem region, then ramdisk's /dev/pmem* device can be mounted with iso9660. It's useful to work with the httpboot in EFI firmware to pull a remote ISO file to the local memory region for booting and installation. Wiki page of UEFI HTTPBoot with OVMF: https://en.opensuse.org/UEFI_HTTPBoot_with_OVMF The ramdisk function in EDK2/OVMF generates a ACPI0012 root device that it contains empty _STA but without _DSM: DefinitionBlock ("ssdt2.aml", "SSDT", 2, "INTEL ", "RamDisk ", 0x00001000) { Scope (\_SB) { Device (NVDR) { Name (_HID, "ACPI0012") // _HID: Hardware ID Name (_STR, Unicode ("NVDIMM Root Device")) // _STR: Description String Method (_STA, 0, NotSerialized) // _STA: Status { Return (0x0F) } } } } In section 5.2.25.2 of ACPI 6.1 spec, it mentions that the "SPA Range Structure Index" of virtual SPA shall be set to zero. That means virtual SPA will not be associated by any NVDIMM region mapping. The VCD's SPA Range Structure in NFIT is similar to virtual disk region as following: [028h 0040 2] Subtable Type : 0000 [System Physical Address Range] [02Ah 0042 2] Length : 0038 [02Ch 0044 2] Range Index : 0000 [02Eh 0046 2] Flags (decoded below) : 0000 Add/Online Operation Only : 0 Proximity Domain Valid : 0 [030h 0048 4] Reserved : 00000000 [034h 0052 4] Proximity Domain : 00000000 [038h 0056 16] Address Range GUID : 77AB535A-45FC-624B-5560-F7B281D1F96E [048h 0072 8] Address Range Base : 00000000B6ABD018 [050h 0080 8] Address Range Length : 0000000005500000 [058h 0088 8] Memory Map Attribute : 0000000000000000 The way to not associate a SPA range is to never reference it from a "flush hint", "interleave", or "control region" table. After testing on OVMF, pmem driver can support the region that it doesn't assoicate to any NVDIMM mapping. So, treat VCD like pmem is a idea to get a pmem block device that it contains iso. v4: Instoduce nfit_spa_is_virtual() to check virtual ramdisk SPA and create pmem region. v3: To simplify patch, removed useless VCD region in libnvdimm. v2: Removed the code for setting VCD to a read-only region. Cc: Gary Lin Cc: Dan Williams Cc: Ross Zwisler Cc: "Rafael J. Wysocki" Cc: Linda Knippers Signed-off-by: Lee, Chun-Yi --- drivers/acpi/nfit.c | 8 +++++++- drivers/nvdimm/region_devs.c | 26 +++++++++++++++++++++++++- include/linux/libnvdimm.h | 2 ++ 3 files changed, 34 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux/drivers/acpi/nfit.c =================================================================== --- linux.orig/drivers/acpi/nfit.c +++ linux/drivers/acpi/nfit.c @@ -1980,6 +1980,14 @@ static int acpi_nfit_init_mapping(struct return 0; } +static bool nfit_spa_is_virtual(struct acpi_nfit_system_address *spa) +{ + return (nfit_spa_type(spa) == NFIT_SPA_VDISK || + nfit_spa_type(spa) == NFIT_SPA_VCD || + nfit_spa_type(spa) == NFIT_SPA_PDISK || + nfit_spa_type(spa) == NFIT_SPA_PCD); +} + static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc, struct nfit_spa *nfit_spa) { @@ -1995,7 +2003,7 @@ static int acpi_nfit_register_region(str if (nfit_spa->nd_region) return 0; - if (spa->range_index == 0) { + if (spa->range_index == 0 && !nfit_spa_is_virtual(spa)) { dev_dbg(acpi_desc->dev, "%s: detected invalid spa index\n", __func__); return 0; @@ -2059,6 +2067,11 @@ static int acpi_nfit_register_region(str ndr_desc); if (!nfit_spa->nd_region) rc = -ENOMEM; + } else if (nfit_spa_is_virtual(spa)) { + nfit_spa->nd_region = nvdimm_pmem_region_create(nvdimm_bus, + ndr_desc); + if (!nfit_spa->nd_region) + rc = -ENOMEM; } out: