| Message ID | 1468555535-30902-1-git-send-email-jlee@suse.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thu, Jul 14, 2016 at 9:05 PM, Lee, Chun-Yi <joeyli.kernel@gmail.com> wrote: > This patch adds logic to treat virtual ramdisk SPA as pmem region, then > ramdisk's /dev/pmem* device can be mounted with iso9660. > > It's useful to work with the httpboot in EFI firmware to pull a remote > ISO file to the local memory region for booting and installation. > > Wiki page of UEFI HTTPBoot with OVMF: > https://en.opensuse.org/UEFI_HTTPBoot_with_OVMF > > The ramdisk function in EDK2/OVMF generates a ACPI0012 root device that > it contains empty _STA but without _DSM: > > DefinitionBlock ("ssdt2.aml", "SSDT", 2, "INTEL ", "RamDisk ", 0x00001000) > { > Scope (\_SB) > { > Device (NVDR) > { > Name (_HID, "ACPI0012") // _HID: Hardware ID > Name (_STR, Unicode ("NVDIMM Root Device")) // _STR: Description String > Method (_STA, 0, NotSerialized) // _STA: Status > { > Return (0x0F) > } > } > } > } > > In section 5.2.25.2 of ACPI 6.1 spec, it mentions that the "SPA Range > Structure Index" of virtual SPA shall be set to zero. That means virtual SPA > will not be associated by any NVDIMM region mapping. > > The VCD's SPA Range Structure in NFIT is similar to virtual disk region > as following: > > [028h 0040 2] Subtable Type : 0000 [System Physical Address Range] > [02Ah 0042 2] Length : 0038 > > [02Ch 0044 2] Range Index : 0000 > [02Eh 0046 2] Flags (decoded below) : 0000 > Add/Online Operation Only : 0 > Proximity Domain Valid : 0 > [030h 0048 4] Reserved : 00000000 > [034h 0052 4] Proximity Domain : 00000000 > [038h 0056 16] Address Range GUID : 77AB535A-45FC-624B-5560-F7B281D1F96E > [048h 0072 8] Address Range Base : 00000000B6ABD018 > [050h 0080 8] Address Range Length : 0000000005500000 > [058h 0088 8] Memory Map Attribute : 0000000000000000 > > The way to not associate a SPA range is to never reference it from a "flush hint", > "interleave", or "control region" table. > > After testing on OVMF, pmem driver can support the region that it doesn't > assoicate to any NVDIMM mapping. So, treat VCD like pmem is a idea to get > a pmem block device that it contains iso. > > v4: > Instoduce nfit_spa_is_virtual() to check virtual ramdisk SPA and create > pmem region. > > v3: > To simplify patch, removed useless VCD region in libnvdimm. > > v2: > Removed the code for setting VCD to a read-only region. > > Cc: Gary Lin <GLin@suse.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Linda Knippers <linda.knippers@hpe.com> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: linux/drivers/acpi/nfit.c =================================================================== --- linux.orig/drivers/acpi/nfit.c +++ linux/drivers/acpi/nfit.c @@ -1980,6 +1980,14 @@ static int acpi_nfit_init_mapping(struct return 0; } +static bool nfit_spa_is_virtual(struct acpi_nfit_system_address *spa) +{ + return (nfit_spa_type(spa) == NFIT_SPA_VDISK || + nfit_spa_type(spa) == NFIT_SPA_VCD || + nfit_spa_type(spa) == NFIT_SPA_PDISK || + nfit_spa_type(spa) == NFIT_SPA_PCD); +} + static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc, struct nfit_spa *nfit_spa) { @@ -1995,7 +2003,7 @@ static int acpi_nfit_register_region(str if (nfit_spa->nd_region) return 0; - if (spa->range_index == 0) { + if (spa->range_index == 0 && !nfit_spa_is_virtual(spa)) { dev_dbg(acpi_desc->dev, "%s: detected invalid spa index\n", __func__); return 0; @@ -2059,6 +2067,11 @@ static int acpi_nfit_register_region(str ndr_desc); if (!nfit_spa->nd_region) rc = -ENOMEM; + } else if (nfit_spa_is_virtual(spa)) { + nfit_spa->nd_region = nvdimm_pmem_region_create(nvdimm_bus, + ndr_desc); + if (!nfit_spa->nd_region) + rc = -ENOMEM; } out:
This patch adds logic to treat virtual ramdisk SPA as pmem region, then ramdisk's /dev/pmem* device can be mounted with iso9660. It's useful to work with the httpboot in EFI firmware to pull a remote ISO file to the local memory region for booting and installation. Wiki page of UEFI HTTPBoot with OVMF: https://en.opensuse.org/UEFI_HTTPBoot_with_OVMF The ramdisk function in EDK2/OVMF generates a ACPI0012 root device that it contains empty _STA but without _DSM: DefinitionBlock ("ssdt2.aml", "SSDT", 2, "INTEL ", "RamDisk ", 0x00001000) { Scope (\_SB) { Device (NVDR) { Name (_HID, "ACPI0012") // _HID: Hardware ID Name (_STR, Unicode ("NVDIMM Root Device")) // _STR: Description String Method (_STA, 0, NotSerialized) // _STA: Status { Return (0x0F) } } } } In section 5.2.25.2 of ACPI 6.1 spec, it mentions that the "SPA Range Structure Index" of virtual SPA shall be set to zero. That means virtual SPA will not be associated by any NVDIMM region mapping. The VCD's SPA Range Structure in NFIT is similar to virtual disk region as following: [028h 0040 2] Subtable Type : 0000 [System Physical Address Range] [02Ah 0042 2] Length : 0038 [02Ch 0044 2] Range Index : 0000 [02Eh 0046 2] Flags (decoded below) : 0000 Add/Online Operation Only : 0 Proximity Domain Valid : 0 [030h 0048 4] Reserved : 00000000 [034h 0052 4] Proximity Domain : 00000000 [038h 0056 16] Address Range GUID : 77AB535A-45FC-624B-5560-F7B281D1F96E [048h 0072 8] Address Range Base : 00000000B6ABD018 [050h 0080 8] Address Range Length : 0000000005500000 [058h 0088 8] Memory Map Attribute : 0000000000000000 The way to not associate a SPA range is to never reference it from a "flush hint", "interleave", or "control region" table. After testing on OVMF, pmem driver can support the region that it doesn't assoicate to any NVDIMM mapping. So, treat VCD like pmem is a idea to get a pmem block device that it contains iso. v4: Instoduce nfit_spa_is_virtual() to check virtual ramdisk SPA and create pmem region. v3: To simplify patch, removed useless VCD region in libnvdimm. v2: Removed the code for setting VCD to a read-only region. Cc: Gary Lin <GLin@suse.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Ross Zwisler <ross.zwisler@linux.intel.com> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Linda Knippers <linda.knippers@hpe.com> Signed-off-by: Lee, Chun-Yi <jlee@suse.com> --- drivers/acpi/nfit.c | 8 +++++++- drivers/nvdimm/region_devs.c | 26 +++++++++++++++++++++++++- include/linux/libnvdimm.h | 2 ++ 3 files changed, 34 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html