diff mbox

[v2,6/8] acpi: bus: Enable HWP CPPC objects

Message ID 1472762024-88771-7-git-send-email-srinivas.pandruvada@linux.intel.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

srinivas pandruvada Sept. 1, 2016, 8:33 p.m. UTC
Need to set platform wide _OSC bits to enable CPPC and CPPC version 2.
If platform supports CPPC, then BIOS exposess CPPC tables.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/acpi/bus.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

kernel test robot Sept. 1, 2016, 11:15 p.m. UTC | #1
Hi Srinivas,

[auto build test ERROR on tip/sched/core]
[also build test ERROR on v4.8-rc4 next-20160825]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Srinivas-Pandruvada/Support-Intel-Turbo-Boost-Max-Technology-3-0/20160902-053224
config: arm64-allmodconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

   drivers/acpi/bus.c: In function 'acpi_bus_osc_support':
>> drivers/acpi/bus.c:333:32: error: implicit declaration of function 'boot_cpu_has' [-Werror=implicit-function-declaration]
     if (IS_ENABLED(CONFIG_X86) && boot_cpu_has(X86_FEATURE_HWP)) {
                                   ^
>> drivers/acpi/bus.c:333:45: error: 'X86_FEATURE_HWP' undeclared (first use in this function)
     if (IS_ENABLED(CONFIG_X86) && boot_cpu_has(X86_FEATURE_HWP)) {
                                                ^
   drivers/acpi/bus.c:333:45: note: each undeclared identifier is reported only once for each function it appears in
   cc1: some warnings being treated as errors

vim +/boot_cpu_has +333 drivers/acpi/bus.c

   327		if (IS_ENABLED(CONFIG_ACPI_PROCESSOR))
   328			capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PPC_OST_SUPPORT;
   329	
   330		capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_HOTPLUG_OST_SUPPORT;
   331		capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PCLPI_SUPPORT;
   332	
 > 333		if (IS_ENABLED(CONFIG_X86) && boot_cpu_has(X86_FEATURE_HWP)) {
   334			capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_CPC_SUPPORT;
   335			capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_CPCV2_SUPPORT;
   336		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
srinivas pandruvada Sept. 1, 2016, 11:46 p.m. UTC | #2
On Fri, 2016-09-02 at 07:15 +0800, kbuild test robot wrote:
> Hi Srinivas,
> 
> [auto build test ERROR on tip/sched/core]
> [also build test ERROR on v4.8-rc4 next-20160825]
> [cannot apply to tip/x86/core]
> [if your patch is applied to the wrong git tree, please drop us a
> note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --
> base=auto for convenience) to record what (public, well-known) commit
> your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more
> information]
> 
> url:    https://github.com/0day-ci/linux/commits/Srinivas-Pandruvada/
> Support-Intel-Turbo-Boost-Max-Technology-3-0/20160902-053224
> config: arm64-allmodconfig (attached as .config)
> compiler: aarch64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tes
> ts.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm64 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/acpi/bus.c: In function 'acpi_bus_osc_support':
> > 
> > > 
> > > drivers/acpi/bus.c:333:32: error: implicit declaration of
> > > function 'boot_cpu_has' [-Werror=implicit-function-declaration]
>      if (IS_ENABLED(CONFIG_X86) && boot_cpu_has(X86_FEATURE_HWP)) {
>                                    ^
I have to change back to 
#ifdef CONFIG_X86
 if (boot_cpu_has(X86_FEATURE_HWP)) {

I will submit an update.

> > 
> > > 
> > > drivers/acpi/bus.c:333:45: error: 'X86_FEATURE_HWP' undeclared
> > > (first use in this function)
>      if (IS_ENABLED(CONFIG_X86) && boot_cpu_has(X86_FEATURE_HWP)) {
>                                                 ^
>    drivers/acpi/bus.c:333:45: note: each undeclared identifier is
> reported only once for each function it appears in
>    cc1: some warnings being treated as errors
> 
> vim +/boot_cpu_has +333 drivers/acpi/bus.c
> 
>    327		if (IS_ENABLED(CONFIG_ACPI_PROCESSOR))
>    328			capbuf[OSC_SUPPORT_DWORD] |=
> OSC_SB_PPC_OST_SUPPORT;
>    329	
>    330		capbuf[OSC_SUPPORT_DWORD] |=
> OSC_SB_HOTPLUG_OST_SUPPORT;
>    331		capbuf[OSC_SUPPORT_DWORD] |=
> OSC_SB_PCLPI_SUPPORT;
>    332	
>  > 333		if (IS_ENABLED(CONFIG_X86) &&
> boot_cpu_has(X86_FEATURE_HWP)) {
>    334			capbuf[OSC_SUPPORT_DWORD] |=
> OSC_SB_CPC_SUPPORT;
>    335			capbuf[OSC_SUPPORT_DWORD] |=
> OSC_SB_CPCV2_SUPPORT;
>    336		}
> 
> ---
> 0-DAY kernel test infrastructure                Open Source
> Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel
> Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 85b7d07..1001b92 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -330,6 +330,11 @@  static void acpi_bus_osc_support(void)
 	capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_HOTPLUG_OST_SUPPORT;
 	capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_PCLPI_SUPPORT;
 
+	if (IS_ENABLED(CONFIG_X86) && boot_cpu_has(X86_FEATURE_HWP)) {
+		capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_CPC_SUPPORT;
+		capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_CPCV2_SUPPORT;
+	}
+
 	if (!ghes_disable)
 		capbuf[OSC_SUPPORT_DWORD] |= OSC_SB_APEI_SUPPORT;
 	if (ACPI_FAILURE(acpi_get_handle(NULL, "\\_SB", &handle)))