From patchwork Mon Mar 6 21:55:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 9607777 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 75DEA601D2 for ; Mon, 6 Mar 2017 22:27:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BED3C2793B for ; Mon, 6 Mar 2017 22:27:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B346C28484; Mon, 6 Mar 2017 22:27:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AF7352793B for ; Mon, 6 Mar 2017 22:27:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754320AbdCFW1w (ORCPT ); Mon, 6 Mar 2017 17:27:52 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:35327 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754199AbdCFW1r (ORCPT ); Mon, 6 Mar 2017 17:27:47 -0500 Received: by mail-pf0-f182.google.com with SMTP id j5so65992941pfb.2 for ; Mon, 06 Mar 2017 14:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XcAyseNL448kxyxhlNb6kTIwPRMQseQoZ6LzfGWI1Yw=; b=DkWccQi6J07fqR+KhGLnyCl1QsOo6mDdkpTzKNmUSMOwwudPMbFMlcIN7lXJ+t4zeF UGXpbo6gdO5nqTqpY22hAXfEfEhHjscXaQwLZfqb/ONXq1P0IzKz9nXLkuCRK22qIEg7 y4IYtXtDMANkL+Z7NRF1Apqm2PDqwwucUEUV0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XcAyseNL448kxyxhlNb6kTIwPRMQseQoZ6LzfGWI1Yw=; b=TdftErX8y4/8MIaIArghKY4XUCAvMltYcWIs+vhJ6PYiKr1Q0AyRy6tEnq5BEbvkgV e6ZAJrXYWlh2k152UY9DVYcVbY51lmGxLs8W9xqKUfF2sx4+Ir3LCk1Wwg21a+E2uCAf ackyGYqK4SjMQ+LGoGgFPsFe8NOfYEHJgxlQOpGZ3+3OlJ7chflAMckIzxsYNMUtWZOc D2wNWb4JMsgOYPFKoFTzUqdpjvgCU0BdDEpR7pAzMYKdTfLa+kRmenckLDJOyCGyS4hk /CWJJ4dq8pFgklbiHv+wM0t4AfsIJSeuVhzWS6rMv4zs8BycW0ws2U2gHAIRXF2KEGIi dT5w== X-Gm-Message-State: AMke39kdQjbb06HsGZvUui9rA/fUizd9g363CT/kd9FMpFpof1cMv4abWxMjlxJKor2rO0Gk X-Received: by 10.98.70.28 with SMTP id t28mr9842955pfa.176.1488837339694; Mon, 06 Mar 2017 13:55:39 -0800 (PST) Received: from www.outflux.net (173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133]) by smtp.gmail.com with ESMTPSA id m21sm41654962pgh.4.2017.03.06.13.55.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Mar 2017 13:55:38 -0800 (PST) From: Kees Cook To: linux-kernel@vger.kernel.org Cc: Kees Cook , Nobuhiro Iwamatsu , Qiuxu Zhuo , Ard Biesheuvel , Anton Vorontsov , Colin Cross , Tony Luck , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , "Rafael J. Wysocki" , Len Brown , Matt Fleming , Nathan Fontenot , Pan Xinhui , Daniel Axtens , Paul Gortmaker , Geliang Tang , linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, linux-doc@vger.kernel.org Subject: [PATCH 08/18] pstore: Switch pstore_mkfile to pass record Date: Mon, 6 Mar 2017 13:55:22 -0800 Message-Id: <1488837332-71582-9-git-send-email-keescook@chromium.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1488837332-71582-1-git-send-email-keescook@chromium.org> References: <1488837332-71582-1-git-send-email-keescook@chromium.org> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Instead of the long list of arguments, just pass the new record struct. Signed-off-by: Kees Cook --- fs/pstore/inode.c | 57 +++++++++++++++++++++++++++++----------------------- fs/pstore/internal.h | 5 +---- fs/pstore/platform.c | 6 +----- 3 files changed, 34 insertions(+), 34 deletions(-) diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c index 57c0646479f5..a98787bab3e6 100644 --- a/fs/pstore/inode.c +++ b/fs/pstore/inode.c @@ -302,9 +302,7 @@ bool pstore_is_mounted(void) * Load it up with "size" bytes of data from "buf". * Set the mtime & ctime to the date that this record was originally stored. */ -int pstore_mkfile(enum pstore_type_id type, char *psname, u64 id, int count, - char *data, bool compressed, size_t size, - struct timespec time, struct pstore_info *psi) +int pstore_mkfile(struct pstore_record *record) { struct dentry *root = pstore_sb->s_root; struct dentry *dentry; @@ -313,12 +311,13 @@ int pstore_mkfile(enum pstore_type_id type, char *psname, u64 id, int count, char name[PSTORE_NAMELEN]; struct pstore_private *private, *pos; unsigned long flags; + size_t size = record->size + record->ecc_notice_size; spin_lock_irqsave(&allpstore_lock, flags); list_for_each_entry(pos, &allpstore, list) { - if (pos->type == type && - pos->id == id && - pos->psi == psi) { + if (pos->type == record->type && + pos->id == record->id && + pos->psi == record->psi) { rc = -EEXIST; break; } @@ -336,48 +335,56 @@ int pstore_mkfile(enum pstore_type_id type, char *psname, u64 id, int count, private = kmalloc(sizeof *private + size, GFP_KERNEL); if (!private) goto fail_alloc; - private->type = type; - private->id = id; - private->count = count; - private->psi = psi; + private->type = record->type; + private->id = record->id; + private->count = record->count; + private->psi = record->psi; - switch (type) { + switch (record->type) { case PSTORE_TYPE_DMESG: scnprintf(name, sizeof(name), "dmesg-%s-%lld%s", - psname, id, compressed ? ".enc.z" : ""); + record->psi->name, record->id, + record->compressed ? ".enc.z" : ""); break; case PSTORE_TYPE_CONSOLE: - scnprintf(name, sizeof(name), "console-%s-%lld", psname, id); + scnprintf(name, sizeof(name), "console-%s-%lld", + record->psi->name, record->id); break; case PSTORE_TYPE_FTRACE: - scnprintf(name, sizeof(name), "ftrace-%s-%lld", psname, id); + scnprintf(name, sizeof(name), "ftrace-%s-%lld", + record->psi->name, record->id); break; case PSTORE_TYPE_MCE: - scnprintf(name, sizeof(name), "mce-%s-%lld", psname, id); + scnprintf(name, sizeof(name), "mce-%s-%lld", + record->psi->name, record->id); break; case PSTORE_TYPE_PPC_RTAS: - scnprintf(name, sizeof(name), "rtas-%s-%lld", psname, id); + scnprintf(name, sizeof(name), "rtas-%s-%lld", + record->psi->name, record->id); break; case PSTORE_TYPE_PPC_OF: scnprintf(name, sizeof(name), "powerpc-ofw-%s-%lld", - psname, id); + record->psi->name, record->id); break; case PSTORE_TYPE_PPC_COMMON: scnprintf(name, sizeof(name), "powerpc-common-%s-%lld", - psname, id); + record->psi->name, record->id); break; case PSTORE_TYPE_PMSG: - scnprintf(name, sizeof(name), "pmsg-%s-%lld", psname, id); + scnprintf(name, sizeof(name), "pmsg-%s-%lld", + record->psi->name, record->id); break; case PSTORE_TYPE_PPC_OPAL: - sprintf(name, "powerpc-opal-%s-%lld", psname, id); + scnprintf(name, sizeof(name), "powerpc-opal-%s-%lld", + record->psi->name, record->id); break; case PSTORE_TYPE_UNKNOWN: - scnprintf(name, sizeof(name), "unknown-%s-%lld", psname, id); + scnprintf(name, sizeof(name), "unknown-%s-%lld", + record->psi->name, record->id); break; default: scnprintf(name, sizeof(name), "type%d-%s-%lld", - type, psname, id); + record->type, record->psi->name, record->id); break; } @@ -387,13 +394,13 @@ int pstore_mkfile(enum pstore_type_id type, char *psname, u64 id, int count, if (!dentry) goto fail_lockedalloc; - memcpy(private->data, data, size); + memcpy(private->data, record->buf, size); inode->i_size = private->size = size; inode->i_private = private; - if (time.tv_sec) - inode->i_mtime = inode->i_ctime = time; + if (record->time.tv_sec) + inode->i_mtime = inode->i_ctime = record->time; d_add(dentry, inode); diff --git a/fs/pstore/internal.h b/fs/pstore/internal.h index da416e6591c9..af1df5a36d86 100644 --- a/fs/pstore/internal.h +++ b/fs/pstore/internal.h @@ -25,10 +25,7 @@ extern struct pstore_info *psinfo; extern void pstore_set_kmsg_bytes(int); extern void pstore_get_records(int); -extern int pstore_mkfile(enum pstore_type_id, char *psname, u64 id, - int count, char *data, bool compressed, - size_t size, struct timespec time, - struct pstore_info *psi); +extern int pstore_mkfile(struct pstore_record *record); extern bool pstore_is_mounted(void); #endif diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index 0503380704de..168e03fd5e58 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -814,11 +814,7 @@ void pstore_get_records(int quiet) record.psi)) > 0) { decompress_record(&record); - rc = pstore_mkfile(record.type, psi->name, record.id, - record.count, record.buf, - record.compressed, - record.size + record.ecc_notice_size, - record.time, record.psi); + rc = pstore_mkfile(&record); /* Free buffer other than big oops */ if (record.buf != big_oops_buf)