From patchwork Wed Mar 22 17:33:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joerg Roedel X-Patchwork-Id: 9639619 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 790226020B for ; Wed, 22 Mar 2017 17:34:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 618DE2841F for ; Wed, 22 Mar 2017 17:34:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5643328460; Wed, 22 Mar 2017 17:34:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 473DF2841F for ; Wed, 22 Mar 2017 17:33:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965118AbdCVRdq (ORCPT ); Wed, 22 Mar 2017 13:33:46 -0400 Received: from 8bytes.org ([81.169.241.247]:40663 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965106AbdCVRdm (ORCPT ); Wed, 22 Mar 2017 13:33:42 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 1B14A358; Wed, 22 Mar 2017 18:33:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1490204014; bh=Q6OtMNklfFDaAKW7NiNP2HLYiPc4YswfxpsypXVh9MI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iPZ6MoMpgXXmNMcq+RyOZGH2ZW6TtpLaakSGkzkGidRXqGq3e4EP52a006jhLBPWT iAuiPjhu9jGzbI9SymtY/CvefIrhqgCBuLVZjuhWxW8mSF9WVyTeAF5YMG3J04CpCx 35f9qoeQuFvMKUEglfW4qN1ZARSeEIn588/sNoWk4RowLJgwlpjelGjPNhc+cog9ZJ JjZOAzfY1CkhZZZWYVyaUQvIcNtroq6lxTf4yZ3lGuydO11iBn9L+mZppGuj6FR1IY aei8sAGRdp/8WZnUO+0uyi58zWJoo14b8xl9dsxvZG39p2Y0TWvuMh1p43XZuNvn45 Qngu5G4dK09Dg== From: Joerg Roedel To: "Rafael J. Wysocki" , Len Brown Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel Subject: [PATCH 1/3] ACPI, ioapic: Clear on-stack resource before using it Date: Wed, 22 Mar 2017 18:33:23 +0100 Message-Id: <1490204005-2733-2-git-send-email-joro@8bytes.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1490204005-2733-1-git-send-email-joro@8bytes.org> References: <1490204005-2733-1-git-send-email-joro@8bytes.org> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Joerg Roedel The on-stack resource-window 'win' in setup_res() is not properly initialized. This causes the pointers in the embedded 'struct resource' to contain stale pointers. These pointers (in my case the ->child pointer) gets later propagated to the global iomem_resources list, causing a #GP exception when the list is traversed in iomem_map_sanity_check(). Fixes: c183619b63ec ('x86/irq, ACPI: Implement ACPI driver to support IOAPIC hotplug') Signed-off-by: Joerg Roedel --- drivers/acpi/ioapic.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c index 1120dfd6..7e4fbf9 100644 --- a/drivers/acpi/ioapic.c +++ b/drivers/acpi/ioapic.c @@ -45,6 +45,12 @@ static acpi_status setup_res(struct acpi_resource *acpi_res, void *data) struct resource *res = data; struct resource_win win; + /* + * We might assign this to 'res' later, make sure all pointers are + * cleared before the resource is added to the global list + */ + memset(&win, 0, sizeof(win)); + res->flags = 0; if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM)) return AE_OK;