diff mbox

[V3] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

Message ID 1490450575-29450-1-git-send-email-okaya@codeaurora.org (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Sinan Kaya March 25, 2017, 2:02 p.m. UTC
ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI)
driver to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC
interfaces.

IPMI_SSIF is an alternative BMC communication method. It allows BMC to
be accessed over an I2C bus instead of a standard interface.

Change the dependency to IPMI_HANDLER so that ACPI_IPMI works with all
IPMI providers.

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/acpi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Corey Minyard March 26, 2017, 1:25 a.m. UTC | #1
On 03/25/2017 09:02 AM, Sinan Kaya wrote:
> ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI)
> driver to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC
> interfaces.
>
> IPMI_SSIF is an alternative BMC communication method. It allows BMC to
> be accessed over an I2C bus instead of a standard interface.
>
> Change the dependency to IPMI_HANDLER so that ACPI_IPMI works with all
> IPMI providers.

If the ACPI people ack this, I can queue it, or they can take it with:

Acked-by: Corey Minyard <cminyard@mvista.com>

Thanks,

-corey

> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> ---
>   drivers/acpi/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 83e5f7e..3e15bf8 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -256,7 +256,7 @@ config ACPI_PROCESSOR
>   
>   config ACPI_IPMI
>   	tristate "IPMI"
> -	depends on IPMI_SI
> +	depends on IPMI_HANDLER
>   	default n
>   	help
>   	  This driver enables the ACPI to access the BMC controller. And it


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sinan Kaya March 27, 2017, 2:21 p.m. UTC | #2
Rafael,

On 3/25/2017 9:25 PM, Corey Minyard wrote:
> If the ACPI people ack this, I can queue it, or they can take it with:
> 
> Acked-by: Corey Minyard <cminyard@mvista.com>

What's your preference?

Sinan
Corey Minyard March 28, 2017, 12:31 p.m. UTC | #3
On 03/27/2017 09:21 AM, Sinan Kaya wrote:
> Rafael,
>
> On 3/25/2017 9:25 PM, Corey Minyard wrote:
>> If the ACPI people ack this, I can queue it, or they can take it with:
>>
>> Acked-by: Corey Minyard <cminyard@mvista.com>
> What's your preference?

I can take it, it's all ready, I just need the ack.

-corey
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rafael J. Wysocki March 28, 2017, 3:20 p.m. UTC | #4
On Tuesday, March 28, 2017 07:31:50 AM Corey Minyard wrote:
> On 03/27/2017 09:21 AM, Sinan Kaya wrote:
> > Rafael,
> >
> > On 3/25/2017 9:25 PM, Corey Minyard wrote:
> >> If the ACPI people ack this, I can queue it, or they can take it with:
> >>
> >> Acked-by: Corey Minyard <cminyard@mvista.com>
> > What's your preference?
> 
> I can take it, it's all ready, I just need the ack.

OK, feel free to add an ACK from me then.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Corey Minyard March 28, 2017, 3:41 p.m. UTC | #5
On 03/28/2017 10:20 AM, Rafael J. Wysocki wrote:
> On Tuesday, March 28, 2017 07:31:50 AM Corey Minyard wrote:
>> On 03/27/2017 09:21 AM, Sinan Kaya wrote:
>>> Rafael,
>>>
>>> On 3/25/2017 9:25 PM, Corey Minyard wrote:
>>>> If the ACPI people ack this, I can queue it, or they can take it with:
>>>>
>>>> Acked-by: Corey Minyard <cminyard@mvista.com>
>>> What's your preference?
>> I can take it, it's all ready, I just need the ack.
> OK, feel free to add an ACK from me then.

Thanks, queued and going to the linux-next tomorrow.

-corey

> Thanks,
> Rafael
>

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sinan Kaya March 28, 2017, 7:04 p.m. UTC | #6
On 3/28/2017 11:41 AM, Corey Minyard wrote:
>> OK, feel free to add an ACK from me then.
> 
> Thanks, queued and going to the linux-next tomorrow.

thanks, does this include both of the ACPI/IPMI patches or just this one?
diff mbox

Patch

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 83e5f7e..3e15bf8 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -256,7 +256,7 @@  config ACPI_PROCESSOR
 
 config ACPI_IPMI
 	tristate "IPMI"
-	depends on IPMI_SI
+	depends on IPMI_HANDLER
 	default n
 	help
 	  This driver enables the ACPI to access the BMC controller. And it