| Message ID | 1495813051-146077-1-git-send-email-darcari@redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
You sent it to the wrong list and missed Rafael too. MAINTAINERS file should help getting these details in the future. On 26-05-17, 11:37, David Arcari wrote: > For a driver that does not set the CPUFREQ_STICKY flag, if all of the > ->init() calls fail, cpufreq_register_driver() should return an error. > This will prevent the driver from loading. > > Fixes: ce1bcfe94db8 ("cpufreq: check cpufreq_policy_list instead of scanning policies for all CPUs") > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Signed-off-by: David Arcari <darcari@redhat.com> + Cc: 4.0+ <stable@vger.kernel.org> # 4.0+ > --- > drivers/cpufreq/cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 0e3f649..26b643d 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -2468,6 +2468,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) > if (!(cpufreq_driver->flags & CPUFREQ_STICKY) && > list_empty(&cpufreq_policy_list)) { > /* if all ->init() calls failed, unregister */ > + ret = -ENODEV; > pr_debug("%s: No CPU initialized for driver %s\n", __func__, > driver_data->name); > goto err_if_unreg; Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On 05/29/2017 12:32 AM, Viresh Kumar wrote: > You sent it to the wrong list and missed Rafael too. MAINTAINERS file should > help getting these details in the future. Oops - my bad. Rafael - is this OK as is or would you prefer I resend this? Thanks, -DA > > On 26-05-17, 11:37, David Arcari wrote: >> For a driver that does not set the CPUFREQ_STICKY flag, if all of the >> ->init() calls fail, cpufreq_register_driver() should return an error. >> This will prevent the driver from loading. >> >> Fixes: ce1bcfe94db8 ("cpufreq: check cpufreq_policy_list instead of scanning policies for all CPUs") >> >> Cc: Viresh Kumar <viresh.kumar@linaro.org> >> Signed-off-by: David Arcari <darcari@redhat.com> > > + > Cc: 4.0+ <stable@vger.kernel.org> # 4.0+ > >> --- >> drivers/cpufreq/cpufreq.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c >> index 0e3f649..26b643d 100644 >> --- a/drivers/cpufreq/cpufreq.c >> +++ b/drivers/cpufreq/cpufreq.c >> @@ -2468,6 +2468,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) >> if (!(cpufreq_driver->flags & CPUFREQ_STICKY) && >> list_empty(&cpufreq_policy_list)) { >> /* if all ->init() calls failed, unregister */ >> + ret = -ENODEV; >> pr_debug("%s: No CPU initialized for driver %s\n", __func__, >> driver_data->name); >> goto err_if_unreg; > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, May 30, 2017 08:05:44 AM David Arcari wrote: > On 05/29/2017 12:32 AM, Viresh Kumar wrote: > > You sent it to the wrong list and missed Rafael too. MAINTAINERS file should > > help getting these details in the future. > > Oops - my bad. > > Rafael - is this OK as is or would you prefer I resend this? No need to resend, thanks! I've actually queued it up already. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 0e3f649..26b643d 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -2468,6 +2468,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) if (!(cpufreq_driver->flags & CPUFREQ_STICKY) && list_empty(&cpufreq_policy_list)) { /* if all ->init() calls failed, unregister */ + ret = -ENODEV; pr_debug("%s: No CPU initialized for driver %s\n", __func__, driver_data->name); goto err_if_unreg;
For a driver that does not set the CPUFREQ_STICKY flag, if all of the ->init() calls fail, cpufreq_register_driver() should return an error. This will prevent the driver from loading. Fixes: ce1bcfe94db8 ("cpufreq: check cpufreq_policy_list instead of scanning policies for all CPUs") Cc: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: David Arcari <darcari@redhat.com> --- drivers/cpufreq/cpufreq.c | 1 + 1 file changed, 1 insertion(+)