diff mbox

[v5,1/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ

Message ID 1500586563-7088-2-git-send-email-lho@apm.com (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Loc Ho July 20, 2017, 9:36 p.m. UTC 
This patch allows APEI generic error source table with external
IRQ to share a single IRQ.

Co-authored-by: Tuan Phan <tphan@apm.com>
Signed-off-by: Loc Ho <lho@apm.com>
---
 drivers/acpi/apei/ghes.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Borislav Petkov July 21, 2017, 6 a.m. UTC | #1 
On Thu, Jul 20, 2017 at 02:36:03PM -0700, Loc Ho wrote:
> This patch allows APEI generic error source table with external

"This patch" in a commit message is tautologically redundant.

> IRQ to share a single IRQ.

Because? More background please.

> Co-authored-by: Tuan Phan <tphan@apm.com>

I guess an invented tag is fine. What you can also do is say in free
text in the commit message that Tuan has helped.

> Signed-off-by: Loc Ho <lho@apm.com>
> ---

...
diff mbox

Patch

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index d661d45..eed09fc 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -1157,7 +1157,8 @@  static int ghes_probe(struct platform_device *ghes_dev)
 			       generic->header.source_id);
 			goto err_edac_unreg;
 		}
-		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
+		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
+				 "GHES IRQ", ghes);
 		if (rc) {
 			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
 			       generic->header.source_id);