| Message ID | 1525422930-27826-2-git-send-email-akshu.agrawal@amd.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Friday, May 4, 2018 10:34:44 AM CEST Akshu Agrawal wrote: > AMD SoC exposes clock for general purpose use. The clock registration > is done in clk-st driver. The MMIO mapping are passed on to the > clock driver for accessing the registers. > The misc clock handler will create MMIO mappings to access the > clock registers and enable the clock driver to expose the clock > for use of drivers which will connect to it. > > Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> > --- > v2: Submitted with dependent patch, removed unneeded kfree for devm_kzalloc Well, where's patch [1/2]? Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5/4/2018 3:36 PM, Rafael J. Wysocki wrote: > On Friday, May 4, 2018 10:34:44 AM CEST Akshu Agrawal wrote: >> AMD SoC exposes clock for general purpose use. The clock registration >> is done in clk-st driver. The MMIO mapping are passed on to the >> clock driver for accessing the registers. >> The misc clock handler will create MMIO mappings to access the >> clock registers and enable the clock driver to expose the clock >> for use of drivers which will connect to it. >> >> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> >> --- >> v2: Submitted with dependent patch, removed unneeded kfree for devm_kzalloc > > Well, where's patch [1/2]? > It's here: https://patchwork.kernel.org/patch/10380207/ Regards, Akshu > Thanks, > Rafael > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 4, 2018 at 12:09 PM, Agrawal, Akshu <Akshu.Agrawal@amd.com> wrote: > > > On 5/4/2018 3:36 PM, Rafael J. Wysocki wrote: >> On Friday, May 4, 2018 10:34:44 AM CEST Akshu Agrawal wrote: >>> AMD SoC exposes clock for general purpose use. The clock registration >>> is done in clk-st driver. The MMIO mapping are passed on to the >>> clock driver for accessing the registers. >>> The misc clock handler will create MMIO mappings to access the >>> clock registers and enable the clock driver to expose the clock >>> for use of drivers which will connect to it. >>> >>> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> >>> --- >>> v2: Submitted with dependent patch, removed unneeded kfree for devm_kzalloc >> >> Well, where's patch [1/2]? >> > > It's here: > https://patchwork.kernel.org/patch/10380207/ So can you please send them both as a series with the same CC list, add all of the relevant maintainers to that CC list and indicate whom you expect to take care of these patches? I think that they should go in together as they are clearly related to each other. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5/4/2018 3:45 PM, Rafael J. Wysocki wrote: > On Fri, May 4, 2018 at 12:09 PM, Agrawal, Akshu <Akshu.Agrawal@amd.com> wrote: >> >> >> On 5/4/2018 3:36 PM, Rafael J. Wysocki wrote: >>> On Friday, May 4, 2018 10:34:44 AM CEST Akshu Agrawal wrote: >>>> AMD SoC exposes clock for general purpose use. The clock registration >>>> is done in clk-st driver. The MMIO mapping are passed on to the >>>> clock driver for accessing the registers. >>>> The misc clock handler will create MMIO mappings to access the >>>> clock registers and enable the clock driver to expose the clock >>>> for use of drivers which will connect to it. >>>> >>>> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> >>>> --- >>>> v2: Submitted with dependent patch, removed unneeded kfree for devm_kzalloc >>> >>> Well, where's patch [1/2]? >>> >> >> It's here: >> https://patchwork.kernel.org/patch/10380207/ > > So can you please send them both as a series with the same CC list, > add all of the relevant maintainers to that CC list and indicate whom > you expect to take care of these patches? > Ok sure, I will send both the patches to combined cc list from ./scripts/get_maintainer.pl for each patch. Regards, Akshu > I think that they should go in together as they are clearly related to > each other. > > Thanks, > Rafael > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 4, 2018 at 12:23 PM, Agrawal, Akshu <Akshu.Agrawal@amd.com> wrote: > > > On 5/4/2018 3:45 PM, Rafael J. Wysocki wrote: >> On Fri, May 4, 2018 at 12:09 PM, Agrawal, Akshu <Akshu.Agrawal@amd.com> wrote: >>> >>> >>> On 5/4/2018 3:36 PM, Rafael J. Wysocki wrote: >>>> On Friday, May 4, 2018 10:34:44 AM CEST Akshu Agrawal wrote: >>>>> AMD SoC exposes clock for general purpose use. The clock registration >>>>> is done in clk-st driver. The MMIO mapping are passed on to the >>>>> clock driver for accessing the registers. >>>>> The misc clock handler will create MMIO mappings to access the >>>>> clock registers and enable the clock driver to expose the clock >>>>> for use of drivers which will connect to it. >>>>> >>>>> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> >>>>> --- >>>>> v2: Submitted with dependent patch, removed unneeded kfree for devm_kzalloc >>>> >>>> Well, where's patch [1/2]? >>>> >>> >>> It's here: >>> https://patchwork.kernel.org/patch/10380207/ >> >> So can you please send them both as a series with the same CC list, >> add all of the relevant maintainers to that CC list and indicate whom >> you expect to take care of these patches? >> > > Ok sure, I will send both the patches to combined cc list from > ./scripts/get_maintainer.pl for each patch. It also would be good to add a cover letter with an outline of all of the changes together. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5/4/2018 4:37 PM, Rafael J. Wysocki wrote: > On Fri, May 4, 2018 at 12:23 PM, Agrawal, Akshu <Akshu.Agrawal@amd.com> wrote: >> >> >> On 5/4/2018 3:45 PM, Rafael J. Wysocki wrote: >>> On Fri, May 4, 2018 at 12:09 PM, Agrawal, Akshu <Akshu.Agrawal@amd.com> wrote: >>>> >>>> >>>> On 5/4/2018 3:36 PM, Rafael J. Wysocki wrote: >>>>> On Friday, May 4, 2018 10:34:44 AM CEST Akshu Agrawal wrote: >>>>>> AMD SoC exposes clock for general purpose use. The clock registration >>>>>> is done in clk-st driver. The MMIO mapping are passed on to the >>>>>> clock driver for accessing the registers. >>>>>> The misc clock handler will create MMIO mappings to access the >>>>>> clock registers and enable the clock driver to expose the clock >>>>>> for use of drivers which will connect to it. >>>>>> >>>>>> Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> >>>>>> --- >>>>>> v2: Submitted with dependent patch, removed unneeded kfree for devm_kzalloc >>>>> >>>>> Well, where's patch [1/2]? >>>>> >>>> >>>> It's here: >>>> https://patchwork.kernel.org/patch/10380207/ >>> >>> So can you please send them both as a series with the same CC list, >>> add all of the relevant maintainers to that CC list and indicate whom >>> you expect to take care of these patches? >>> >> >> Ok sure, I will send both the patches to combined cc list from >> ./scripts/get_maintainer.pl for each patch. > > It also would be good to add a cover letter with an outline of all of > the changes together. > Done. I have sent the patches to combined mailing list, with a supporting cover letter. Regards, Akshu -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Akshu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on clk/clk-next]
[also build test WARNING on v4.17-rc3 next-20180504]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Akshu-Agrawal/clk-x86-Add-ST-oscout-platform-clock/20180504-220653
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
coccinelle warnings: (new ones prefixed by >>)
>> drivers/acpi/acpi_apd.c:114:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index d553b00..88b8a3e 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -11,6 +11,7 @@ */ #include <linux/clk-provider.h> +#include <linux/platform_data/clk-st.h> #include <linux/platform_device.h> #include <linux/pm_domain.h> #include <linux/clkdev.h> @@ -72,6 +73,50 @@ static int acpi_apd_setup(struct apd_private_data *pdata) } #ifdef CONFIG_X86_AMD_PLATFORM_DEVICE + +static int misc_check_res(struct acpi_resource *ares, void *data) +{ + struct resource res; + + return !acpi_dev_resource_memory(ares, &res); +} + +static int st_misc_setup(struct apd_private_data *pdata) +{ + struct acpi_device *adev = pdata->adev; + struct platform_device *clkdev; + struct st_clk_data *clk_data; + struct resource_entry *rentry; + struct list_head resource_list; + int ret; + + clk_data = devm_kzalloc(&adev->dev, sizeof(*clk_data), GFP_KERNEL); + if (!clk_data) + return -ENOMEM; + + INIT_LIST_HEAD(&resource_list); + ret = acpi_dev_get_resources(adev, &resource_list, misc_check_res, + NULL); + if (ret < 0) + return -ENOMEM; + + list_for_each_entry(rentry, &resource_list, node) { + clk_data->base = ioremap(rentry->res->start, + resource_size(rentry->res)); + break; + } + + acpi_dev_free_resource_list(&resource_list); + + clkdev = platform_device_register_data(&adev->dev, "clk-st", + PLATFORM_DEVID_NONE, clk_data, + sizeof(*clk_data)); + if (IS_ERR(clkdev)) + return PTR_ERR(clkdev); + + return 0; +} + static const struct apd_device_desc cz_i2c_desc = { .setup = acpi_apd_setup, .fixed_clk_rate = 133000000, @@ -94,6 +139,10 @@ static int acpi_apd_setup(struct apd_private_data *pdata) .fixed_clk_rate = 48000000, .properties = uart_properties, }; + +static const struct apd_device_desc st_misc_desc = { + .setup = st_misc_setup, +}; #endif #ifdef CONFIG_ARM64 @@ -179,6 +228,7 @@ static int acpi_apd_create_device(struct acpi_device *adev, { "AMD0020", APD_ADDR(cz_uart_desc) }, { "AMDI0020", APD_ADDR(cz_uart_desc) }, { "AMD0030", }, + { "AMD0040", APD_ADDR(st_misc_desc)}, #endif #ifdef CONFIG_ARM64 { "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
AMD SoC exposes clock for general purpose use. The clock registration is done in clk-st driver. The MMIO mapping are passed on to the clock driver for accessing the registers. The misc clock handler will create MMIO mappings to access the clock registers and enable the clock driver to expose the clock for use of drivers which will connect to it. Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com> --- v2: Submitted with dependent patch, removed unneeded kfree for devm_kzalloc drivers/acpi/acpi_apd.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+)