| Message ID | 1534589360-64938-1-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
| Series | acpi: remove a meaningless null check before debugfs_remove | expand |
+to maintainers On 2018/8/18 18:49, zhong jiang wrote: > debugfs_remove has taken null pointer into account. So it is safe > to remove the check before debugfs_remove. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > drivers/acpi/custom_method.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c > index e967c11..4451877 100644 > --- a/drivers/acpi/custom_method.c > +++ b/drivers/acpi/custom_method.c > @@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void) > > static void __exit acpi_custom_method_exit(void) > { > - if (cm_dentry) > - debugfs_remove(cm_dentry); > + debugfs_remove(cm_dentry); > } > > module_init(acpi_custom_method_init);
On Saturday, August 18, 2018 12:49:20 PM CEST zhong jiang wrote: > debugfs_remove has taken null pointer into account. So it is safe > to remove the check before debugfs_remove. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > drivers/acpi/custom_method.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c > index e967c11..4451877 100644 > --- a/drivers/acpi/custom_method.c > +++ b/drivers/acpi/custom_method.c > @@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void) > > static void __exit acpi_custom_method_exit(void) > { > - if (cm_dentry) > - debugfs_remove(cm_dentry); > + debugfs_remove(cm_dentry); > } > > module_init(acpi_custom_method_init); > Applied, thanks!
diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c index e967c11..4451877 100644 --- a/drivers/acpi/custom_method.c +++ b/drivers/acpi/custom_method.c @@ -92,8 +92,7 @@ static int __init acpi_custom_method_init(void) static void __exit acpi_custom_method_exit(void) { - if (cm_dentry) - debugfs_remove(cm_dentry); + debugfs_remove(cm_dentry); } module_init(acpi_custom_method_init);
debugfs_remove has taken null pointer into account. So it is safe to remove the check before debugfs_remove. Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/acpi/custom_method.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)