diff mbox series

[15/25] coresight: etm3x: Rearrange cp14 access detection

Message ID 1553107783-3340-16-git-send-email-suzuki.poulose@arm.com (mailing list archive)
State Not Applicable, archived
Headers show
Series coresight: Support for ACPI bindings | expand

Commit Message

Suzuki K Poulose March 20, 2019, 6:49 p.m. UTC 
As we are about to about refactor the platform specific handling,
move the DT property handling to generic helpers.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 drivers/hwtracing/coresight/coresight-etm3x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mathieu Poirier March 27, 2019, 10:05 p.m. UTC | #1 
On Wed, Mar 20, 2019 at 06:49:32PM +0000, Suzuki K Poulose wrote:
> As we are about to about refactor the platform specific handling,

s/about//

> move the DT property handling to generic helpers.
> 
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
>  drivers/hwtracing/coresight/coresight-etm3x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
> index 1b9ae3a..7137f06 100644
> --- a/drivers/hwtracing/coresight/coresight-etm3x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm3x.c
> @@ -800,9 +800,9 @@ static int etm_probe(struct amba_device *adev, const struct amba_id *id)
>  			return PTR_ERR(pdata);
>  
>  		adev->dev.platform_data = pdata;
> -		drvdata->use_cp14 = of_property_read_bool(np, "arm,cp14");
>  	}
>  
> +	drvdata->use_cp14 = fwnode_property_read_bool(dev->fwnode, "arm,cp14");
>  	dev_set_drvdata(dev, drvdata);
>  
>  	/* Validity for the resource is already checked by the AMBA core */
> -- 
> 2.7.4
>
Suzuki K Poulose March 28, 2019, 11:03 a.m. UTC | #2 
On 03/27/2019 10:05 PM, Mathieu Poirier wrote:
> On Wed, Mar 20, 2019 at 06:49:32PM +0000, Suzuki K Poulose wrote:
>> As we are about to about refactor the platform specific handling,
> 
> s/about//
> 
>> move the DT property handling to generic helpers.
>>

Thanks for spotting. Will fix it.

Suzuki
diff mbox series

Patch

diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
index 1b9ae3a..7137f06 100644
--- a/drivers/hwtracing/coresight/coresight-etm3x.c
+++ b/drivers/hwtracing/coresight/coresight-etm3x.c
@@ -800,9 +800,9 @@  static int etm_probe(struct amba_device *adev, const struct amba_id *id)
 			return PTR_ERR(pdata);
 
 		adev->dev.platform_data = pdata;
-		drvdata->use_cp14 = of_property_read_bool(np, "arm,cp14");
 	}
 
+	drvdata->use_cp14 = fwnode_property_read_bool(dev->fwnode, "arm,cp14");
 	dev_set_drvdata(dev, drvdata);
 
 	/* Validity for the resource is already checked by the AMBA core */