| Message ID | 1611833479-87653-1-git-send-email-zou_wei@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [-next] ACPI: tables: Mark acpi_init_fpdt with static keyword | expand |
Hi, Wei, Thanks for the patch. Given that there are a couple of things need to be fixed in the orignal patch, I'd prefer to refresh the patch with all the fixes included https://patchwork.kernel.org/project/linux-acpi/patch/20210129061548.13448-1-rui.zhang@intel.com/ what do you think? thanks, rui On Thu, 2021-01-28 at 19:31 +0800, Zou Wei wrote: > Fix the following sparse warning: > > drivers/acpi/acpi_fpdt.c:230:6: warning: symbol 'acpi_init_fpdt' was > not declared. Should it be static? > > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/acpi/acpi_fpdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c > index b810811..968f9cc 100644 > --- a/drivers/acpi/acpi_fpdt.c > +++ b/drivers/acpi/acpi_fpdt.c > @@ -227,7 +227,7 @@ static int fpdt_process_subtable(u64 address, u32 > subtable_type) > return 0; > } > > -void acpi_init_fpdt(void) > +static void acpi_init_fpdt(void) > { > acpi_status status; > struct acpi_table_header *header;
Hi Rui, You can fix it in your patch together. -----邮件原件----- 发件人: Zhang Rui [mailto:rui.zhang@intel.com] 发送时间: 2021年1月29日 14:25 收件人: Zouwei (Samuel) <zou_wei@huawei.com>; rjw@rjwysocki.net; lenb@kernel.org 抄送: linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org 主题: Re: [PATCH -next] ACPI: tables: Mark acpi_init_fpdt with static keyword Hi, Wei, Thanks for the patch. Given that there are a couple of things need to be fixed in the orignal patch, I'd prefer to refresh the patch with all the fixes included https://patchwork.kernel.org/project/linux-acpi/patch/20210129061548.13448-1-rui.zhang@intel.com/ what do you think? thanks, rui On Thu, 2021-01-28 at 19:31 +0800, Zou Wei wrote: > Fix the following sparse warning: > > drivers/acpi/acpi_fpdt.c:230:6: warning: symbol 'acpi_init_fpdt' was > not declared. Should it be static? > > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/acpi/acpi_fpdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c index > b810811..968f9cc 100644 > --- a/drivers/acpi/acpi_fpdt.c > +++ b/drivers/acpi/acpi_fpdt.c > @@ -227,7 +227,7 @@ static int fpdt_process_subtable(u64 address, u32 > subtable_type) > return 0; > } > > -void acpi_init_fpdt(void) > +static void acpi_init_fpdt(void) > { > acpi_status status; > struct acpi_table_header *header;
diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c index b810811..968f9cc 100644 --- a/drivers/acpi/acpi_fpdt.c +++ b/drivers/acpi/acpi_fpdt.c @@ -227,7 +227,7 @@ static int fpdt_process_subtable(u64 address, u32 subtable_type) return 0; } -void acpi_init_fpdt(void) +static void acpi_init_fpdt(void) { acpi_status status; struct acpi_table_header *header;
Fix the following sparse warning: drivers/acpi/acpi_fpdt.c:230:6: warning: symbol 'acpi_init_fpdt' was not declared. Should it be static? Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/acpi/acpi_fpdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)