diff mbox series

[v10,3/3] ACPI: delay enumeration of devices with a _DEP pointing to IVSC device

Message ID 1690631575-15124-4-git-send-email-wentong.wu@intel.com (mailing list archive)
State Mainlined, archived
Headers show
Series media: pci: intel: ivsc: Add driver of Intel Visual Sensing Controller(IVSC) | expand

Commit Message

Wu, Wentong July 29, 2023, 11:52 a.m. UTC
Inside IVSC, switching ownership requires an interface with two
different hardware modules, ACE and CSI. The software interface
to these modules is based on Intel MEI framework. Usually mei
client devices are dynamically created, so the info of consumers
depending on mei client devices is not present in the firmware
tables.

This causes problems with the probe ordering with respect to
drivers for consumers of these mei client devices. But on these
camera sensor devices, the ACPI nodes describing the sensors all
have a _DEP dependency on the matching mei bus ACPI device, so
adding IVSC mei bus ACPI device to acpi_honor_dep_ids allows
solving the probe-ordering problem by delaying the enumeration of
ACPI-devices which have a _DEP dependency on an IVSC mei bus ACPI
device.

On TGL platform, the HID of IVSC mei bus ACPI device is INTC1059,
and on ADL platform, the HID is INTC1095. So add both of them to
acpi_honor_dep_ids.

Signed-off-by: Wentong Wu <wentong.wu@intel.com>
---
 drivers/acpi/scan.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Sakari Ailus July 29, 2023, 9:44 p.m. UTC | #1
Hi Rafael,

On Sat, Jul 29, 2023 at 07:52:55PM +0800, Wentong Wu wrote:
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 2743444..59c92a9 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -796,6 +796,9 @@ static const char * const acpi_ignore_dep_ids[] = {
>  /* List of HIDs for which we honor deps of matching ACPI devs, when checking _DEP lists. */
>  static const char * const acpi_honor_dep_ids[] = {
>  	"INT3472", /* Camera sensor PMIC / clk and regulator info */
> +	"INTC1059", /* IVSC (TGL) driver must be loaded to allow i2c access to camera sensors */
> +	"INTC1095", /* IVSC (ADL) driver must be loaded to allow i2c access to camera sensors */
> +	"INTC100A", /* IVSC (RPL) driver must be loaded to allow i2c access to camera sensors */
>  	NULL
>  };
>  

Could this patch be merged via the ACPI tree? There's no direct dependency
to the two other patches in the set.

Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Rafael J. Wysocki Aug. 17, 2023, 4:30 p.m. UTC | #2
On Sat, Jul 29, 2023 at 11:44 PM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> Hi Rafael,
>
> On Sat, Jul 29, 2023 at 07:52:55PM +0800, Wentong Wu wrote:
> > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> > index 2743444..59c92a9 100644
> > --- a/drivers/acpi/scan.c
> > +++ b/drivers/acpi/scan.c
> > @@ -796,6 +796,9 @@ static const char * const acpi_ignore_dep_ids[] = {
> >  /* List of HIDs for which we honor deps of matching ACPI devs, when checking _DEP lists. */
> >  static const char * const acpi_honor_dep_ids[] = {
> >       "INT3472", /* Camera sensor PMIC / clk and regulator info */
> > +     "INTC1059", /* IVSC (TGL) driver must be loaded to allow i2c access to camera sensors */
> > +     "INTC1095", /* IVSC (ADL) driver must be loaded to allow i2c access to camera sensors */
> > +     "INTC100A", /* IVSC (RPL) driver must be loaded to allow i2c access to camera sensors */
> >       NULL
> >  };
> >
>
> Could this patch be merged via the ACPI tree? There's no direct dependency
> to the two other patches in the set.
>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Applied (under a slightly edited subject) as 6.6 material, thanks!
Sakari Ailus Aug. 18, 2023, 10:17 a.m. UTC | #3
On Thu, Aug 17, 2023 at 06:30:54PM +0200, Rafael J. Wysocki wrote:
> On Sat, Jul 29, 2023 at 11:44 PM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> >
> > Hi Rafael,
> >
> > On Sat, Jul 29, 2023 at 07:52:55PM +0800, Wentong Wu wrote:
> > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> > > index 2743444..59c92a9 100644
> > > --- a/drivers/acpi/scan.c
> > > +++ b/drivers/acpi/scan.c
> > > @@ -796,6 +796,9 @@ static const char * const acpi_ignore_dep_ids[] = {
> > >  /* List of HIDs for which we honor deps of matching ACPI devs, when checking _DEP lists. */
> > >  static const char * const acpi_honor_dep_ids[] = {
> > >       "INT3472", /* Camera sensor PMIC / clk and regulator info */
> > > +     "INTC1059", /* IVSC (TGL) driver must be loaded to allow i2c access to camera sensors */
> > > +     "INTC1095", /* IVSC (ADL) driver must be loaded to allow i2c access to camera sensors */
> > > +     "INTC100A", /* IVSC (RPL) driver must be loaded to allow i2c access to camera sensors */
> > >       NULL
> > >  };
> > >
> >
> > Could this patch be merged via the ACPI tree? There's no direct dependency
> > to the two other patches in the set.
> >
> > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> 
> Applied (under a slightly edited subject) as 6.6 material, thanks!

Thanks, Rafael!
diff mbox series

Patch

diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 2743444..59c92a9 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -796,6 +796,9 @@  static const char * const acpi_ignore_dep_ids[] = {
 /* List of HIDs for which we honor deps of matching ACPI devs, when checking _DEP lists. */
 static const char * const acpi_honor_dep_ids[] = {
 	"INT3472", /* Camera sensor PMIC / clk and regulator info */
+	"INTC1059", /* IVSC (TGL) driver must be loaded to allow i2c access to camera sensors */
+	"INTC1095", /* IVSC (ADL) driver must be loaded to allow i2c access to camera sensors */
+	"INTC100A", /* IVSC (RPL) driver must be loaded to allow i2c access to camera sensors */
 	NULL
 };