diff mbox

[2/3] ACPI: processor: make new processor.h header local to driver

Message ID 20090219195148.20619.14362.stgit@bob.kio (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Bjorn Helgaas Feb. 19, 2009, 7:51 p.m. UTC 
The processor-related declarations in acpi_drivers.h are used
only by the processor driver, which happens to be split across
several files.  This patch moves those declarations to a new
drivers/acpi/processor.h file.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
 drivers/acpi/processor.h         |    5 +++++
 drivers/acpi/processor_core.c    |    2 ++
 drivers/acpi/processor_thermal.c |    2 ++
 drivers/acpi/thermal.c           |    2 ++
 include/acpi/acpi_drivers.h      |   10 ----------
 5 files changed, 11 insertions(+), 10 deletions(-)
 create mode 100644 drivers/acpi/processor.h


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Len Brown Feb. 22, 2009, 3:58 a.m. UTC | #1 
we already have include/acpi/processor.h,
i'd rather not also have a drivers/acpi/processor.h

--
Len Brown, Intel Open Source Technology Center

On Thu, 19 Feb 2009, Bjorn Helgaas wrote:

> The processor-related declarations in acpi_drivers.h are used
> only by the processor driver, which happens to be split across
> several files.  This patch moves those declarations to a new
> drivers/acpi/processor.h file.
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
> ---
>  drivers/acpi/processor.h         |    5 +++++
>  drivers/acpi/processor_core.c    |    2 ++
>  drivers/acpi/processor_thermal.c |    2 ++
>  drivers/acpi/thermal.c           |    2 ++
>  include/acpi/acpi_drivers.h      |   10 ----------
>  5 files changed, 11 insertions(+), 10 deletions(-)
>  create mode 100644 drivers/acpi/processor.h
> 
> diff --git a/drivers/acpi/processor.h b/drivers/acpi/processor.h
> new file mode 100644
> index 0000000..51df8cb
> --- /dev/null
> +++ b/drivers/acpi/processor.h
> @@ -0,0 +1,5 @@
> +#define ACPI_PROCESSOR_LIMIT_NONE	0x00
> +#define ACPI_PROCESSOR_LIMIT_INCREMENT	0x01
> +#define ACPI_PROCESSOR_LIMIT_DECREMENT	0x02
> +
> +int acpi_processor_set_thermal_limit(acpi_handle handle, int type);
> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
> index 0cc2fd3..a744ad4 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -59,6 +59,8 @@
>  #include <acpi/acpi_drivers.h>
>  #include <acpi/processor.h>
>  
> +#include "processor.h"
> +
>  #define ACPI_PROCESSOR_CLASS		"processor"
>  #define ACPI_PROCESSOR_DEVICE_NAME	"Processor"
>  #define ACPI_PROCESSOR_FILE_INFO	"info"
> diff --git a/drivers/acpi/processor_thermal.c b/drivers/acpi/processor_thermal.c
> index b1eb376..a778ac2 100644
> --- a/drivers/acpi/processor_thermal.c
> +++ b/drivers/acpi/processor_thermal.c
> @@ -40,6 +40,8 @@
>  #include <acpi/processor.h>
>  #include <acpi/acpi_drivers.h>
>  
> +#include "processor.h"
> +
>  #define ACPI_PROCESSOR_CLASS            "processor"
>  #define _COMPONENT              ACPI_PROCESSOR_COMPONENT
>  ACPI_MODULE_NAME("processor_thermal");
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index 99e6f1f..23c5bc9 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -47,6 +47,8 @@
>  #include <acpi/acpi_bus.h>
>  #include <acpi/acpi_drivers.h>
>  
> +#include "processor.h"
> +
>  #define ACPI_THERMAL_CLASS		"thermal_zone"
>  #define ACPI_THERMAL_DEVICE_NAME	"Thermal Zone"
>  #define ACPI_THERMAL_FILE_STATE		"state"
> diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h
> index 9ea2684..4358917 100644
> --- a/include/acpi/acpi_drivers.h
> +++ b/include/acpi/acpi_drivers.h
> @@ -103,16 +103,6 @@ extern int acpi_power_nocheck;
>  int acpi_ec_ecdt_probe(void);
>  int acpi_boot_ec_enable(void);
>  
> -/* --------------------------------------------------------------------------
> -                                    Processor
> -   -------------------------------------------------------------------------- */
> -
> -#define ACPI_PROCESSOR_LIMIT_NONE	0x00
> -#define ACPI_PROCESSOR_LIMIT_INCREMENT	0x01
> -#define ACPI_PROCESSOR_LIMIT_DECREMENT	0x02
> -
> -int acpi_processor_set_thermal_limit(acpi_handle handle, int type);
> -
>  /*--------------------------------------------------------------------------
>                                    Dock Station
>    -------------------------------------------------------------------------- */
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/processor.h b/drivers/acpi/processor.h
new file mode 100644
index 0000000..51df8cb
--- /dev/null
+++ b/drivers/acpi/processor.h
@@ -0,0 +1,5 @@ 
+#define ACPI_PROCESSOR_LIMIT_NONE	0x00
+#define ACPI_PROCESSOR_LIMIT_INCREMENT	0x01
+#define ACPI_PROCESSOR_LIMIT_DECREMENT	0x02
+
+int acpi_processor_set_thermal_limit(acpi_handle handle, int type);
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index 0cc2fd3..a744ad4 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -59,6 +59,8 @@ 
 #include <acpi/acpi_drivers.h>
 #include <acpi/processor.h>
 
+#include "processor.h"
+
 #define ACPI_PROCESSOR_CLASS		"processor"
 #define ACPI_PROCESSOR_DEVICE_NAME	"Processor"
 #define ACPI_PROCESSOR_FILE_INFO	"info"
diff --git a/drivers/acpi/processor_thermal.c b/drivers/acpi/processor_thermal.c
index b1eb376..a778ac2 100644
--- a/drivers/acpi/processor_thermal.c
+++ b/drivers/acpi/processor_thermal.c
@@ -40,6 +40,8 @@ 
 #include <acpi/processor.h>
 #include <acpi/acpi_drivers.h>
 
+#include "processor.h"
+
 #define ACPI_PROCESSOR_CLASS            "processor"
 #define _COMPONENT              ACPI_PROCESSOR_COMPONENT
 ACPI_MODULE_NAME("processor_thermal");
diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index 99e6f1f..23c5bc9 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -47,6 +47,8 @@ 
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
 
+#include "processor.h"
+
 #define ACPI_THERMAL_CLASS		"thermal_zone"
 #define ACPI_THERMAL_DEVICE_NAME	"Thermal Zone"
 #define ACPI_THERMAL_FILE_STATE		"state"
diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h
index 9ea2684..4358917 100644
--- a/include/acpi/acpi_drivers.h
+++ b/include/acpi/acpi_drivers.h
@@ -103,16 +103,6 @@  extern int acpi_power_nocheck;
 int acpi_ec_ecdt_probe(void);
 int acpi_boot_ec_enable(void);
 
-/* --------------------------------------------------------------------------
-                                    Processor
-   -------------------------------------------------------------------------- */
-
-#define ACPI_PROCESSOR_LIMIT_NONE	0x00
-#define ACPI_PROCESSOR_LIMIT_INCREMENT	0x01
-#define ACPI_PROCESSOR_LIMIT_DECREMENT	0x02
-
-int acpi_processor_set_thermal_limit(acpi_handle handle, int type);
-
 /*--------------------------------------------------------------------------
                                   Dock Station
   -------------------------------------------------------------------------- */