From patchwork Tue Mar 31 23:02:17 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Garrett X-Patchwork-Id: 15524 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2VN3Ook025167 for ; Tue, 31 Mar 2009 23:03:24 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764034AbZCaXCZ (ORCPT ); Tue, 31 Mar 2009 19:02:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764149AbZCaXCZ (ORCPT ); Tue, 31 Mar 2009 19:02:25 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:43015 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764065AbZCaXCY (ORCPT ); Tue, 31 Mar 2009 19:02:24 -0400 Received: from mjg59 by vavatch.codon.org.uk with local (Exim 4.69) (envelope-from ) id 1LomyH-0008E3-4f; Wed, 01 Apr 2009 00:02:17 +0100 Date: Wed, 1 Apr 2009 00:02:17 +0100 From: Matthew Garrett To: Azael Avalos Cc: linux-acpi@vger.kernel.org, dsilvers@simtec.co.uk, toshiba_acpi@memebeam.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] toshiba-acpi: Support TOS1900-type devices Message-ID: <20090331230217.GA31599@srcf.ucam.org> References: <20090331214501.GC29489@srcf.ucam.org> <20090331214749.GD29489@srcf.ucam.org> <74962ea30903311506m41306659td0cd70c5736f6660@mail.gmail.com> <20090331221107.GA30383@srcf.ucam.org> <74962ea30903311519s2fb6087fxfe8859e3c570ac99@mail.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <74962ea30903311519s2fb6087fxfe8859e3c570ac99@mail.gmail.com> User-Agent: Mutt/1.5.12-2006-07-14 X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@codon.org.uk X-SA-Exim-Scanned: No (on vavatch.codon.org.uk); SAEximRunCond expanded to false Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Ok, can you try this and let me know what codes it generates (if it generates any)? It should go on top of the previous patches. diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 9fb4873..8552e1a 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -185,7 +185,6 @@ static int write_acpi_int(const char *methodName, int val) return (status == AE_OK); } -#if 0 static int read_acpi_int(const char *methodName, int *pVal) { struct acpi_buffer results; @@ -200,7 +199,6 @@ static int read_acpi_int(const char *methodName, int *pVal) return (status == AE_OK) && (out_objs[0].type == ACPI_TYPE_INTEGER); } -#endif static const char *method_hci /*= 0*/ ; @@ -802,6 +800,13 @@ static void toshiba_acpi_notify(acpi_handle handle, u32 event, void **data) if (event != 0x80) return; + + if (is_valid_acpi_path(TOSH_INTERFACE_2 SPFC_METHOD)) { + read_acpi_int(TOSH_INTERFACE_2 SPFC_METHOD, &value); + printk("Received 0x%x\n", value); + return; + } + do { hci_read1(HCI_SYSTEM_EVENT, &value, &hci_result); if (hci_result == HCI_SUCCESS) {