From patchwork Thu Jul 23 10:09:12 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Renninger X-Patchwork-Id: 36958 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n6NA9aZG021037 for ; Thu, 23 Jul 2009 10:09:36 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751188AbZGWKJQ (ORCPT ); Thu, 23 Jul 2009 06:09:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751342AbZGWKJP (ORCPT ); Thu, 23 Jul 2009 06:09:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47859 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbZGWKJO (ORCPT ); Thu, 23 Jul 2009 06:09:14 -0400 Received: from relay1.suse.de (relay-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 550134844E; Thu, 23 Jul 2009 12:09:14 +0200 (CEST) From: Thomas Renninger Organization: SUSE Products GmbH To: Zhang Rui Subject: Re: [PATCH] powernow-k8: don't load powernow-k8 driver when acpi=off Date: Thu, 23 Jul 2009 12:09:12 +0200 User-Agent: KMail/1.10.3 (Linux/2.6.27.23-0.1-default; KDE/4.1.3; x86_64; ; ) Cc: davej@redhat.com, "linux-acpi" , cpufreq@vger.kernel.org, Len Brown , howl.nsp@gmail.com, "Langsdorf, Mark" References: <1248315070.2670.16.camel@rzhang-dt> In-Reply-To: <1248315070.2670.16.camel@rzhang-dt> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200907231209.13343.trenn@suse.de> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thursday 23 July 2009 04:11:10 Zhang Rui wrote: > when acpi=off, powernow-k8 driver is still loaded, and fails with > a firmware bug warning message. > http://bugzilla.kernel.org/show_bug.cgi?id=13695#c5 > > this is misleading, > we should not load powernow-k8 driver when acpi=off. > http://bugzilla.kernel.org/show_bug.cgi?id=13695 Maybe this one is better: - It allows these special, deprecated PSB BIOS structure use in acpi=off case - It complains that powernow-k8 won't work without ACPI, instead of complaining about the BIOS missing _PSS ACPI structures (in acpi=off case). Compile tested on latest 2.6.31-rc2. Thomas ---- CPUFREQ: Avoid powernow-k8 BIOS complains when acpi=off - It still allows these special, deprecated PSB BIOS structure use in acpi=off case - It complains that powernow-k8 won't work without ACPI, instead of complaining about the BIOS missing _PSS ACPI structures (in acpi=off case). Signed-off-by: Thomas Renninger Signed-off-by: Zhang Rui Signed-off-by: Mark Langsdorf --- arch/x86/kernel/cpu/cpufreq/powernow-k8.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: cpufreq_governor_cleanups/arch/x86/kernel/cpu/cpufreq/powernow-k8.c =================================================================== --- cpufreq_governor_cleanups.orig/arch/x86/kernel/cpu/cpufreq/powernow-k8.c +++ cpufreq_governor_cleanups/arch/x86/kernel/cpu/cpufreq/powernow-k8.c @@ -1286,7 +1286,11 @@ static int __cpuinit powernowk8_cpu_init * an UP version, and is deprecated by AMD. */ if (num_online_cpus() != 1) { - printk_once(ACPI_PSS_BIOS_BUG_MSG); + if (acpi_disabled) + printk_once(KERN_WARN PFX + "ACPI disabled, exiting\n"); + else + printk_once(ACPI_PSS_BIOS_BUG_MSG); goto err_out; } if (pol->cpu != 0) {