From patchwork Wed Aug 26 01:38:26 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Woithe X-Patchwork-Id: 43827 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7Q1fDY9021018 for ; Wed, 26 Aug 2009 01:41:13 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932852AbZHZBjx (ORCPT ); Tue, 25 Aug 2009 21:39:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932874AbZHZBjk (ORCPT ); Tue, 25 Aug 2009 21:39:40 -0400 Received: from adelphi.physics.adelaide.edu.au ([129.127.102.1]:43114 "EHLO adelphi.physics.adelaide.edu.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932810AbZHZBji (ORCPT ); Tue, 25 Aug 2009 21:39:38 -0400 Received: from turbo.physics.adelaide.edu.au (IDENT:0@turbo [129.127.102.108]) by adelphi.physics.adelaide.edu.au (8.13.7/8.13.7/UofA-Physics-1.0) with ESMTP id n7Q1cRO9029255; Wed, 26 Aug 2009 11:08:27 +0930 Received: from turbo.physics.adelaide.edu.au (IDENT:7157@localhost [127.0.0.1]) by turbo.physics.adelaide.edu.au (8.13.4/8.13.4) with ESMTP id n7Q1cRBU008894; Wed, 26 Aug 2009 11:08:27 +0930 Received: (from jwoithe@localhost) by turbo.physics.adelaide.edu.au (8.13.4/8.13.4/Submit) id n7Q1cQxW008893; Wed, 26 Aug 2009 11:08:26 +0930 From: Jonathan Woithe Message-Id: <200908260138.n7Q1cQxW008893@turbo.physics.adelaide.edu.au> Subject: Re: [PATCH] fujitsu-laptop: support led-class as module To: sourcejedi.lkml@googlemail.com (Alan Jenkins) Date: Wed, 26 Aug 2009 11:08:26 +0930 (CST) Cc: jwoithe@physics.adelaide.edu.au (Jonathan Woithe), linux-acpi@vger.kernel.org, lenb@kernel.org In-Reply-To: <9b2b86520908250412j61a355aax55110f467c2ec61f@mail.gmail.com> from "Alan Jenkins" at Aug 25, 2009 12:12:17 PM X-Mailer: ELM [version 2.5 PL6] MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi > > Please consider slipping this in to 2.6.31-rc since it's a fairly trivial > > bug fix to ensure that fujitsu-laptop uses the LEDS class even when the LEDS > > class been compiled as a module. If that's not possible or viewed as > > inappropriate then let's go for 2.6.32. > > : > > Don't you need to exclude > > CONFIG_LEDS_CLASS=m > CONFIG_FUJITSU_LAPTOP=y Hmm, good point. Admittedly this would be a rare case since most distributors would ship with both CONFIG_LEDS_CLASS and CONFIG_FUJITSU_LAPTOP set to "m" - a situation which the proposed patch at least makes workable. > I think the Kconfig-fu is "depends on LEDS_CLASS || LEDS_CLASS=n". So, basically something like this should do the trick: signed-off-by: Alan Jenkins signed-off-by: Joathan Woithe Regards jonathan Signed-off-by: Alan Jenkins --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/platform/x86/Kconfig 2009-08-26 11:03:20.000000000 +0930 +++ b/drivers/platform/x86/Kconfig 2009-08-26 11:04:28.000000000 +0930 @@ -82,6 +82,7 @@ depends on ACPI depends on INPUT depends on BACKLIGHT_CLASS_DEVICE + depends on LEDS_CLASS || LEDS_CLASS=n ---help--- This is a driver for laptops built by Fujitsu: