From patchwork Tue Nov 17 22:27:31 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 60802 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nAHMSi3R026855 for ; Tue, 17 Nov 2009 22:28:56 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756365AbZKQW2t (ORCPT ); Tue, 17 Nov 2009 17:28:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756377AbZKQW2t (ORCPT ); Tue, 17 Nov 2009 17:28:49 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48049 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756365AbZKQW2s (ORCPT ); Tue, 17 Nov 2009 17:28:48 -0500 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id nAHMRWM4015098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 17 Nov 2009 14:27:33 -0800 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id nAHMRV26023190; Tue, 17 Nov 2009 14:27:31 -0800 Message-Id: <200911172227.nAHMRV26023190@imap1.linux-foundation.org> Subject: [patch 05/12] fujitsu-laptop: fix tests of acpi_evaluate_integer() return To: lenb@kernel.org Cc: linux-acpi@vger.kernel.org, akpm@linux-foundation.org, roel.kluin@gmail.com, jwoithe@physics.adelaide.edu.au From: akpm@linux-foundation.org Date: Tue, 17 Nov 2009 14:27:31 -0800 MIME-Version: 1.0 X-Spam-Status: No, hits=-3.518 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org diff -puN drivers/platform/x86/fujitsu-laptop.c~fujitsu-laptop-fix-tests-of-acpi_evaluate_integer-return drivers/platform/x86/fujitsu-laptop.c --- a/drivers/platform/x86/fujitsu-laptop.c~fujitsu-laptop-fix-tests-of-acpi_evaluate_integer-return +++ a/drivers/platform/x86/fujitsu-laptop.c @@ -376,7 +376,7 @@ static int get_lcd_level(void) status = acpi_evaluate_integer(fujitsu->acpi_handle, "GBLL", NULL, &state); - if (status < 0) + if (ACPI_FAILURE(status)) return status; fujitsu->brightness_level = state & 0x0fffffff; @@ -398,7 +398,7 @@ static int get_max_brightness(void) status = acpi_evaluate_integer(fujitsu->acpi_handle, "RBLL", NULL, &state); - if (status < 0) + if (ACPI_FAILURE(status)) return status; fujitsu->max_brightness = state;