diff mbox

[1/2] dell-wmi - properly handle errors returned by wmi_install_notify_handler()

Message ID 20091229083226.13097.22110.stgit@localhost.localdomain (mailing list archive)
State RFC, archived
Headers show

Commit Message

Dmitry Torokhov Dec. 29, 2009, 8:34 a.m. UTC
None
diff mbox

Patch

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index ff67a78..79bb1f1 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -265,6 +265,7 @@  static void __init find_hk_type(const struct dmi_header *dm, void *dummy)
 
 static int __init dell_wmi_init(void)
 {
+	acpi_status status;
 	int err;
 
 	if (!wmi_has_guid(DELL_EVENT_GUID)) {
@@ -279,12 +280,12 @@  static int __init dell_wmi_init(void)
 	if (err)
 		return err;
 
-	err = wmi_install_notify_handler(DELL_EVENT_GUID,
-					 dell_wmi_notify, NULL);
-	if (err) {
+	status = wmi_install_notify_handler(DELL_EVENT_GUID,
+					    dell_wmi_notify, NULL);
+	if (!ACPI_SUCCESS(status)) {
 		dell_wmi_input_destroy();
-		pr_err("Unable to register notify handler - %d\n", err);
-		return err;
+		pr_err("Unable to register notify handler - %d\n", status);
+		return -EIO;
 	}
 
 	return 0;