| Message ID | 20110826171052.7959.94505.stgit@bhelgaas.mtv.corp.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/27/2011 01:10 AM, Bjorn Helgaas wrote: > Use the normal %pR-like format for MMIO and I/O port ranges. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > --- > drivers/acpi/apei/apei-base.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c > index 8041248..8bd5f1a 100644 > --- a/drivers/acpi/apei/apei-base.c > +++ b/drivers/acpi/apei/apei-base.c > @@ -460,9 +460,9 @@ int apei_resources_request(struct apei_resources *resources, > desc); > if (!r) { > pr_err(APEI_PFX > - "Can not request iomem region <%016llx-%016llx> for GARs.\n", > + "Can not request [mem %#010llx-%#010llx] for %s registers\n", Why %#010llx instead of %#016llx? Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Aug 28, 2011 at 6:49 PM, Huang Ying <ying.huang@intel.com> wrote: > On 08/27/2011 01:10 AM, Bjorn Helgaas wrote: >> Use the normal %pR-like format for MMIO and I/O port ranges. >> >> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> >> --- >> drivers/acpi/apei/apei-base.c | 8 ++++---- >> 1 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c >> index 8041248..8bd5f1a 100644 >> --- a/drivers/acpi/apei/apei-base.c >> +++ b/drivers/acpi/apei/apei-base.c >> @@ -460,9 +460,9 @@ int apei_resources_request(struct apei_resources *resources, >> desc); >> if (!r) { >> pr_err(APEI_PFX >> - "Can not request iomem region <%016llx-%016llx> for GARs.\n", >> + "Can not request [mem %#010llx-%#010llx] for %s registers\n", > > Why %#010llx instead of %#016llx? Because %#010llx is effectively what we use for %pR. Two characters for "0x", then eight for the value. IMHO, sixteen uninterrupted hex characters is too hard to read. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/29/2011 10:08 PM, Bjorn Helgaas wrote: > On Sun, Aug 28, 2011 at 6:49 PM, Huang Ying <ying.huang@intel.com> wrote: >> On 08/27/2011 01:10 AM, Bjorn Helgaas wrote: >>> Use the normal %pR-like format for MMIO and I/O port ranges. >>> >>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> >>> --- >>> drivers/acpi/apei/apei-base.c | 8 ++++---- >>> 1 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c >>> index 8041248..8bd5f1a 100644 >>> --- a/drivers/acpi/apei/apei-base.c >>> +++ b/drivers/acpi/apei/apei-base.c >>> @@ -460,9 +460,9 @@ int apei_resources_request(struct apei_resources *resources, >>> desc); >>> if (!r) { >>> pr_err(APEI_PFX >>> - "Can not request iomem region <%016llx-%016llx> for GARs.\n", >>> + "Can not request [mem %#010llx-%#010llx] for %s registers\n", >> >> Why %#010llx instead of %#016llx? > > Because %#010llx is effectively what we use for %pR. Two characters > for "0x", then eight for the value. IMHO, sixteen uninterrupted hex > characters is too hard to read. That is reasonable. Thanks. Acked-by: Huang Ying <ying.huang@intel.com> Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 29, 2011 at 6:41 PM, Huang Ying <ying.huang@intel.com> wrote: > On 08/29/2011 10:08 PM, Bjorn Helgaas wrote: >> On Sun, Aug 28, 2011 at 6:49 PM, Huang Ying <ying.huang@intel.com> wrote: >>> On 08/27/2011 01:10 AM, Bjorn Helgaas wrote: >>>> Use the normal %pR-like format for MMIO and I/O port ranges. >>>> >>>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> >>>> --- >>>> drivers/acpi/apei/apei-base.c | 8 ++++---- >>>> 1 files changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c >>>> index 8041248..8bd5f1a 100644 >>>> --- a/drivers/acpi/apei/apei-base.c >>>> +++ b/drivers/acpi/apei/apei-base.c >>>> @@ -460,9 +460,9 @@ int apei_resources_request(struct apei_resources *resources, >>>> desc); >>>> if (!r) { >>>> pr_err(APEI_PFX >>>> - "Can not request iomem region <%016llx-%016llx> for GARs.\n", >>>> + "Can not request [mem %#010llx-%#010llx] for %s registers\n", >>> >>> Why %#010llx instead of %#016llx? >> >> Because %#010llx is effectively what we use for %pR. Two characters >> for "0x", then eight for the value. IMHO, sixteen uninterrupted hex >> characters is too hard to read. > > That is reasonable. Thanks. > > Acked-by: Huang Ying <ying.huang@intel.com> Disregard this patch; I'll send a v2 that does the same for another APEI file. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c index 8041248..8bd5f1a 100644 --- a/drivers/acpi/apei/apei-base.c +++ b/drivers/acpi/apei/apei-base.c @@ -460,9 +460,9 @@ int apei_resources_request(struct apei_resources *resources, desc); if (!r) { pr_err(APEI_PFX - "Can not request iomem region <%016llx-%016llx> for GARs.\n", + "Can not request [mem %#010llx-%#010llx] for %s registers\n", (unsigned long long)res->start, - (unsigned long long)res->end); + (unsigned long long)res->end - 1, desc); res_bak = res; goto err_unmap_iomem; } @@ -472,9 +472,9 @@ int apei_resources_request(struct apei_resources *resources, r = request_region(res->start, res->end - res->start, desc); if (!r) { pr_err(APEI_PFX - "Can not request ioport region <%016llx-%016llx> for GARs.\n", + "Can not request [io %#06llx-%#06llx] for %s registers\n", (unsigned long long)res->start, - (unsigned long long)res->end); + (unsigned long long)res->end - 1, desc); res_bak = res; goto err_unmap_ioport; }
Use the normal %pR-like format for MMIO and I/O port ranges. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/acpi/apei/apei-base.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html