From patchwork Thu Apr 11 23:44:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 2433021 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 46AB040060 for ; Thu, 11 Apr 2013 23:44:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406Ab3DKXob (ORCPT ); Thu, 11 Apr 2013 19:44:31 -0400 Received: from mail-ia0-f173.google.com ([209.85.210.173]:40041 "EHLO mail-ia0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803Ab3DKXoa (ORCPT ); Thu, 11 Apr 2013 19:44:30 -0400 Received: by mail-ia0-f173.google.com with SMTP id j5so1409049iaf.18 for ; Thu, 11 Apr 2013 16:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=5/g6zI134Q3lDcTBlOH9+AlAuX+db3kNzh+LxhqntmI=; b=Vo3pOrSbungMOoyGecRY3u+sVSGl0rAGvvMdH9d20+JoMat3Q0nezJzIS9MSNDJmYD sDExAk+iQF8pYj6jMrYEpT4AZ1VocGb752uTgnMzaeeXiAH4tHxXTkKeJ+DDe+LTK/b0 qL9h/N9y+SD1D/T2GtCdWA64NVQr4aB2oQlEdUlxGJc8O76KzOAxIj8XHQZhHWpJAGw8 ooxpRiL3UakVig6HIit80oYs6hQBlWFOoy2UprrTNUg+06pHxQ8CTLp4h/N6CokZMHDj YBWqgnaMvCoeE1yLMsvNPYCEbS8QzmW7dIFqzVdmoMMQOhmDRLnXCvs2Re81eoDuTpsb Odbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:x-gm-message-state; bh=5/g6zI134Q3lDcTBlOH9+AlAuX+db3kNzh+LxhqntmI=; b=f7HrcRxzwd/RHfYfdx62+VNRuS4J/ebeCbHsEsuP1l6FMlsR/kxm5DfHlBqSZYBSVq 2hqzzUy6gXnc54ptLC6uoBQoK1II4Zxh6DOg3OlCwE0sYH2lJC8bUSH34sAp/HBGNRN5 3x4AQYmmEP/J3FMEtGvQylOOEJvkAx6D1a2vXGtFk4wNhFTIj8EgfbeY0lYF9um/DiM+ U1oKjMMqyozUcNwlUpzM3tK0bFHcvXg1rbk8qc8yXrpqq+bZMDoTAH/52P0E1+/B8wwx avg+DYAxELoxGP3buQfStjzG/BjIh4spnb1vnkzmcGJkZXbQhSwItTMWmqMtpia+rUQ9 XePQ== X-Received: by 10.50.25.102 with SMTP id b6mr322461igg.27.1365723869560; Thu, 11 Apr 2013 16:44:29 -0700 (PDT) Received: from google.com ([172.16.49.242]) by mx.google.com with ESMTPS id ur12sm459238igb.8.2013.04.11.16.44.27 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 11 Apr 2013 16:44:28 -0700 (PDT) Date: Thu, 11 Apr 2013 17:44:26 -0600 From: Bjorn Helgaas To: Andrew Murray Cc: linux-pci@vger.kernel.org, "thierry.reding@avionic-design.de" , "thomas.petazzoni@free-electrons.com" , "jbarnes@virtuousgeek.org" , linux-acpi@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH] pci: Remove unnecessary dependency between PME and ACPI. Message-ID: <20130411234426.GA10196@google.com> References: <20130221155329.GA26729@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130221155329.GA26729@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQn/Lm6Y/V58EtczFKLRRwG1sg5MpBXYyBo+ndZT8IH8Xl/0KMgtTwv2FMQ7jgdIiMg5TUR8hiC9mQmtc80854P+cqZIPclOlq8nUEjE4gXKYt4JQkFO02q49eKywWDMetu4QK+LvTnr/kj0/6gxA1A0IynfoZUteLBeY8sVi5CLs9k30Mw5xkn6fhz11h6Lmy5YAKOvwx9u8pu4s7zAFBVgPxEZUQ== Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Feb 21, 2013 at 03:53:29PM +0000, Andrew Murray wrote: > Signed-off-by: Andrew Murray > Signed-off-by: Liviu Dudau > --- > drivers/pci/pcie/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig > index 6c8bc58..4cccd8c 100644 > --- a/drivers/pci/pcie/Kconfig > +++ b/drivers/pci/pcie/Kconfig > @@ -82,4 +82,4 @@ endchoice > > config PCIE_PME > def_bool y > - depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL && ACPI > + depends on PCIEPORTBUS && PM_RUNTIME && EXPERIMENTAL I think we can go even further and remove the ACPI-related #includes as in the patch below. Any objections to this? commit 8bde83b5f5519b630e7630fb735f76c184c74289 Author: Bjorn Helgaas Date: Thu Apr 11 17:36:50 2013 -0600 PCI: Remove unnecessary dependencies between PME and ACPI PCIe PME doesn't depend on ACPI, so remove the #includes and Kconfig dependency. Based-on-patch-by: Andrew Murray Signed-off-by: Bjorn Helgaas Acked-by: Rafael J. Wysocki --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig index fde4a32..569f82f 100644 --- a/drivers/pci/pcie/Kconfig +++ b/drivers/pci/pcie/Kconfig @@ -82,4 +82,4 @@ endchoice config PCIE_PME def_bool y - depends on PCIEPORTBUS && PM_RUNTIME && ACPI + depends on PCIEPORTBUS && PM_RUNTIME diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c index 9ca0dc9..795db1f 100644 --- a/drivers/pci/pcie/pme.c +++ b/drivers/pci/pcie/pme.c @@ -19,8 +19,6 @@ #include #include #include -#include -#include #include #include "../pci.h"