From patchwork Wed Oct 16 18:11:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 3056261 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0D899BF924 for ; Wed, 16 Oct 2013 18:12:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id ADAC9204B5 for ; Wed, 16 Oct 2013 18:12:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AA7E20266 for ; Wed, 16 Oct 2013 18:11:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761694Ab3JPSLg (ORCPT ); Wed, 16 Oct 2013 14:11:36 -0400 Received: from mail.skyhub.de ([78.46.96.112]:52898 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761691Ab3JPSLc (ORCPT ); Wed, 16 Oct 2013 14:11:32 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1381947091; bh=k1ptbjHKZy86JBSFBcToFG99Ek/XFStENE4hYUAsfL4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=VhDKgpT6OqKX2Yf12bBmEWm2ENjgongnvgzCdO lDJhPVFvN1kuvwRSh4qAE9/bUMWVFcgDeoBO69p6SVi6cMbGzpUCOTlYPa48b3MsTzF zZAg10kBTT5ooPdlgdlEJc1hPZCGgcYQVXkukZdcsEUQJy/TTbKRr1smABC7Bwzdc8= Received: from mail.skyhub.de ([127.0.0.1]) by localhost (door.skyhub.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id K3HJyBHN--Qs; Wed, 16 Oct 2013 20:11:31 +0200 (CEST) Received: from liondog.tnic (p4FF1D690.dip0.t-ipconnect.de [79.241.214.144]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D46B01DA243; Wed, 16 Oct 2013 20:11:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1381947091; bh=k1ptbjHKZy86JBSFBcToFG99Ek/XFStENE4hYUAsfL4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=VhDKgpT6OqKX2Yf12bBmEWm2ENjgongnvgzCdO lDJhPVFvN1kuvwRSh4qAE9/bUMWVFcgDeoBO69p6SVi6cMbGzpUCOTlYPa48b3MsTzF zZAg10kBTT5ooPdlgdlEJc1hPZCGgcYQVXkukZdcsEUQJy/TTbKRr1smABC7Bwzdc8= Received: by liondog.tnic (Postfix, from userid 1000) id 3F37D106B52; Wed, 16 Oct 2013 20:11:17 +0200 (CEST) Date: Wed, 16 Oct 2013 20:11:17 +0200 From: Borislav Petkov To: Steven Rostedt , "Chen, Gong" Cc: tony.luck@intel.com, joe@perches.com, naveen.n.rao@linux.vnet.ibm.com, arozansk@redhat.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/9] Extended H/W error log driver Message-ID: <20131016181117.GP13608@pd.tnic> References: <1381935366-11731-1-git-send-email-gong.chen@linux.intel.com> <20131016160550.GG13608@pd.tnic> <20131016125646.7141b580@gandalf.local.home> <20131016180038.GO13608@pd.tnic> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131016180038.GO13608@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Oct 16, 2013 at 08:00:38PM +0200, Borislav Petkov wrote: > Right, the only difference I can see is that include/ras/ras_event.h > doesn't have those below: > > #undef TRACE_INCLUDE_PATH > #undef TRACE_INCLUDE_FILE > #define TRACE_INCLUDE_PATH . > > Perhaps that is the problem? > > Gong, what is exactly the issue you're observing? Ok, I think I know what the issue is: Gong has diff --git a/drivers/acpi/extlog_trace.c b/drivers/acpi/extlog_trace.c new file mode 100644 index 000000000000..28640807fb09 --- /dev/null +++ b/drivers/acpi/extlog_trace.c @@ -0,0 +1,107 @@ +#include +#include +#include "extlog_trace.h" + +#define CREATE_TRACE_POINTS +#define TRACE_INCLUDE_PATH ../../include/ras +#include for the ras tracepoint although this is done already in drivers/edac/edac_mc.c Gong, can you try moving the CREATE_TRACE_POINTS line to a new file - arch/x86/ras/ras.c and define it there and not anywhere else, i.e. move it away from edac_mc.c. Does that help? Also, see Documentation/trace/tracepoints.txt for more info. HTH. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html