From patchwork Wed Jun 11 18:59:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 4338001 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E05369F314 for ; Wed, 11 Jun 2014 19:01:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F3E59202EC for ; Wed, 11 Jun 2014 19:01:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36D7D202BE for ; Wed, 11 Jun 2014 19:01:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbaFKS74 (ORCPT ); Wed, 11 Jun 2014 14:59:56 -0400 Received: from mail.skyhub.de ([78.46.96.112]:47817 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750963AbaFKS7x (ORCPT ); Wed, 11 Jun 2014 14:59:53 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1402513191; bh=gS9qPYWx5kta6hCEOxmHV39C4FqXS9jBnk5cpC5Qkro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=aAyaU66vbvA4lrrt1n5teTDF9354jx4EOoW+h4 UqLTJ3JF8jmIAgsI9DNiiuNGX2JCsivRz41FrzA7suBb3Japo5ad5Tj3hoAPN06vdQk Cx01tO9lRTXS8jXwHogcJDaAIZgpI2Y/Gb07/Sh8uLnJpImOOtC661V+2ohiPinLOE= Received: from mail.skyhub.de ([127.0.0.1]) by localhost (door.skyhub.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UESNDkM1gbUA; Wed, 11 Jun 2014 20:59:50 +0200 (CEST) Received: from liondog.tnic (p5DDC4B69.dip0.t-ipconnect.de [93.220.75.105]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 386B21DA26E; Wed, 11 Jun 2014 20:59:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1402513190; bh=gS9qPYWx5kta6hCEOxmHV39C4FqXS9jBnk5cpC5Qkro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=QauVVQZQNvGzLbl5KesJdo7FZeeBn6XKbBJQ5J 9WrSWH+r1w0eqe7fVZX+4ow474JLDxRXBtMSZ0J1EPKu28xS45oW+dWUQYKDrlLb0Qm 9kQyopJ+VjPQAITFShFcmw811SaEXBA8r4Dz/UhRsijXhlvjK2P4NvPT0LQx8gkH5g= Received: by liondog.tnic (Postfix, from userid 1000) id 0D64110105E; Wed, 11 Jun 2014 20:59:49 +0200 (CEST) Date: Wed, 11 Jun 2014 20:59:49 +0200 From: Borislav Petkov To: "Chen, Gong" Cc: tony.luck@intel.com, m.chehab@samsung.com, rostedt@goodmis.org, linux-acpi@vger.kernel.org, lkml Subject: Re: [PATCH 1/7 v5] trace, RAS: Add basic RAS trace event Message-ID: <20140611185948.GB14923@pd.tnic> References: <1402475691-30045-1-git-send-email-gong.chen@linux.intel.com> <1402475691-30045-2-git-send-email-gong.chen@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1402475691-30045-2-git-send-email-gong.chen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Jun 11, 2014 at 04:34:45AM -0400, Chen, Gong wrote: > To avoid confuision and conflict of usage for RAS related trace event, > add an unified RAS trace event stub. > > v5 -> v4: remove explicit RAS menuconfig. > v4 -> v3: change dependency rule of RAS_TRACE. > v3 -> v2: fix dependency in Kconfig. > v2 -> v1: adjust Kconfig to take RAS as a separate subsystem. Let's simplify it a little - I've dropped RAS_TRACE for now. We can carve it out later, when needed. --- From: "Chen, Gong" Subject: [PATCH 1/7 v5] trace, RAS: Add basic RAS trace event To avoid confuision and conflict of usage for RAS related trace event, add an unified RAS trace event stub. Start a RAS subsystem menu which will be fleshed out in time, when more features get added to it. Signed-off-by: Chen, Gong Link: http://lkml.kernel.org/r/1402475691-30045-2-git-send-email-gong.chen@linux.intel.com Signed-off-by: Borislav Petkov --- drivers/Kconfig | 2 ++ drivers/Makefile | 1 + drivers/edac/Kconfig | 1 + drivers/edac/edac_mc.c | 3 --- drivers/ras/Kconfig | 6 ++++++ drivers/ras/Makefile | 1 + drivers/ras/ras.c | 12 ++++++++++++ 7 files changed, 23 insertions(+), 3 deletions(-) create mode 100644 drivers/ras/Kconfig create mode 100644 drivers/ras/Makefile create mode 100644 drivers/ras/ras.c -- Index: linux/drivers/Kconfig =================================================================== --- linux.orig/drivers/Kconfig 2014-06-11 17:14:23.782437196 +0200 +++ linux/drivers/Kconfig 2014-06-11 17:14:23.770437196 +0200 @@ -176,4 +176,6 @@ source "drivers/powercap/Kconfig" source "drivers/mcb/Kconfig" +source "drivers/ras/Kconfig" + endmenu Index: linux/drivers/Makefile =================================================================== --- linux.orig/drivers/Makefile 2014-06-11 17:14:23.782437196 +0200 +++ linux/drivers/Makefile 2014-06-11 17:14:23.770437196 +0200 @@ -158,3 +158,4 @@ obj-$(CONFIG_NTB) += ntb/ obj-$(CONFIG_FMC) += fmc/ obj-$(CONFIG_POWERCAP) += powercap/ obj-$(CONFIG_MCB) += mcb/ +obj-$(CONFIG_RAS) += ras/ Index: linux/drivers/edac/Kconfig =================================================================== --- linux.orig/drivers/edac/Kconfig 2014-06-11 17:14:23.782437196 +0200 +++ linux/drivers/edac/Kconfig 2014-06-11 17:24:18.142427373 +0200 @@ -72,6 +72,7 @@ config EDAC_MCE_INJ config EDAC_MM_EDAC tristate "Main Memory EDAC (Error Detection And Correction) reporting" + select RAS help Some systems are able to detect and correct errors in main memory. EDAC can report statistics on memory error Index: linux/drivers/edac/edac_mc.c =================================================================== --- linux.orig/drivers/edac/edac_mc.c 2014-06-11 17:14:23.782437196 +0200 +++ linux/drivers/edac/edac_mc.c 2014-06-11 17:14:23.770437196 +0200 @@ -33,9 +33,6 @@ #include #include "edac_core.h" #include "edac_module.h" - -#define CREATE_TRACE_POINTS -#define TRACE_INCLUDE_PATH ../../include/ras #include /* lock to memory controller's control array */ Index: linux/drivers/ras/Kconfig =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ linux/drivers/ras/Kconfig 2014-06-11 17:24:00.846427659 +0200 @@ -0,0 +1,2 @@ +config RAS + bool Index: linux/drivers/ras/Makefile =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ linux/drivers/ras/Makefile 2014-06-11 17:14:23.774437196 +0200 @@ -0,0 +1 @@ +obj-$(CONFIG_RAS) += ras.o Index: linux/drivers/ras/ras.c =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ linux/drivers/ras/ras.c 2014-06-11 17:14:23.774437196 +0200 @@ -0,0 +1,12 @@ +/* + * Copyright (C) 2014 Intel Corporation + * + * Authors: + * Chen, Gong + */ + +#define CREATE_TRACE_POINTS +#define TRACE_INCLUDE_PATH ../../include/ras +#include + +EXPORT_TRACEPOINT_SYMBOL_GPL(mc_event);