From patchwork Fri Sep 12 18:02:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 4897521 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2BD9E9F430 for ; Fri, 12 Sep 2014 18:03:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 99E7020221 for ; Fri, 12 Sep 2014 18:07:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 308E62026F for ; Fri, 12 Sep 2014 18:07:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751377AbaILSDA (ORCPT ); Fri, 12 Sep 2014 14:03:00 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:43311 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbaILSC4 (ORCPT ); Fri, 12 Sep 2014 14:02:56 -0400 Received: by mail-ig0-f177.google.com with SMTP id h15so966354igd.16 for ; Fri, 12 Sep 2014 11:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=YRP8ODrj/NvCYR6jQs/HiwKAR92iny6aNx8AFr2cqrs=; b=Y8ymGZAXj1DWATXHhVO76YxQ4PpVZcmwEGmEUcRd2l5IQUNJb7gOgHLpokDVCHbEAp 4kRZpUYo4b6Rs8QX93yFA7vbpqbhmFhNxPB+IzdtPVkN7jsvzc6jLYVrkiuY6Gf5/9Y7 33K9VVBXZVgPquRsajO7kkdoHUb+q6kWwqinL0HhkS0hjwVSsWzIKHOojn82kroyeLVQ RwIeATkobOi5qEwc3OSVHi2gFinZXpYnn4hwyXMlAG6SVMuHbMseBN18pbQxpFiIKN1v yQQ4LBapknRO4pRRXYSgKkRceKaAJkCXirEwIVFJqRdpUNwilPoYLnOIha8QH8rffjS+ uiWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=YRP8ODrj/NvCYR6jQs/HiwKAR92iny6aNx8AFr2cqrs=; b=FHEBrxqM+u+OCmY3jYMI8y3+Wc62PQDr1zcTGcSlEKkLK9RL28pXLEulrB0CXeW6FC IME1Ntmi/V21xuwgUaPgL13IjNhcUO+YERPO1ab9blgC9A+Hm+TMnz4LLbZmZ9iIOsWx Lc3pJAIsH9ARcBSQ59lz+K3/Vu36gTTNnCSfIcPoCsQPuqM/PxWDX7EW6h/efmofL0RE n65PcqogVemt3a4w7EEUaiOSygy/eu1RfiB1l3UY7onXKWRUl1GJhRpHUfyJSS1G5nCO 28V8xuEwMijaxtNQT3NQ1PGulT/hOIwpKr9AvrjT2JasEk2JZGLiVBKGR/NxW1T4RSmf 8vFg== X-Gm-Message-State: ALoCoQmtegXm1y28b1pLS/BG1VaMeNbJG4OjoG+iiM5s8QcYepM2VnTSMsnmuDAAk7UUNtj1wfXb X-Received: by 10.50.32.2 with SMTP id e2mr4191318igi.33.1410544975688; Fri, 12 Sep 2014 11:02:55 -0700 (PDT) Received: from localhost ([172.16.49.108]) by mx.google.com with ESMTPSA id an1sm2089137igc.8.2014.09.12.11.02.54 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 12 Sep 2014 11:02:55 -0700 (PDT) Subject: [PATCH v1 01/13] PCI: Remove "no hotplug settings from platform" warning To: linux-pci@vger.kernel.org From: Bjorn Helgaas Cc: Rajat Jain , Linus Torvalds , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Yinghai Lu Date: Fri, 12 Sep 2014 12:02:54 -0600 Message-ID: <20140912180254.1630.79691.stgit@bhelgaas-glaptop2.roam.corp.google.com> In-Reply-To: <20140912180141.1630.17120.stgit@bhelgaas-glaptop2.roam.corp.google.com> References: <20140912180141.1630.17120.stgit@bhelgaas-glaptop2.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We print way too many messages like this: pci 0000:00:00.0: no hotplug settings from platform pci 0000:00:00.0: using default PCI settings This usually happens when the platform doesn't supply an ACPI _HPP method, but the method is optional, so there's no point in warning about it. Not only are the messages useless, but we call pci_configure_slot() far too many times, so they're repeated many times. I'll fix the overuse of pci_configure_slot() too, but that will wait until the next merge window. For now, just remove both log messages. Link: https://bugzilla.kernel.org/show_bug.cgi?id=84391 Signed-off-by: Bjorn Helgaas --- drivers/pci/hotplug/pcihp_slot.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/hotplug/pcihp_slot.c b/drivers/pci/hotplug/pcihp_slot.c index e246a10a0d2c..3e36ec8d708a 100644 --- a/drivers/pci/hotplug/pcihp_slot.c +++ b/drivers/pci/hotplug/pcihp_slot.c @@ -46,7 +46,6 @@ static void program_hpp_type0(struct pci_dev *dev, struct hpp_type0 *hpp) */ if (pci_is_pcie(dev)) return; - dev_info(&dev->dev, "using default PCI settings\n"); hpp = &pci_default_type0; } @@ -153,7 +152,6 @@ void pci_configure_slot(struct pci_dev *dev) { struct pci_dev *cdev; struct hotplug_params hpp; - int ret; if (!(dev->hdr_type == PCI_HEADER_TYPE_NORMAL || (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE && @@ -163,9 +161,7 @@ void pci_configure_slot(struct pci_dev *dev) pcie_bus_configure_settings(dev->bus); memset(&hpp, 0, sizeof(hpp)); - ret = pci_get_hp_params(dev, &hpp); - if (ret) - dev_warn(&dev->dev, "no hotplug settings from platform\n"); + pci_get_hp_params(dev, &hpp); program_hpp_type2(dev, hpp.t2); program_hpp_type1(dev, hpp.t1);