From patchwork Wed Dec 24 20:16:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugene Korenevsky X-Patchwork-Id: 5540241 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A01F3BEEA8 for ; Wed, 24 Dec 2014 20:15:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 83B22201E4 for ; Wed, 24 Dec 2014 20:15:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D16E201C8 for ; Wed, 24 Dec 2014 20:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbaLXUO7 (ORCPT ); Wed, 24 Dec 2014 15:14:59 -0500 Received: from mail-la0-f50.google.com ([209.85.215.50]:62827 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751483AbaLXUO7 (ORCPT ); Wed, 24 Dec 2014 15:14:59 -0500 Received: by mail-la0-f50.google.com with SMTP id pn19so7282415lab.23 for ; Wed, 24 Dec 2014 12:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=zFOJwN+ovikh34P4CRdciZlA3jOmOqRI+qXYV1hRNwM=; b=ZNiaeqm8gdqNGW/9BwRpQuqbcmyhQUJPVIeBf3ymQ3RhOue/Qh/O+fPd1ZU60NuU/8 BP2LNMN45P78sL4UetxxbI8LTpEBUJybnSONiIAi+Zljhik1RD40pei/mKFEFMfcz0Gr mlKiJOOReXWWun7GTzwiTj46ORoY42W9Oz0Qx3IkzqNhvPzhPjWfEC38ta/+Q1B2gx45 O7G/kTrhhg20kCLD/TeMvHpn2Ns/NTjM2t0aUPvY3bd+9ZuavSIG8jXhswnJnRlVR8Fe Eef58QBSd034CAw+DtBwUgr7yMh4Y/tfb0yjH+F821G7JCegTZV5cBOPxC6s8XFNMmU4 ov3Q== X-Received: by 10.112.161.35 with SMTP id xp3mr36012560lbb.70.1419452097721; Wed, 24 Dec 2014 12:14:57 -0800 (PST) Received: from localhost (ip-95-220-220-216.bb.netbynet.ru. [95.220.220.216]) by mx.google.com with ESMTPSA id t10sm3454127lat.31.2014.12.24.12.14.56 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Wed, 24 Dec 2014 12:14:56 -0800 (PST) Date: Wed, 24 Dec 2014 23:16:48 +0300 From: Eugene Korenevsky To: linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Len Brown Subject: [PATCH] acpi: remove pointless checks for NULL pointer Message-ID: <20141224201648.GA15251@gnote> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A trivial fix. No need to check `p` for NULL. `resource` pointer is valid therefore `p` is also valid. Signed-off-by: Eugene Korenevsky --- drivers/acpi/pci_link.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c index cfd7581..6379186 100644 --- a/drivers/acpi/pci_link.c +++ b/drivers/acpi/pci_link.c @@ -111,7 +111,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource, case ACPI_RESOURCE_TYPE_IRQ: { struct acpi_resource_irq *p = &resource->data.irq; - if (!p || !p->interrupt_count) { + if (!p->interrupt_count) { ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Blank _PRS IRQ resource\n")); return AE_OK; @@ -137,7 +137,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource, { struct acpi_resource_extended_irq *p = &resource->data.extended_irq; - if (!p || !p->interrupt_count) { + if (!p->interrupt_count) { printk(KERN_WARNING PREFIX "Blank _PRS EXT IRQ resource\n"); return AE_OK; @@ -198,7 +198,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource, case ACPI_RESOURCE_TYPE_IRQ: { struct acpi_resource_irq *p = &resource->data.irq; - if (!p || !p->interrupt_count) { + if (!p->interrupt_count) { /* * IRQ descriptors may have no IRQ# bits set, * particularly those those w/ _STA disabled @@ -214,7 +214,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource, { struct acpi_resource_extended_irq *p = &resource->data.extended_irq; - if (!p || !p->interrupt_count) { + if (!p->interrupt_count) { /* * extended IRQ descriptors must * return at least 1 IRQ